Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbXEHGnb (ORCPT ); Tue, 8 May 2007 02:43:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755524AbXEHGnY (ORCPT ); Tue, 8 May 2007 02:43:24 -0400 Received: from ozlabs.org ([203.10.76.45]:48244 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755456AbXEHGnT (ORCPT ); Tue, 8 May 2007 02:43:19 -0400 Subject: Re: [patch 25/29] xen: Add the Xen virtual network device driver. From: Rusty Russell To: Jeremy Fitzhardinge Cc: Christoph Hellwig , Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, lkml , Chris Wright , Ian Pratt , Christian Limpach , netdev@vger.kernel.org, Jeff Garzik , Stephen Hemminger , Herbert Xu In-Reply-To: <464018F2.7050409@goop.org> References: <20070504232051.411946839@goop.org> <20070504232121.492190579@goop.org> <20070505091624.GA8890@infradead.org> <463F9608.40803@goop.org> <1178577322.28438.16.camel@localhost.localdomain> <464018F2.7050409@goop.org> Content-Type: text/plain Date: Tue, 08 May 2007 16:42:54 +1000 Message-Id: <1178606574.7286.3.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 20 On Mon, 2007-05-07 at 23:30 -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > Looks good, you can slightly improve it to be the model use of new > > module_param types by calling your functions param_set_rx_mode and > > param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode, > > 0400)" > > > > Cute. I tried it out, but it doesn't yield an obvious improvement: Of course not, but it's the Right Way! Thanks, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/