Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Usyskin, Alexander" <alexander.usyskin@intel.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Won Chung <wonchung@google.com>,
        "Winkler, Tomas" <tomas.winkler@intel.com>
CC:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Benson Leung <bleung@chromium.org>,
        Prashant Malani <pmalani@chromium.org>,
        "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/2] thunderbolt: Link USB4 ports to their USB Type-C
 connectors
Thread-Topic: [PATCH 0/2] thunderbolt: Link USB4 ports to their USB Type-C
 connectors
Thread-Index: AQHYU04XncBI3ssso0mb0+jIcO6ZNaz4otoAgABg7YCAAN/TgIAEqV9Q
Date:   Sun, 24 Apr 2022 05:12:39 +0000
Message-ID: <MW3PR11MB46517BE51D4DCBC02B463C0EEDF99@MW3PR11MB4651.namprd11.prod.outlook.com>
References: <20220418175932.1809770-1-wonchung@google.com>
 <Yl/l7gjRXj41a93q@lahna>
 <CAOvb9yidpOZ4jCjme+u1a4fPTRnLmxUHSTO3yHPPuYtDbe1V0g@mail.gmail.com>
 <YmDy/xEsyktRS6D+@lahna>
In-Reply-To: <YmDy/xEsyktRS6D+@lahna>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.15
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f7GyBDd5mdGfMD6kjsrgDXnyWVNNG1Vt21x+L/htLqrtZK7SYPWt5yqNVosj?=
 =?us-ascii?Q?uTzLUBWxr+uAAF3EqZ2LP37TBmTJgttr8jThYIOnDnswTPLDVNfKwGjdeZfK?=
 =?us-ascii?Q?pqwZw18VafUBMFwR1+DI6vOW0yG+BfSTO3AzyqxG1K00XZz/nYtqS+D2S3OA?=
 =?us-ascii?Q?tfUDjTAoI2Et9Y5pks7KgVtDaOLAFHEb0GliuWsza6iVdbfxor5e8ILFWn21?=
 =?us-ascii?Q?i/yCYmUd3L+RKWwyftKvfE+igaxxfEG4wjdRKD8jY043y0gVIwxXT5omk4TJ?=
 =?us-ascii?Q?VxYD+1t4kBdspDagpBF+vL8+Z/SVUDld+GzMq/4uihfOMfbQWqhA7eKc3w6M?=
 =?us-ascii?Q?Wco4je4WBtY7s4DrAyetYsT5WyWm++L1mZZQhbzM8Pc9GPptPXKlDZHOSS5i?=
 =?us-ascii?Q?xHl/E0fRZzjFggDYpeQESrz30+S697XvpHKYjuDQbuBUJ//h6bhxOPOz+uCF?=
 =?us-ascii?Q?wEAS9sArwOZug9X8i7k2GCLm/sROA/S7pD62fS68QGCllEB+vxmDSJzM7xk0?=
 =?us-ascii?Q?5UZM/T6Nlt2kB6vuHlkzdQSzRtQlnUpJ9OQ2IwP6L0mjkNUQMYQulzhoIAHG?=
 =?us-ascii?Q?hza+Yb7ni8EO67aK0+Vk7RYZpCX4plRomY2B2oHfoOlNeXzApi+m4PBRrdrL?=
 =?us-ascii?Q?B2FIpj/7B+6ZVfcnijqJbAlUlIMwCIToCd7AZu3yXaW0femJPiPCYwfYsh0c?=
 =?us-ascii?Q?uWqnumNETvIMYBjgvRE7rCQ5ncK90t5qYW2nmnndMrYYtV6Fb0qRAQMuVdHu?=
 =?us-ascii?Q?+xAOFMZydAbganFlIuj/WvfIv1q+NtnrThfjqkvbhrIP2vSRGbATsAoyIs0z?=
 =?us-ascii?Q?u01Hk9spBoaiAxK2Wkt6afA6sZh99LWPaMv86Diy0dBN9lwopVdJhktaegaZ?=
 =?us-ascii?Q?wOSIaR3CZvW9o0q3sHpdVrFU6pQpWT9Pq/SioDHcLDlc11zj/JzLOOA4Lu7Y?=
 =?us-ascii?Q?e2VSQJnKJy2v4WJVUW85fsUznqmTRVYSdOluOahGOaE1+g/1Wpx2JzQIf32g?=
 =?us-ascii?Q?Gl0ImwtvvcQOHpRDYFAm606mQB/cT06Cs7BmgLECftj+NuhMSc1Njf16Seyy?=
 =?us-ascii?Q?a5UsjKpY91QcbsPmdl251usT1B2I4WmKFLjsW8B/FvTjnZ/tNIC6r7voSdDs?=
 =?us-ascii?Q?EKKMYjYQOVm8vjUmgOhxPIqrQCZUH/KEEtuWw51xj0xeEcaqdhJaPdb4XVNr?=
 =?us-ascii?Q?xZttUgTGAsk5KVsdku5eC425bGBaKIm6AsPTPkaGQ3e/Lj/8zGVWGOvjISTk?=
 =?us-ascii?Q?OraGM7PvFQjtyCGKCMQqzdytWlw9IwgRlmaGpbw1JyFAkl60j3Wo6kq6J0R+?=
 =?us-ascii?Q?VbFKfGf6Hu9Fq4ZtSlOT9H4kAstTzHeI6RrwydkPrYAXVtyDvQTY2CQZvrL3?=
 =?us-ascii?Q?QbueblnPM3yQqqwI2B8IAvGfg0xsHTUvuOnknFSClpa1p7MuZ7PMFXF63A15?=
 =?us-ascii?Q?ZBm0IO2rVbFBdYZoRqGGt+ITdSg1DWMbLy/CYHuLMPWqgToLAdfh6AeUBHjY?=
 =?us-ascii?Q?s4VmdvHASVvoxjyVBob2P0HTmPNhkHmDDbZas0TVHHma7voQpeY4mQC9n74k?=
 =?us-ascii?Q?dJX0MUdi29MwQxpJGIg8/mHMTvFI4aafYUV3qZI4c0D1gpa5boDyZ8n7ffC6?=
 =?us-ascii?Q?1YNc1Fpmyp8b6ObH6RhdweSZUMreybGL3UkWrgMCRJ6Gw03kW22TTnhUP18S?=
 =?us-ascii?Q?gvDfSY/5XjQj4KLapVGY/lgXyqziBfusCuEdaKo9oDh1GYYn+sM56xIgaG2E?=
 =?us-ascii?Q?fhbG3RYz/OTNZlKolixK6Cgj2l5xtzU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4651.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b23d37a-2602-42b8-c1b3-08da25b10dec
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2022 05:12:39.8780
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5wFeK0hS9zHzsI3Dn5GPs2/+vECCjLVoldbuH9ffUyRrg92wxjEKibfbadpw2cISFzB1bm6481mUiGS66Ank6rcuNm/IVrSkCVnN44e1ZVU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1238
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > > Currently, USB port is linked to Type C connector, using the compon=
ent
> > > > framework, if they share the same _PLD fields from ACPI table. Type=
 C
> > > > port-mapper searches for devices with the same _PLD values, and
> > > > aggregate them as components.
> > > >
> > > > When there is another device that share the same _PLD but does not
> > > > registers a component, Type C connector (component master) would ne=
ver
> > > > be bound due to a component match entry device without a component
> > > > registered. There exists some cases where USB4 port also shares the=
 same
> > > > _PLD with USB port and Type C connector, so we need to register a
> > > > component for USB4 ports too, linking USB4 port with Type C connect=
or.
> > > > Otherwise, link between USB port and Type C connector would not
> > > > work either.
> > > >
> > > > Due to the nature of the component framework, all registered compon=
ents
> > > > are shared by all component match despite the relevance. MEI subsys=
tems
> > > > also use the component framework to bind to i915 driver, which try =
to
> > > > match components registered by USB ports and USB4 ports. This can b=
e
> > > > problematic since MEI assumes that there is a driver bound to the
> > > > component device, while USB4 port does not bind to any drivers. MEI=
's
> > > > component match callback functions should handle such case to avoid
> NULL
> > > > pointer dereference when USB4 port registers a component.
> > > >
> > > > In summary this patch series
> > > > 1. Fixes MEI subsystem's component match callbacks to handle a
> component
> > > > device without any driver bound
> > > > 2. Registers a component for USB4 ports to link them to Type C
> > > > connectors, similar to USB ports.
> > > >
> > > > Heikki Krogerus (1):
> > > >   thunderbolt: Link USB4 ports to their USB Type-C connectors
> > > >
> > > > Won Chung (1):
> > > >   misc/mei: Add NULL check to component match callback functions
> > >
> > > The Thunderbolt patch looks good to me. Do you want me to take the bo=
th
> > > patches through the Thunderbolt tree or they can go separately? I nee=
d
> > > an ack from the mei maintainer it goes through my tree.
> >
> > Hi Mika,
> >
> > I would prefer the two patches to go to the same tree since it can
> > cause a crash with only the second patch (tbt). Would that sound okay?
>=20
> Sounds good to me.

Tomas is MEI maintainer and should ack MEI patch

--=20
Thanks,
Sasha