Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2114142pxb; Sun, 24 Apr 2022 05:11:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5twEnXLoR9+5bLul4HsN2o8ghlKh0duKpoEt3VkF1P0NQcAuMzaUVorzHrLUpfimuOegh X-Received: by 2002:a17:907:3f02:b0:6f3:5c42:321a with SMTP id hq2-20020a1709073f0200b006f35c42321amr10072495ejc.521.1650802275238; Sun, 24 Apr 2022 05:11:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650802275; cv=none; d=google.com; s=arc-20160816; b=oGngXUnPjZD/cGU04/REFhoAGSzoB8MVXLbV1YF9k9qUpVCeaHHKLLyJeg8qH9nn9A R1rgZhYTMGS1zNUKG2ZA7CS6i8tizGe5YpK1y0tKYblzsFTd2Zt1jlHggfdBVO+vZ1hd u45Pi4q75M6r8mq2zR/8jaJZlvRfB/bg3/qeYrov5HGaGa4OEYNH+ybj+aV6b/ZM3qIc N9JF+UWuAdS8yeW5K8lBxergWbYEfOeW3f90XcGmFvNX1wK9N5PhHrycpHRO0zgdB3ag 6nZ///iVelje26ijlVndiGmJaOAZQDjO/2LKc6vZMr5FWpJWr0//wB10LeyFd0QfJaf9 FnjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zz5/t8cLw/kJ/xFK0BlAGAygaXgaCDRTSzVqiS8Ie34=; b=r2NJPRPAsOpupE0lhVjpqfdozzxCL43WzBUkJa+lTnn+YD0psXe6FX6pgPozFukP3G Ow7vzNu/nmVhwxHVAIErVAMttLE+W45gpC8apGuOgpRPu6pesC64HG95lzKkT7d5TGD5 eyuvXI/rOAfTAwZijpLv/3R1E3tN01udPTGlTHNtSvyhh/Fa2egmjVeGvJA9zFB59zBn qOTrB7WW9uicxyq42TIoJ2pbWCB+aWpsA7vkfUECZzEhRGf+FGWXutidtAFST7M1n6vs 0vd44NNMeeHfrXuUBJtBktOirhkGSPvr3/H9WN7TviLvRnRknu5G2ppS1V3xt+AuTKRD VAkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i262eavU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020a170906580b00b006e8c741b77esi10939880ejq.280.2022.04.24.05.10.50; Sun, 24 Apr 2022 05:11:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i262eavU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238698AbiDXIqS (ORCPT + 99 others); Sun, 24 Apr 2022 04:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238692AbiDXIqQ (ORCPT ); Sun, 24 Apr 2022 04:46:16 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22980FC514; Sun, 24 Apr 2022 01:43:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 7C0AFCE0CF2; Sun, 24 Apr 2022 08:43:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34DFAC385A7; Sun, 24 Apr 2022 08:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650789792; bh=cJ+xJVZRBT4Airyqz2r7vYyhhEgUHQ4ZpnNubU+ZhKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i262eavUePTSgq7ah6U89Ke6Nsk9rpCEP3yDCEFvZPqHomW/S9Ln74aJVefzCOZEW VreqjA0BMCDV5AZNFoMMGnqVxeFRudmsaL9WD9XBmUygD+5gCdRtj2llyCz1SufbED gmSCxFlkI9jI1o2hrNbENlvagi7TJspph8XZNh74= Date: Sun, 24 Apr 2022 10:43:10 +0200 From: Greg Kroah-Hartman To: Muhammad Usama Anjum Cc: "Rafael J. Wysocki" , Len Brown , Hans de Goede , Mark Gross , Collabora Kernel ML , groeck@chromium.org, bleung@chromium.org, dtor@chromium.org, gwendal@chromium.org, vbendeb@chromium.org, andy@infradead.org, Ayman Bagabas , Benjamin Tissoires , =?utf-8?B?Qmxhxb4=?= Hrastnik , Darren Hart , Dmitry Torokhov , Jeremy Soller , Mattias Jacobsson <2pi@mok.nu>, Mauro Carvalho Chehab , Rajat Jain , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , Enric Balletbo i Serra Subject: Re: [PATCH v8] platform: x86: Add ChromeOS ACPI device driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2022 at 10:08:15PM +0500, Muhammad Usama Anjum wrote: > + i = 0; > + list_for_each_entry(aag, &chromeos_acpi.groups, list) { > + chromeos_acpi.dev_groups[i] = &aag->group; > + i++; > + } > + > + ret = sysfs_create_groups(&dev->kobj, chromeos_acpi.dev_groups); You have raced with userspace and lost here :( Use the default groups pointer in the platform driver for this, and use the is_visible() callback to know to show, or not show, the attribute instead of building up dynamic lists of attributes at runtime. That will save you lots of crazy logic and housekeeping _AND_ userspace tools will work properly as well. thanks, greg k-h