Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] HID: wacom: simplify if-if to if-else
Date:   Sun, 24 Apr 2022 16:58:26 +0800
Message-Id: <20220424085826.96447-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+xzUFD5tyWrtJkM/J1RXMV7EpORUrGNZqpZHJ6GP8XUOpRr7ltgkvMZAb2J4?=
 =?us-ascii?Q?gLKRy2TuDxQF3/vnuSNwyBPb8FlcGqBIPXEg8xRjMBLKeI32R5etRAkpfGUp?=
 =?us-ascii?Q?1VqMremcJBIY7f/Lc3ktdEyAh9iEyT4AQQIRyPgg3KPPCQ0oj73W7BZAldof?=
 =?us-ascii?Q?Yf6LNSJizr1ZuWd7w0M0J0DboEffaWUUoODy9AA8Owetlm1RUtrFDBxzluXi?=
 =?us-ascii?Q?q/UgB8Wlvl2HqCPz9cssgwxxoYxOutzgoXtpuEGtGrm7m0o+sgUyNolF+W2N?=
 =?us-ascii?Q?eORO686mxRZWTTlUdarBg14PfzvkbhM9rOTvpZf+k1vwbfgffHMxFb3gMkzC?=
 =?us-ascii?Q?Vt5X7RCqtLltNIGTNwH4jYuDiJe5b3ZPY49vohOHHmvpcmtaSFQHi6dVeRKO?=
 =?us-ascii?Q?Sffz044aXiOGO3GuoE/wSKo+AcVejzxapfeQSI4cdayg8HRyvy4LR1clsr8x?=
 =?us-ascii?Q?tqZ2VWBvpP21pRC0gDaMnwgFYWZGibz9LqwG/tHDb3t/SuJ5CCD0AoPKXp26?=
 =?us-ascii?Q?toBYNB0oLVJuVGD4bryOAAaZamzPlWGtEqj8BhaI6Kx7MaIcEcIDkDSvvC8A?=
 =?us-ascii?Q?JTvzn9Q5lJxZI9Cy562okZSJYceIWv/UG3SrpkycZ9LrRz0m5knqEhbTgzek?=
 =?us-ascii?Q?a13noIOIpux9qdRRrZlw4kKH6jZHajAuiahbYYQqZ4gwR+pj59QfgBBP1ddT?=
 =?us-ascii?Q?gdUKr9RomNgB+O5ixpO055PPS70vEYh9rIsVdZZSTlJ/3HJL1nSDDqo7wYX4?=
 =?us-ascii?Q?3hQYfNQFxHIrjuJMrfuM3zCWF9j9qf4iYptoxyEmqFvRJYvZO3wF3W3aXE8r?=
 =?us-ascii?Q?KRBsjEjgN/Is9T1+VL00JSKLkDkkJkdJoT+v2E+zyCudyHgZ6XFz121aKQmc?=
 =?us-ascii?Q?pA9MXZx8eTShNzKrzAUwa4T9n25USJPi7/7//1Z86xRqkyMy81DjVP6bJ7Sp?=
 =?us-ascii?Q?e1lStDCaRnOTuslRvB66ibLi9lUEpwEK7bNcNQ9FPeQmfNqCvCmH2EK61LIj?=
 =?us-ascii?Q?veb7NhAwq5DJZmQU6rcxDEiiE/HpHtVKzHiPKvuCBS28opgE0xCtHo0wR1Uh?=
 =?us-ascii?Q?BU+YoR2VCLFmoGR1hs4MB0iNPfz25DwS2mawj+aMVMGcgAPMFNxERETAK+wt?=
 =?us-ascii?Q?m1pQyJ0DBcbiVId78V87WGuu0graWIU/1n6iNOxiTIEybxXjSN9rKaJLoIGv?=
 =?us-ascii?Q?cOjpFlLdQSyBwNcK+MWJgI78xJUcBwSiL8IKTOwzGjxA3fvmcux8LCAiLwi2?=
 =?us-ascii?Q?5LPdvPER0K2ffrlAownsjNWkGs8TtUzMjDXErZuRbh8Q6q/c5K3WVxMqPPEh?=
 =?us-ascii?Q?QRhDbc+C2qvWRmVxUqbeE/qIZy//ot+N5TB7XE+MnExLAQLrQr1OAW/MQbRT?=
 =?us-ascii?Q?QhaorlxGTiBGUHiqUeGpDo1q1NLGoz8yX1uQa+h4P/n9F4EaRCtr6tscJKjV?=
 =?us-ascii?Q?jam+sBDsHZkzisG9jG2wGQjvwC9eqQ4IWLsjgdU9LFRrjURwEd2K/r//gWVp?=
 =?us-ascii?Q?uDACh6zxeIo+cvSHG7T6IJohEdakA8AC5QCmRvD+GoIw1MxXSyiKwEf4jfdL?=
 =?us-ascii?Q?zVkSepp4mqTzjssAKZgMqazzTOgOk4SjvLjnmc7RUIVZKQfqoQHoFeU3OThT?=
 =?us-ascii?Q?V6SPzUYb5M6ypFIep7f9LdGiZ4+lKLV/9V9fChApHisntM6Ow5OStpymyWPC?=
 =?us-ascii?Q?jAdprIE6cfjhtNXy8OGx00AgECvlJr8p4aWT85r7wjGL4gw72sgIjavbXBsm?=
 =?us-ascii?Q?HYU9JDRCuA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ed61d27-7434-4f3f-476e-08da25d09ec9
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2022 08:58:37.6887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hOagXtC7sy0if8TG76+iu/JmbR3FNa8LYOrrPFeE7wOYS/9fkpuU7OUkEwfS0sR8O3FBr345ONUD2u5LuPbKYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2468
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use if and else instead of if(A) and if (!A).

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/hid/wacom_wac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 64fe573deb9b..886e87f1c8bb 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -181,10 +181,10 @@ static int wacom_pl_irq(struct wacom_wac *wacom)
 		input_report_key(input, BTN_STYLUS, data[4] & 0x10);
 		/* Only allow the stylus2 button to be reported for the pen tool. */
 		input_report_key(input, BTN_STYLUS2, (wacom->tool[0] == BTN_TOOL_PEN) && (data[4] & 0x20));
+	} else {
+		wacom->id[0] = 0;
 	}
 
-	if (!prox)
-		wacom->id[0] = 0;
 	input_report_key(input, wacom->tool[0], prox);
 	input_report_abs(input, ABS_MISC, wacom->id[0]);
 	return 1;
-- 
2.35.1