Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2277082pxb; Sun, 24 Apr 2022 09:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIYf28IVta3NQQ5hJYnX7Y7H/A4yslpHyR+fTJYig8IJ+Hmg+ksbHxeJSybGDaWDrIGC7K X-Received: by 2002:a17:907:60cf:b0:6f3:9116:201d with SMTP id hv15-20020a17090760cf00b006f39116201dmr2241007ejc.727.1650818468757; Sun, 24 Apr 2022 09:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650818468; cv=none; d=google.com; s=arc-20160816; b=M6egGv/OHZCa7ifVXO0XwzAtps77nQDpJGxp8wBQnR3DYkyoIkFBbzwBVaY/aYfvMA xiv/yYW7v5YCnfhaI3sKfKGYRZyC7oKTHCLJIcgTwinIojhFe3FGcbGbYcffwlCToJZL rJ/wP1El67p4UrDQD9a0fZyRLAr80InYsNmwYEU+nIYpKBxMjsTN++dP2+Tz6zo29Gkr 0vqyZ+onA5FSZwHOu/uEc1ohU12qDaPgt/qrlTpXwaD83+Jt3H3wZLwWRdzYer8NLq5L HRlBPu8Hh9s5eICRrD4El+FvkCF1fxIJzrRr0vLYlJQTEVf0VinwcVPR9flxxd899Q5m 9hfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=BzqWH2IzgALcoDHHVu1SSmrK7vebYFiu676jJ6lQ4us=; b=sGOr5djR8mMjq5IegjSm0JJy+SGkHduJhT+xykBUPVVEHEwgEd14rkodt0YiM1dCMm wtMqCN46xj5y8eFtvoR+1DXmKAEMptPTy/4HsSjNqTqr7X7k5gpw9NyKJshf0jvEsOd3 zumVceQj2TQrIgmr2a+/mzo5lIpntAKFOUGnyI2X1dcn1zCXqK4450bg49senawCBnaw r1FMKG4gZ23ybR5S9pn95t+fckTxiEz7jz/Zl9ZrmcfchptHQ32wnTAfeGt9c5CUSYZE Vo7OJ2Gv1OaP5vfY9buUmLTTOYfndM1G56ImCHE6eAItGNHBw7hhLMmrsKN11VYlML2i u5Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020a170906a09600b006f3978706d4si460272ejy.75.2022.04.24.09.40.44; Sun, 24 Apr 2022 09:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236988AbiDWVlt (ORCPT + 99 others); Sat, 23 Apr 2022 17:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbiDWVls (ORCPT ); Sat, 23 Apr 2022 17:41:48 -0400 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F751D5660; Sat, 23 Apr 2022 14:38:49 -0700 (PDT) Received: by mail-pf1-f176.google.com with SMTP id i24so11287294pfa.7; Sat, 23 Apr 2022 14:38:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BzqWH2IzgALcoDHHVu1SSmrK7vebYFiu676jJ6lQ4us=; b=ITRrI434LwGfXkPKj4SrA3C1JXDUVQeqGeGXN7X1mJjQm0TwxQt5G+FtrQyzssjNw3 4GYs3i9/z5FsnuMaEmREwBJVh17StIzib/hi9MfCHlTOdfQQJjhaJpJw4WzinjMuNFwQ HNStg1ySrrL2DjHp/33yRqJnrRWaxEMjlCQYCylZjSwql1htDGodae3mFqCdu0eufz8N 1he9wyIQI0w5FmlOTQTQWAebq0hUQf3X+9JJMk7QcetbBzRQv7XyPVyfP35XUMfIfya8 9FtnYoxZ52gvm8wB0V2LUVtJ8oKS9oO6ejOm2U9qLelBCbXQCp6NbC3M8HtFq/Bpaawp /zkA== X-Gm-Message-State: AOAM533s//zTreG5mB+XFAylPU8PXQmAFNnpBD3iBex8zAhdC3ShBaYg 9+jELdetdLDkZSHMtBAzatI= X-Received: by 2002:a63:8a41:0:b0:3aa:a7c9:23b8 with SMTP id y62-20020a638a41000000b003aaa7c923b8mr9059061pgd.137.1650749928940; Sat, 23 Apr 2022 14:38:48 -0700 (PDT) Received: from ?IPV6:2601:647:4000:d7:feaa:14ff:fe9d:6dbd? ([2601:647:4000:d7:feaa:14ff:fe9d:6dbd]) by smtp.gmail.com with ESMTPSA id 128-20020a630686000000b003ab01991fe5sm2091610pgg.77.2022.04.23.14.38.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Apr 2022 14:38:48 -0700 (PDT) Message-ID: <0f061fc0-d7ee-aa48-278b-4ca7dc3ce53f@acm.org> Date: Sat, 23 Apr 2022 14:38:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] scsi: ufs: wb: Add Manual Flush sysfs and cleanup toggle functions Content-Language: en-US To: jin young choi , Avri Altman Cc: "j-young.choi@samsung.com" , ALIM AKHTAR , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "beanhuo@micron.com" , Daejun Park , "adrian.hunter@intel.com" , "cang@codeaurora.org" , "asutoshd@codeaurora.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1891546521.01650629881201.JavaMail.epsvc@epcpadp4> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/22 07:24, jin young choi wrote: >>> +static DEVICE_ATTR_RW(wb_flush_on); >> Maybe wb_flush_enable ? >> > 'wb_on' sysfs already existed. So I named it in the same format (_on) > I'll change both. (_on -> _enable) sysfs attributes constitute an ABI. Breaking the user space ABI is not allowed. Hence, renaming existing sysfs attributes is not an option. Thanks, Bart.