Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <8d9e41b5-a143-eace-72ff-c8e9e399daba@roeck-us.net>
Date:   Sun, 24 Apr 2022 09:37:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/4] dt-bindings: hwmon: add Microchip LAN966x bindings
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>, Jean Delvare <jdelvare@suse.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc:     linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>
References: <20220401214032.3738095-1-michael@walle.cc>
 <20220401214032.3738095-4-michael@walle.cc>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220401214032.3738095-4-michael@walle.cc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/1/22 14:40, Michael Walle wrote:
> Add a binding for the temperature sensor and the fan controller on the
> Microchip LAN966x family.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Still needs approval by a devicetree maintainer.

Guenter

> ---
>   .../bindings/hwmon/microchip,lan966x.yaml     | 53 +++++++++++++++++++
>   1 file changed, 53 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> new file mode 100644
> index 000000000000..390dd6755ff5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,lan966x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN966x Hardware Monitor
> +
> +maintainers:
> +  - Michael Walle <michael@walle.cc>
> +
> +description: |
> +  Microchip LAN966x temperature monitor and fan controller
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,lan9668-hwmon
> +
> +  reg:
> +    items:
> +      - description: PVT registers
> +      - description: FAN registers
> +
> +  reg-names:
> +    items:
> +      - const: pvt
> +      - const: fan
> +
> +  clocks:
> +    maxItems: 1
> +
> +  '#thermal-sensor-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    hwmon: hwmon@e2010180 {
> +        compatible = "microchip,lan9668-hwmon";
> +        reg = <0xe2010180 0xc>,
> +              <0xe20042a8 0xc>;
> +        reg-names = "pvt", "fan";
> +        clocks = <&sys_clk>;
> +        #thermal-sensor-cells = <0>;
> +    };