Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2607805pxb; Sun, 24 Apr 2022 20:46:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5NsIyX2fUsC5QLYumwtrJqddX+DMX8nIlnKP7bioYrTuqxfYizGTfnmUSSzgTOBXEJWpP X-Received: by 2002:a17:907:8a0b:b0:6f3:6b70:c644 with SMTP id sc11-20020a1709078a0b00b006f36b70c644mr9916048ejc.530.1650858402752; Sun, 24 Apr 2022 20:46:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650858402; cv=none; d=google.com; s=arc-20160816; b=Pl3VKniSm03RHTXiuIhk7txYxruCCC1FWBIYuvUUqRC3D5kCV/KFGYZ6wYOsD63rAY JLJ1zR4CEwUerAn4e/kzO4fm+o4LhCzjkRCVjMyOMqv0tlDUu6In6Zy312jB/C4LTHCw J86HyllTlLEplJWFPOb53NzXNP++rJNlME3jjQuurm+mEYB6dHyEeWaGatD6oM/2Pkt4 knpXCVPw/W3C0+TNjm9UC3T2lWgiHGcTJ0IUHapiTpwCcFWDvEooL9YwVUO0FHYEFtcN 5VygAuC8+wbi6uJRLZfqHORyDbYvIlHg7Yt+SfF5s+hUUMmNgvxuMEhwoGe7O/wzNcNy NOyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VS2b57r5g1IMcvo9I/EmrQWkubRszne2TH1xNvPhuyM=; b=MMVKnGA7wjen/H7rIc/TOf5p+0RRVv/rkfFC4lCpznnRsIDS8GadAVPEtdtPCdZNyz O5LrQP+2BXP28QOzG3NKf7aww5veLR3YaesyAs1zbPwlyqZ2r4J6C9V67wN4W/6mVSnt TUKgECw26vAW0ZflzoRky1gxJeZJo8sZSClE9+RYhytZpuuvGv59HTiJpruO8/tdYGVI Xl2CyChhSNn0fOFF2Qfp35cHU5+3LQZncm/Js3Gn8MoZBuV5Ru4IOMoKd8QZU6LG9VqN 3Pl8dpK0ExjAirjyKYo00J3KZVvm0Lhj+YCw231YMKc+G+tUZ2dj2S/edtSMLtNlA5lN iHKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=m53oTjo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb44-20020a170907162c00b006f38dd22964si3113257ejc.11.2022.04.24.20.46.19; Sun, 24 Apr 2022 20:46:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=m53oTjo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238051AbiDXTIl (ORCPT + 99 others); Sun, 24 Apr 2022 15:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237677AbiDXTH6 (ORCPT ); Sun, 24 Apr 2022 15:07:58 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9845113976C for ; Sun, 24 Apr 2022 12:04:55 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 83ABB1F44DAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650827094; bh=H46XxB6oFHCaE4uAm7MAxT74nXXK7Q5+TkH98BogMYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m53oTjo4v5Mah0XdA0IRsCw5H20XTxDf/JXLQOfbpKj7iI8xF7RzHj2BvvGRvbzgD Ec14L/kPfb7rusJ/NSVKEvCGICRc9HjiVYVYKVwnSrftKLpbSb1eUXzxcWIN/g3y/K MF1Q8tykMm7H3A6NRSFKqFOCg/np0Qao5vdMZVCPI6i15QrGgKA6Ug6tW5BBTu0Xv+ DnSC2zP+PnEtN/nGXnuUlwosWv9a8vYjhst0KP08vULTNgjlN/uxat1av5tl3KI//A Lk8+DhR0TlHPjom/AloALVNPXCksqeTyNXIQLduah/WcF/j9W2MaxCiAlsSB7pvIGQ OzvZHrwMvw2OQ== From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Steven Price , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy , Qiang Yu , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko , Dmitry Osipenko Subject: [PATCH v5 10/17] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table() Date: Sun, 24 Apr 2022 22:04:17 +0300 Message-Id: <20220424190424.540501-11-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220424190424.540501-1-dmitry.osipenko@collabora.com> References: <20220424190424.540501-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drm_gem_shmem_get_sg_table() never returns NULL on error, but a ERR_PTR. Correct the doc comment which says that it returns NULL on error. Acked-by: Thomas Zimmermann Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 8ad0e02991ca..5c7a7106b41d 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -662,7 +662,8 @@ EXPORT_SYMBOL(drm_gem_shmem_print_info); * drm_gem_shmem_get_pages_sgt() instead. * * Returns: - * A pointer to the scatter/gather table of pinned pages or NULL on failure. + * A pointer to the scatter/gather table of pinned pages or an ERR_PTR()-encoded + * error code on failure. */ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem) { @@ -688,7 +689,8 @@ EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table); * drm_gem_shmem_get_sg_table() should not be directly called by drivers. * * Returns: - * A pointer to the scatter/gather table of pinned pages or errno on failure. + * A pointer to the scatter/gather table of pinned pages or an ERR_PTR()-encoded + * error code on failure. */ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem) { -- 2.35.1