Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 01:18:13 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: uvc: simplify uvc_enpoint_max_bpi
Message-ID: <YmXMpQOb3bb4l6IF@pendragon.ideasonboard.com>
References: <20220401172437.625645-1-ribalda@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220401172437.625645-1-ribalda@chromium.org>
Precedence: bulk

Hi Ricardo,

Thank you for the patch.

I think you meant uvc_endpoint_max_bpi() in the subject line.

On Fri, Apr 01, 2022 at 07:24:36PM +0200, Ricardo Ribalda wrote:
> The case USB_SPEED_WIRELESS and the default one were doing the same.
> 
> Also, make always use of usb_endpoint_maxp_mult, as it should have a
> sane value, even for LOW speed and WIRELESS.

I always fear regressions with this kind of patch, but I have no reason
to think there's a specific issue, so

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/usb/uvc/uvc_video.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index 1b4cc934109e..a2dcfeaaac1b 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1760,21 +1760,14 @@ static unsigned int uvc_endpoint_max_bpi(struct usb_device *dev,
>  					 struct usb_host_endpoint *ep)
>  {
>  	u16 psize;
> -	u16 mult;
>  
>  	switch (dev->speed) {
>  	case USB_SPEED_SUPER:
>  	case USB_SPEED_SUPER_PLUS:
>  		return le16_to_cpu(ep->ss_ep_comp.wBytesPerInterval);
> -	case USB_SPEED_HIGH:
> -		psize = usb_endpoint_maxp(&ep->desc);
> -		mult = usb_endpoint_maxp_mult(&ep->desc);
> -		return psize * mult;
> -	case USB_SPEED_WIRELESS:
> -		psize = usb_endpoint_maxp(&ep->desc);
> -		return psize;
>  	default:
>  		psize = usb_endpoint_maxp(&ep->desc);
> +		psize *= usb_endpoint_maxp_mult(&ep->desc);
>  		return psize;
>  	}
>  }

-- 
Regards,

Laurent Pinchart