Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Apr 2022 11:39:50 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     Wan Jiabing <wanjiabing@vivo.com>
cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] FDDI: defxx: simplify if-if to if-else
In-Reply-To: <20220424092842.101307-1-wanjiabing@vivo.com>
Message-ID: <alpine.DEB.2.21.2204241137440.9383@angie.orcam.me.uk>
References: <20220424092842.101307-1-wanjiabing@vivo.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 24 Apr 2022, Wan Jiabing wrote:

> diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> index b584ffe38ad6..3edb2e96f763 100644
> --- a/drivers/net/fddi/defxx.c
> +++ b/drivers/net/fddi/defxx.c
> @@ -585,10 +585,10 @@ static int dfx_register(struct device *bdev)
>  			bp->mmio = false;
>  			dfx_get_bars(bp, bar_start, bar_len);
>  		}
> -	}
> -	if (!dfx_use_mmio)
> +	} else {
>  		region = request_region(bar_start[0], bar_len[0],
>  					bdev->driver->name);
> +	}

 NAK.  The first conditional optionally sets `bp->mmio = false', which 
changes the value of `dfx_use_mmio' in some configurations:

#if defined(CONFIG_EISA) || defined(CONFIG_PCI)
#define dfx_use_mmio bp->mmio
#else
#define dfx_use_mmio true
#endif

  Maciej