Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2701922pxb;
        Sun, 24 Apr 2022 23:54:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxlaH37eWHi+dNSnXGzQOty4OSMFOpgUy4YUxfL1s8Tjk/us0VOf2gmE86bsCgUYG2I+KRd
X-Received: by 2002:a17:906:7751:b0:6ce:e3c:81a6 with SMTP id o17-20020a170906775100b006ce0e3c81a6mr14424163ejn.278.1650869679328;
        Sun, 24 Apr 2022 23:54:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1650869679; cv=none;
        d=google.com; s=arc-20160816;
        b=Nxk12AQnNID0WBzKIzJcrNBHm1zUMaqGpRodLx1IkqX/0bVoUuvHrqUXlIFO87vM4t
         mm46FC3HbrZFF4KzudXWYSLcsHAysOhWApaUdnXklmG2RletMi4wGJ87ZVA0/+7l+XHj
         hLlj1m9JNtXC2EzRGIz9Fx3QpL/7tCc0Pz72nFPCPHap4yVa4kd3xO9hxBMmVxWgLOKa
         Tp2ezpCBIyJwIe6/Xu91Yxp0kEIF4gtJyRhQGniFnSXTR+9CPh7v8u0xStyZqIx9Ugxu
         d1QtcIJvn5OMRnEz2HAJ5BWb+YsmpTP1dbqApsaByDoM0/GLfF/to3MGZf1RsEPMs9X8
         CnWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=KIFCd/VovS60IbZBkCZu0CoRDe+4Rs582yjMth/3A9g=;
        b=y2sm+HwTWBVQQovnYIdZMLGbVxBB9c/vzVsnuf+FQewi1HK7TTssjMAbzh87z/8TnM
         4x9TZhB2pZeixqUblilOiI7JllB2zhHrIVgrO6Riyjl38Dwcn8oXfC29ENhkt52qCryh
         LrWV5bHiCwjgeeyJEDFvJln/eEl14pqC2kOOCUHOCGbdA5/f0vp92MiV2Y0W3+mDJxTF
         Ri0LLFSc0qiWFhGdaHhQOCTpqZQQtEcEQCtULHbNHb1j4hYJC9xllU+6BWxcOi84lBV0
         fQdTA744Pttr29paydGUV34RS4QCokLjTOOCRtsv6yFohAOAdK1aHWasA8+gZE1sBWYq
         +rmw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5PAkG2X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id w13-20020a170907270d00b006e06d4769f3si2694599ejk.692.2022.04.24.23.54.16;
        Sun, 24 Apr 2022 23:54:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=p5PAkG2X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232555AbiDXPlI (ORCPT <rfc822;algowarbles@gmail.com>
        + 99 others); Sun, 24 Apr 2022 11:41:08 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34158 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232272AbiDXPjF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 24 Apr 2022 11:39:05 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 404121725C2
        for <linux-kernel@vger.kernel.org>; Sun, 24 Apr 2022 08:35:06 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id D5499B80E50
        for <linux-kernel@vger.kernel.org>; Sun, 24 Apr 2022 15:35:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47FB0C385A9;
        Sun, 24 Apr 2022 15:35:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1650814503;
        bh=2zZcNJ/V9he4AYeJWvmnYEtlaFqoMqeDVCmkTBy3qQQ=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=p5PAkG2XTBVt3rZdMrLrcV4xbItPaMAoSvpDrHg7YWZRELGf9WrlIdRTKMqy/RdrK
         wZN9HGTW8fz3AB5YnO62nBVtKLt3ANnOT7dt02b9YeliioNhRD4AixHIPMFr5qG0yI
         qyK3QaunRD86SAKU4OcjDq2fCs3sPr+v+CYcJaBY=
Date:   Sun, 24 Apr 2022 17:35:01 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     wujunwen <wudaemon@163.com>
Cc:     arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] char: misc:use DEFINE_PROC_SHOW_ATTRIBUTE micro to
 simplify misc proc_fops
Message-ID: <YmVuJd/ngwjbK+8T@kroah.com>
References: <20220331151557.3946-1-wudaemon@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331151557.3946-1-wudaemon@163.com>
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 03:15:57PM +0000, wujunwen wrote:
> @@ -266,9 +249,11 @@ static char *misc_devnode(struct device *dev, umode_t *mode)
>  static int __init misc_init(void)
>  {
>  	int err;
> +#ifdef CONFIG_PROC_FS

We do not like putting #ifdefs in .c files.  Please remove these, they
should not be needed.

thanks,

greg k-h