Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e63bfa2c-6edb-f224-1d2a-0c69330492ad@oracle.com>
Date:   Sun, 24 Apr 2022 14:08:36 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access
 under Xen
Content-Language: en-US
To:     Oleksandr <olekstysh@gmail.com>,
        Christoph Hellwig <hch@infradead.org>
Cc:     xen-devel@lists.xenproject.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Juergen Gross <jgross@suse.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com>
 <1650646263-22047-4-git-send-email-olekstysh@gmail.com>
 <YmQsFb36UEH9BUnN@infradead.org>
 <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <6c5042fe-dafc-eb4f-c1fa-03b0faf252de@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDJINEZNY3h4azViemtZTndhWkJEK3czUldGVXR1MzdMMmhIUnltWGtKdlRW?=
 =?utf-8?B?cmovWDBVSXRFbXZUOHNweFFZeFRtemsxMzlaRnFIQ3BsS09lSGJreDRDM0F2?=
 =?utf-8?B?aFEwYjYvZG8yQkRCL1kreEllcVdRR3VuME5GWDZXQjM2VzZ3UUQvY2t4eFh2?=
 =?utf-8?B?ZWUwaEpxQUJzT2E0QStnTTRLb1FlOFFYTHArMkJROG9RbWkxQmdVSTdVRGZU?=
 =?utf-8?B?VnBkL1NlN3p0SFpWNENXSEQyTXFRek40NnJhR1A2OTFPQVlzYTJCTlM5RDZH?=
 =?utf-8?B?Q2YweXMzbmRWZXFIdjNRUnhvck1yeVMyVHVvNUp3L1NlUHl2SzNqTzV3NDJD?=
 =?utf-8?B?MStHeElhT2g3bUx0dXNjeHpVRGRGY0YxQUpadFVxTlNEdEpOSU1pdzZVdG5M?=
 =?utf-8?B?Tzl6aWxiWW9ja1QrVnlOK2xuei9kQmZ1MHFabmZqY29SOUtKRlA0bTJYODI5?=
 =?utf-8?B?ckNDd1hMOCtkaG82eUVsSWJjaHFvQjFsWE55OWZVVFp4V1cvR1JzaEovWm85?=
 =?utf-8?B?S1pJYjFKM0hITE9rVUlhTVVLakpBUnFYdzdrN1VYaEdXNWV0V0N1M3RWUEx2?=
 =?utf-8?B?cXJJb2F3MXltY1hWZnl2dGhWT1VRaTBFT2diZGlqNTNZUWdBKytaeXl2Y0Yw?=
 =?utf-8?B?cHdiRzNia09tMlFSMGNucnZ3Z3VMUUNHaWUwWWNOTVQ5K0F0UzhEcjFKYzBq?=
 =?utf-8?B?RUEyMGhIbDBveFVoOXZFUUZKWXAzNlpsQzZ6WFRjZFNVaFRqdUxSbCtrWGEy?=
 =?utf-8?B?aGJMWTRwZzNsVjQxTTVmYTROdHZFMDF3bkVEbXNsQWxUb21DT2lxaUdLT2pZ?=
 =?utf-8?B?cUhQQk5vVFJ4R3Nwc2RhVzE1eHNrYlpuRmptdXQ5dkV1VXRQczRlbmp4QTNV?=
 =?utf-8?B?R09jTXpUekFiLzFxWjBHaVRSdVlxTlZHYjVHekNqcm5GSXh1T0pBK000Q0la?=
 =?utf-8?B?WU9UV2VQOFQwTUxuZXcza1M5ODcvVmhycUNxT3NYUks4M3FiaFV4M25qaEdo?=
 =?utf-8?B?TDlacEMrdTdIVmFpanIwNWlBZ1liY2tTcjRXbWtTdEl4Q1krdXZGMWtNVmEr?=
 =?utf-8?B?d1B3TUl0cDJSM0xWRU01VWVmOExPOUlTdWlpNEFXTGg0Vm9yRzBJaXhna2x4?=
 =?utf-8?B?OXhQZVorZE9BTTJNa0FPMm9MR1ZCWnQzVkg0NnhaL3p5M1ZHUGg2RmtkaWJn?=
 =?utf-8?B?SEx3SmxtTGxEM2Z2YjFyQkFzbk93Z01YQjJhNiszNjRhTTBWRTg3cnQxeUpk?=
 =?utf-8?B?WVBWUUhhQXRINUloRzNuMHFzc2R2SVNZaHpMaGJzc2J6VTlQTHVPTCt3ZHo2?=
 =?utf-8?B?L3QyUThZK01qUUhHdllqdU1Rcy9nS2RtREZ6RmtrYitHU0JvcTJJK2RUYWd6?=
 =?utf-8?B?UVZ2YkVhd3VlL1F4VVcyNytkanZhUC90eFdYNGhlOUxDWjNqbEdOaHk5ZTkr?=
 =?utf-8?B?eVlXSHBGTUg4amlZeGl2U0ZDQzFtRmZySW1KdGxVQU51Z0lySUkwcTBHMlVw?=
 =?utf-8?B?cDF2eWRCYzUwL2xOV2hMbGp3SW9ZSmhVTHkyRS9zUWRHSHlaTmRqNEh6L0tV?=
 =?utf-8?B?dGVhUnl1dVRmOHVDVjh6RlpqWkhzQnVxVDd5K2lkc3dpYkpHMDNmblJRd3Fn?=
 =?utf-8?B?RFpqMkFJYkd4RmhnVVMrZy9YVjRQV2ZNWEdObXFleHpFdU1NK1BHL2ovU0Qz?=
 =?utf-8?B?MzZ6c1h5RW15N0hwdDQyS0Y2Zm11TE9JOWJ0NzlLaksvL0p3clBscW94L2R2?=
 =?utf-8?B?TVV2d0hnajBHM1Q3NXg0Q0Z6OW9WamV6WnJhcDkvbEI4ckpIRUJuRU9ZVUtz?=
 =?utf-8?B?UjdEMDM4cVBKWCtNU0M5MjYwRGt0YXFCTWJNaTFTVFZJN3BNS1F2emJQcnZ0?=
 =?utf-8?B?RkhBd0Y3bEpQeElaK3hjU2swTXdhbVJNRzVPMlMzQUwvbWdWemZYQXJwS1gr?=
 =?utf-8?B?WVZDT3AyQ3VXeUxSUGo0WVpabGp4T1M0OWhOdUl5QmFiT29RZFI0Q3BEdDNo?=
 =?utf-8?B?THh1QWVoQVNjZCtqLzBlNCtER3Y0SzJtWHJqYmxLQXJqd0VkVVNEdUdzTEEw?=
 =?utf-8?B?UmgvUGxiZGpORmJjdUtudEtpaHl5bnRHazBkSEg4SFM3QWw2NURVb2ZnU0NY?=
 =?utf-8?B?RFVnQVJPRXVmKzhSYnd5ZzhXclRBS0NpczNFcHFXZStIeDhNTUhGYzNEMzJC?=
 =?utf-8?B?dzlJTS81OWMrL3ZjRGRlWC80VXVwVzZNbUlIUVFLL3NBMUQ3MG5PaGg3QnR4?=
 =?utf-8?B?TEIvTHhlYTBhWFMyeElxL1U0Qi96MFYySUlsdW8wOVZCS1BidnIvQ1pkM2VH?=
 =?utf-8?B?NXpsVHB5REszWFNLL0JpL0VzMHZMWFRXd0lFWmZrRXhNQ01kWXB0UXExbFNx?=
 =?utf-8?Q?uYfV9/g2wVuBECJo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eab6a1c3-1b05-45c8-c0c3-08da261d74fa
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2022 18:08:38.6093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dQM0d4rfbeLvo+8nGoHahiT/aNqz792h7o+60Nzer0gY1Zy1hLHf3ubys8axZ++Yr27f0sPWHnOsrVPeMz6+ORZ7aw15bFaaZtXdvXpfjcg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1768
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-23_01:2022-04-22,2022-04-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204240091
X-Proofpoint-GUID: Jnd0UO71IogSBYldUQVPbxjV4hl736C5
X-Proofpoint-ORIG-GUID: Jnd0UO71IogSBYldUQVPbxjV4hl736C5
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/24/22 12:53 PM, Oleksandr wrote:
>
> On 23.04.22 19:40, Christoph Hellwig wrote:
>
>
>
>
>>
>>> +
>>> +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>> +int arch_has_restricted_virtio_memory_access(void)
>>> +{
>>> +    return (xen_has_restricted_virtio_memory_access() ||
>>> +            cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT));
>>> +}
>> So instead of hardcoding Xen here, this seems like a candidate for
>> another cc_platform_has flag.
>
>
> I have a limited knowledge of x86 and Xen on x86.
>
> Would the Xen specific bits fit into Confidential Computing Platform checks? I will let Juergen/Boris comment on this.
>

This is unrelated to confidential so I don't think we can add another CC_ flag.


Would arch/x86/kernel/cpu/hypervisor.c be a better home for this?


-boris