Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2736602pxb; Mon, 25 Apr 2022 00:56:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywlZejGveYjOLyxtvb27y6ItZzQ6mU1mgwdyy0QZOGaN1aproeCcMH6HRmtoCUfggztljY X-Received: by 2002:a50:eb87:0:b0:425:c3e2:17a9 with SMTP id y7-20020a50eb87000000b00425c3e217a9mr14322546edr.109.1650873388176; Mon, 25 Apr 2022 00:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650873388; cv=none; d=google.com; s=arc-20160816; b=dygNL0LlHFPY37bd2G30gmXAx4ImSyFaVeumc934TQfnhLkV71H936YCVFAMQWkOZv a4ElFG+9/BryB086jeh3XP7sxjTZPOUk1TmmNPwTv7pmttExAB066N4InsGoppztP8Bt 9apjuzC2RaXTzbS5S4eSJOz8dC89MV787R5wiL+MSNPONXelotAxII61cyqPZuluo0zq tfkWDGUTTt6Dhvntl34K29pc8V8y1qOm+QtGlasdA6DoKRutcpLYaGLtedhBxqD7oZD7 CWvRgwoxk5Jiiw5OyTK1fxUNV7dDlewQtiOeLMn1+eDrvshFZ1u5KkcpRpnFQuL+wmUM 7VAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gImJskEZbUGQq/yGIUbA5C1222sfBMsWHD6+YF3THPg=; b=k2svRSezAen6sHMHNR2dZSov9Jfmni7hUPZqVRN0j1+vKKGWb3ceEOC6PfijZCdmda SZye6vZNXAA7iOftG+GhJrniZhOGi9K7R8AP8Ir55Z0BCv0b1FZqQjoh9MG3i/O+FDL2 NssCW38bFqXKO6o3vX3rL9C3h2q8igDDz1Shu6k9viFwwET6YMB06kFtHaR8BNwyGRfX cpdsdG1o1hMWb7SCA642r5DhF6Zb3AO6GFvc+E3q5ig3zVv44exK4DkK3PBsk3Q+KODY N5DW2g2desTF50MVpUFR7H6fHblcbzxCkksR+S9nTb0Q4NnVrBlGqgttFkX3cmKyZd2/ 00cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fmJQnQsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a056402438900b0041d650cda3asi14005574edc.577.2022.04.25.00.56.04; Mon, 25 Apr 2022 00:56:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fmJQnQsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240306AbiDYCpC (ORCPT + 99 others); Sun, 24 Apr 2022 22:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240266AbiDYCpA (ORCPT ); Sun, 24 Apr 2022 22:45:00 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D90F63515 for ; Sun, 24 Apr 2022 19:41:57 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id o18so9507730qtk.7 for ; Sun, 24 Apr 2022 19:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gImJskEZbUGQq/yGIUbA5C1222sfBMsWHD6+YF3THPg=; b=fmJQnQsXpPKz5cvRtNW5sdyaLchbq1R/zwtRKKM/0+eh+reY//gd4nzYNYVIauTvAo EY8Bh2mSzv9R//p+s87rqTuvX+awWpeUMMcZjN2mMkUxta/uJYZDh5kI4devsG0jRXTt T+16Z0i2ekWA8v1qiqyzIIOZsu/XSBrTkOGmUBgEuE9L5fs9vYQQEflyeBD4L61q0FhL GU4XmdC7+5RV671ujlZYnQowYylmd5CCgmGVI2lUW7JDu2v0ZmNDhFYZgwaijXL1dDc+ xoQDqq1jC1jWVSJ4VIBZ/lXd5hFuX4Yhk33K9WNoi5y4RFzFafc5VVSyrDqfuGF6Hkpj 1omg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gImJskEZbUGQq/yGIUbA5C1222sfBMsWHD6+YF3THPg=; b=rQQ5XBLRhAKwRun4wsEFnN9z9Q+Jh0Nq2wc7QHLVnV/wHUd1NEhK6nP1sbv2/qYf+6 lTMAr2T9gsvTHMEpMnMK05VLNIL5hGzD3FBXrSleh2yabidH2irTNxDKJRzqslR5gVNI jniZx/9uk/2GHt+oQ92C9IM6YJnh2G8sTvjMSmejoDscVFqxylYVnlfZFbwKK6cLfD8i WehBaSPF57/Q7sfmuNWqq9yV/6M2ro1ML1KemaIhjkKK0FqTN9ZrWnV4XDIGiyvfzFUX 9/HYWyYApoGqgy9TckRXCf5ZFwW9jwdLYOGx+/xXqUneAMLz0jtrt9QMVKiHYpkMy2tW bMJQ== X-Gm-Message-State: AOAM533i2CnhjRGMe7qBvz4IfvMY2XZSBz2489WVeW/DcAM9/PCxxSte IMKuK5rA8blJx8ZXw0ZRsERdlrQ6tek= X-Received: by 2002:a05:622a:19a1:b0:2f3:6a7b:25ff with SMTP id u33-20020a05622a19a100b002f36a7b25ffmr1102318qtc.13.1650854516591; Sun, 24 Apr 2022 19:41:56 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id p3-20020a05620a15e300b0069e5b556f75sm4298227qkm.5.2022.04.24.19.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Apr 2022 19:41:55 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: lv.ruyi@zte.com.cn To: mpe@ellerman.id.au, benh@kernel.crashing.org Cc: paulus@samba.org, maz@kernel.org, jgg@ziepe.ca, tglx@linutronix.de, lv.ruyi@zte.com.cn, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: [PATCH] powerpc/fsl_msi: fix return error value in error handing path Date: Mon, 25 Apr 2022 02:41:49 +0000 Message-Id: <20220425024149.3437751-1-lv.ruyi@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi This function fsl_msi_setup_hwirq() seems to return zero on success and non-zero on failure, but it returns zero in error handing path. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- arch/powerpc/sysdev/fsl_msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index b3475ae9f236..10f974cfa2f3 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -353,7 +353,7 @@ static int fsl_msi_setup_hwirq(struct fsl_msi *msi, struct platform_device *dev, if (!virt_msir) { dev_err(&dev->dev, "%s: Cannot translate IRQ index %d\n", __func__, irq_index); - return 0; + return -EINVAL; } cascade_data = kzalloc(sizeof(struct fsl_msi_cascade_data), GFP_KERNEL); -- 2.25.1