Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2737079pxb; Mon, 25 Apr 2022 00:57:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweSLt7FTleNweiRo8rgiDAJvnfL8fHGJPUaphpAtSXi3c/II3bUGeAmJMgWOp4m8902RgH X-Received: by 2002:a17:906:6a2a:b0:6f3:73c2:65f8 with SMTP id qw42-20020a1709066a2a00b006f373c265f8mr9327771ejc.53.1650873438681; Mon, 25 Apr 2022 00:57:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650873438; cv=none; d=google.com; s=arc-20160816; b=EX+IbqEGNVE2rNE56kMl3/lbaRfj6PGvSJok+5pFG4A2Ygx+7hZoYG3xQcExiNOLcO udSHzXPXft3S8546rhhZgn3XsBAJevHTVDbvrFK9k2oaiiryHYTZ1juXne56uVnK8rf7 PGggYxFgslIFjp+7yqLq0xT1N7j630cg65GUu8949ox/PC6pRpaKxKtZtGnxJxHL90r0 ugXsaJGy1AHBQfJvfputaNyInY+rFqyrD+240T3ZuYktqSfpl/DYgRFryboNG12yNzCi 1FNJ0oq4KO5fvnPx98UrXrXfompmONxW5+SW/sPaLHi7gfnp7gKlGtohlBe4c+WJ/us2 +4pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=hgmWv2J10YMgm1PnZWc/9wRep8El2UqAWfmRn8325s4=; b=oB2M/Gi2GL6tdHgf9rHwoUJ1fbIEeqY217jGh6ESneLIhKSmBTFyNO2p0IrZGJi0Tk LLtNsL0XPhkY1kjNE4aKqWs3KrEDqAxwD2jaliBDFizs94riWoGX920fzG1qI/0GIDwg bUQDImyZhStbZGip3hNhQmFvlknVuUD3czO0dnAgrCjEZ3zaWSEiauKFVFZbMhI+O5Vl 33NKAHz8Hn8QWn2vBDklGiHpgwNrd5zfTnJRLHf64k7OZPUUdA1Vh70+S0AXlwbTZw4H mWECCJYLA3We9VO1azV5gfDvcisdkaUvvY5Oo3xGNTbNx98jwznRT2zO/F6GWUcm7TDd 6+XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=jEt7LQko; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wi22-20020a170906fd5600b006effe0b6fdcsi11613918ejb.613.2022.04.25.00.56.55; Mon, 25 Apr 2022 00:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=jEt7LQko; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233064AbiDXQGB (ORCPT + 99 others); Sun, 24 Apr 2022 12:06:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbiDXQF7 (ORCPT ); Sun, 24 Apr 2022 12:05:59 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9044A74DE8; Sun, 24 Apr 2022 09:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650816179; x=1682352179; h=from:to:cc:subject:date:message-id; bh=hgmWv2J10YMgm1PnZWc/9wRep8El2UqAWfmRn8325s4=; b=jEt7LQkoynYBAPloafnl0suI/aTOA9YzWNOkiVz0lSTgSjKpjLbSswaD 2c2c0LnuOvcjz8gUWaf21W1QudwrIPLnV2BUBKuUNkto3TBGmxXLlBgEQ gYtGE32aDWyRLivpy+WwpZ2VHAwPkBv+AdPystonVEj7jNOZweZ9gnwCp 4=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 24 Apr 2022 09:02:58 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 24 Apr 2022 09:02:56 -0700 X-QCInternal: smtphost Received: from c-sbhanu-linux.qualcomm.com ([10.242.50.201]) by ironmsg02-blr.qualcomm.com with ESMTP; 24 Apr 2022 21:32:34 +0530 Received: by c-sbhanu-linux.qualcomm.com (Postfix, from userid 2344807) id 5C3C45B82; Sun, 24 Apr 2022 21:32:33 +0530 (IST) From: Shaik Sajida Bhanu To: agross@kernel.org, bjorn.andersson@linaro.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, p.zabel@pengutronix.de, chris@printf.net, venkatg@codeaurora.org, gdjakov@mm-sol.com, quic_asutoshd@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com, Shaik Sajida Bhanu Subject: [PATCH V5] mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC Date: Sun, 24 Apr 2022 21:32:33 +0530 Message-Id: <1650816153-23797-1-git-send-email-quic_c_sbhanu@quicinc.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reset GCC_SDCC_BCR register before every fresh initilazation. This will reset whole SDHC-msm controller, clears the previous power control states and avoids, software reset timeout issues as below. [ 5.458061][ T262] mmc1: Reset 0x1 never completed. [ 5.462454][ T262] mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== [ 5.469065][ T262] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00007202 [ 5.475688][ T262] mmc1: sdhci: Blk size: 0x00000000 | Blk cnt: 0x00000000 [ 5.482315][ T262] mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000000 [ 5.488927][ T262] mmc1: sdhci: Present: 0x01f800f0 | Host ctl: 0x00000000 [ 5.495539][ T262] mmc1: sdhci: Power: 0x00000000 | Blk gap: 0x00000000 [ 5.502162][ T262] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000003 [ 5.508768][ T262] mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 [ 5.515381][ T262] mmc1: sdhci: Int enab: 0x00000000 | Sig enab: 0x00000000 [ 5.521996][ T262] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 [ 5.528607][ T262] mmc1: sdhci: Caps: 0x362dc8b2 | Caps_1: 0x0000808f [ 5.535227][ T262] mmc1: sdhci: Cmd: 0x00000000 | Max curr: 0x00000000 [ 5.541841][ T262] mmc1: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0x00000000 [ 5.548454][ T262] mmc1: sdhci: Resp[2]: 0x00000000 | Resp[3]: 0x00000000 [ 5.555079][ T262] mmc1: sdhci: Host ctl2: 0x00000000 [ 5.559651][ T262] mmc1: sdhci_msm: ----------- VENDOR REGISTER DUMP----------- [ 5.566621][ T262] mmc1: sdhci_msm: DLL sts: 0x00000000 | DLL cfg: 0x6000642c | DLL cfg2: 0x0020a000 [ 5.575465][ T262] mmc1: sdhci_msm: DLL cfg3: 0x00000000 | DLL usr ctl: 0x00010800 | DDR cfg: 0x80040873 [ 5.584658][ T262] mmc1: sdhci_msm: Vndr func: 0x00018a9c | Vndr func2 : 0xf88218a8 Vndr func3: 0x02626040 Fixes: 0eb0d9f4de34 ("mmc: sdhci-msm: Initial support for Qualcomm chipsets") Signed-off-by: Shaik Sajida Bhanu --- Changes since V4: - Called reset_control_put() in error path. Changes since V3: - Used reset controller local variable as suggested by Bjorn Andersson. - Passed NULL as a parameter to devm_reset_control_get_optional_exclusive() as suggested by Bjorn Andersson. - Replaced devm_reset_control_get_optional_exclusive() with reset_control_get_optional_exclusive() and called reset_control_put() before returning to clear the reset controller as suggested by Bjorn Andersson. Changes since V2: - Dropped new line after fixes tag as suggested by Bjorn Andersson. - Passed device structure instead of passing platform_device structure as a argument for sdhci_msm_gcc_reset() as suggested by Bjorn Andersson. - Replaced dev_err() with dev_err_probe() as suggested by Bjorn Andersson. Changes since V1: - Added fixes tag as suggested by Ulf Hansson. - Replaced devm_reset_control_get() with devm_reset_control_get_optional_exclusive() as suggested by Ulf Hansson. --- drivers/mmc/host/sdhci-msm.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 50c71e0..ff9f5b6 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -17,6 +17,7 @@ #include #include #include +#include #include "sdhci-pltfm.h" #include "cqhci.h" @@ -2482,6 +2483,43 @@ static inline void sdhci_msm_get_of_property(struct platform_device *pdev, of_property_read_u32(node, "qcom,dll-config", &msm_host->dll_config); } +static int sdhci_msm_gcc_reset(struct device *dev, struct sdhci_host *host) +{ + struct reset_control *reset; + int ret = 0; + + reset = reset_control_get_optional_exclusive(dev, NULL); + if (IS_ERR(reset)) + return dev_err_probe(dev, PTR_ERR(reset), + "unable to acquire core_reset\n"); + + if (!reset) + return ret; + + ret = reset_control_assert(reset); + if (ret) { + reset_control_put(reset); + return dev_err_probe(dev, ret, "core_reset assert failed\n"); + } + + /* + * The hardware requirement for delay between assert/deassert + * is at least 3-4 sleep clock (32.7KHz) cycles, which comes to + * ~125us (4/32768). To be on the safe side add 200us delay. + */ + usleep_range(200, 210); + + ret = reset_control_deassert(reset); + if (ret) { + reset_control_put(reset); + return dev_err_probe(dev, ret, "core_reset deassert failed\n"); + } + + usleep_range(200, 210); + reset_control_put(reset); + + return ret; +} static int sdhci_msm_probe(struct platform_device *pdev) { @@ -2529,6 +2567,10 @@ static int sdhci_msm_probe(struct platform_device *pdev) msm_host->saved_tuning_phase = INVALID_TUNING_PHASE; + ret = sdhci_msm_gcc_reset(&pdev->dev, host); + if (ret) + goto pltfm_free; + /* Setup SDCC bus voter clock. */ msm_host->bus_clk = devm_clk_get(&pdev->dev, "bus"); if (!IS_ERR(msm_host->bus_clk)) { -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation