Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, joe@perches.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH v2] ring-buffer: simplify if-if to if-else
Date:   Mon, 25 Apr 2022 11:01:41 +0800
Message-Id: <20220425030142.142972-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zy6EXTzNryqPisiNTx3mJfa2yAsXz1LmpZMtdQprmlU0Gvitg69aae0ZLWSR?=
 =?us-ascii?Q?AEmoO7LEZ4r6Qjk9DnUMXUOVs/qnqZt7sgDgz2NsCHulhB8mOjGpJWvVv2Vd?=
 =?us-ascii?Q?B2+Ut399kVr7mN2LKT+eO4NtCblVVhKZnKN+4lxWNxy1AXyj1Dn6JzOQaqEE?=
 =?us-ascii?Q?11gf+KPKe4pQJTkbcqXc+yKzmu3pt56TlL8JOCBttPY81f6PolMU7diZqFOC?=
 =?us-ascii?Q?ZDF/jMacUY2AO1LzaYQVkepyAbX+Qm/xWpzEpoRVmOcR2MW/SmpaBV0vk83q?=
 =?us-ascii?Q?IXO65kD09CqGKI+LH8apitzqDqg4vInvVhum3tmf9vdG6ro7s5GwzbBXZ74/?=
 =?us-ascii?Q?m+BLxvLtk/WAyJDSeNcJrRrcdfURw4miCrCf9DOq347srXG78T/XhOdnbKta?=
 =?us-ascii?Q?a3QgcpM+pdOkwKYtUjN0wk3tgafuniuZaKgcNEdZQ/oSmN2DeLbkI2KwHwDg?=
 =?us-ascii?Q?Rw1w+XfgZVitx7hsvgNMTYoATRG4NPWeR+5+OEjOnQj5KwR+vOa8N0ryYZTf?=
 =?us-ascii?Q?pDztRxT9Vdnf2gas4QgrqUDCTOO3Iq/2naN3/z8CuJwc94jIlWAuFPRuQDa4?=
 =?us-ascii?Q?Vw4T+YTcG5q1ffYfO2PvoiWbWX6RpG3sINbX4k16KVtinzMYzz9DMGpwZk0D?=
 =?us-ascii?Q?f4IaCkRjOT/OYLAgKOpUkW2WDML3BxGxpwz+jsBO/FyD9UYj0AybFVnrAFpG?=
 =?us-ascii?Q?4aZkUdtOxon3dVDDdnO5WhKLBOWx+eebl+K7SjjMd9oLV8021OrJD4Hh64wv?=
 =?us-ascii?Q?yoJT0XUmOJ7zRcVC4iaoAJq0rmGcYBJSjz+qWR62g5X88SuCgsB99q79CW+t?=
 =?us-ascii?Q?TKnHzI0SI+a0C/c90twdlSGL2RUg5Rv7K5jfq32tb9d2+12NHNlF3qLPnkf7?=
 =?us-ascii?Q?gDaR+lnVwIy3WSiNPdCJlucWmhHcSmYiUiUBuo1jir+MmAuKy95ZNwG7e1Pj?=
 =?us-ascii?Q?3YrBy9u2eyXuYQwocPTgZqIaZ7m7Bjkp+akDTeUNHX4YPr8vl6ixIwkxctO2?=
 =?us-ascii?Q?3vfBfjrPeU+hYnpscXzJzuvaPF/DubxGs9+URj46dlTt/cPSRWylrm2U8Y/n?=
 =?us-ascii?Q?EYlPu4MwFpIubtRLiod5tyX9n6xmPq9jE4j3IX405t+9Sbb+zyySkbJXnUz/?=
 =?us-ascii?Q?1WB627npBhrRakHidQZu/JEyYRVvlNL33wibG/xO1g6RwpybiU8t6cGnAhNN?=
 =?us-ascii?Q?k/H4K30OunLmmAM3HkY9lD0Qgf9VAwFoFrimVORYJxEa3gkPLR5NuSSIoS8j?=
 =?us-ascii?Q?vMpYxpSJ1Bjs4FQ5xty4ZMwlzidBaOVysIFCqp4Uc/eMltJ9WR8R/GgU+TZ9?=
 =?us-ascii?Q?i7pKeWDLmqrBj5N1IOqxdt52hBKO3txzqUvGuY5qa1Xd3nKfSG2luy9sJDF8?=
 =?us-ascii?Q?m50bdwnDDgAazsx4QBPZKhBp4EfRrA2LDriXSzLr5LHdVBidd5KWX0+mxTyu?=
 =?us-ascii?Q?MSBWfOrN0btBsrN65eGBZfSHg0gSS2I8uS+AMj4yeTbvvSEW38z3op+9BBEc?=
 =?us-ascii?Q?pqOI0AdKkc0ufAL4TyG6lhpVDeuYrovAlSsVjmOX4JktnqJp2TdH4bjR3bWp?=
 =?us-ascii?Q?mawl2GSUmgZpOObNWwsOAou9ZLA7MxElaQi6IzCoPoWYYsMuQcgCo53cB2wI?=
 =?us-ascii?Q?92qEj2mLJBsWpXQzvZUKU6zcyHy3HewL5z04uFDNiot4Do76HL5yZLRBT2r5?=
 =?us-ascii?Q?a0+ixolXJQAlsQdYiGDr4Nm4wLcP6r0uHbMR3RGT2GVCAM3bGqsgA2OiNaiw?=
 =?us-ascii?Q?m94Z04Lvzg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d7618dc-46c1-4836-26cf-08da266804de
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3374.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 03:02:22.9749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUsNgWbqyKoMA1eDrPEt7OxzrRZFZTHt8PZla+/m0T33vcvCzy9K9zkMbEW1Vfr5xAT4fPQpedp0jv5IdSGaGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3940
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use if and else instead of if(A) and if (!A).

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Change log:
v2:
- add braces to the if block and make pr_info nicer.
---
 kernel/trace/ring_buffer.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 05dfc7a12d3d..2860db50413f 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -6011,10 +6011,9 @@ static __init int test_ringbuffer(void)
 		pr_info("        total events:   %ld\n", total_lost + total_read);
 		pr_info("  recorded len bytes:   %ld\n", total_len);
 		pr_info(" recorded size bytes:   %ld\n", total_size);
-		if (total_lost)
-			pr_info(" With dropped events, record len and size may not match\n"
-				" alloced and written from above\n");
-		if (!total_lost) {
+		if (total_lost) {
+			pr_info(" With dropped events, record len and size may not match alloced and written from above\n");
+		} else {
 			if (RB_WARN_ON(buffer, total_len != total_alloc ||
 				       total_size != total_written))
 				break;
-- 
2.35.1