Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2750264pxb; Mon, 25 Apr 2022 01:19:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTZoyk33Cw/JXMCKY7wBiGvUGAI7rxpF175/JeQOCVmWruEMMC56C/wp6JZ+ojlNICoyks X-Received: by 2002:a17:907:6d96:b0:6f3:8445:5f13 with SMTP id sb22-20020a1709076d9600b006f384455f13mr7030349ejc.529.1650874768502; Mon, 25 Apr 2022 01:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650874768; cv=none; d=google.com; s=arc-20160816; b=nI9lHSgKyGKKXa0jF8qeHlfVAGxvpnEpK8uEYuSHUI+7C6a/ply3Wn2/b2VDD+yY2m BnUSoMvJcwO4Pr+FsOa9xfZW5JuJ87Mgxot9ScTLIASXn3lgLVP8t6VXOXgYZBRZC63b 3OKPy0M0BB/qofHYxdgtxJ//arIUF86YZmzmAe7iO3P92tROQSb1/VmTSVtxx1Du8Rb/ 9ul8W/ZgffhMEJqdnBeKSdWDJ8VgGQrNwKCf5LLX22RqS4TnNaaOfIWUbydfW8KJRd6M mMi7+oSY4YnxH+We6STk6muDmb7o7/+xfYSQObD0OhuOdM3YcHIJ1ablzXs5dn7eJZ9x gaCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hhhQDPt+3onB8fGuNsPxKnWw81s4Lk61v9Zm3h8T3Jg=; b=f7B7HJyYIC0j/cirQ7NNEpplnl38/vrbi1IsFft6nOmGGaO7YufkKU628L499N7Yi8 lqskG6dzzNF9Qpu9VQgqGmDmZ5E3ZBXbNd3c+rCw3voxDosCbwg0watjDKeVCZVWw0E1 hWy9lgTECJZguEXgBQ2e5DLLLMqhNUWXIBW2OiprfuAPBS3o+pT2p1+LPcTmwYPVUP90 BpKIux1GVL0fWjaYOwpZuq2/UHSrwDk+Mauyed0TeJLlzGGfcIjmagfiWUCoQveBweXH NM1jPSE8RVeVqmzb+rtuxGGEdlTStj8JWDn91BW7BFpD7NtODr7Gw4NLPvpFEAuJsFfE 2i7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dohdYThY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020aa7c785000000b00418c2b5bea5si8619685eds.391.2022.04.25.01.19.04; Mon, 25 Apr 2022 01:19:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dohdYThY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235731AbiDXGur (ORCPT + 99 others); Sun, 24 Apr 2022 02:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238421AbiDXGup (ORCPT ); Sun, 24 Apr 2022 02:50:45 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 960805F8FE; Sat, 23 Apr 2022 23:47:46 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id hh4so8384479qtb.10; Sat, 23 Apr 2022 23:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hhhQDPt+3onB8fGuNsPxKnWw81s4Lk61v9Zm3h8T3Jg=; b=dohdYThYTN60ilx11KueqqbWHOLBxkSudoW+sh5fgVpKPLn5tSrGLfuNRGpXrfuB8D Ao5l7VDsBLm8xpquSXAFXtRr4CAWL/EaZ3QVICNDMT7IiBdQbG5FUDu4FeoTWP/5dJpd GA/PfYkkqbCPPzakixPUzckAHMC8jqdJ8HhhxtFCyT6E/SCUXNIM6Sahaue1bR7ZivMh rjb3I6Hmggr16jvtRncM7aYEEbli/uGJF4+f0bTPH5VvoowOV4uoVrhhyYdjO0IuLGJr 7OJmymDRym9jFusB/ffwjcEwFm10nu2dGcdWkmt9d9SofJ8GY8MyBH0/MEt4tk9+wlPr YN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hhhQDPt+3onB8fGuNsPxKnWw81s4Lk61v9Zm3h8T3Jg=; b=xKP4N9tydegwfvSsJnfU+8nEXOJLHo+SDKgvlWvT7FVy8U+6Tvmq409oWgtF05VT8v 190mSpcT6/0I14eS8ZmVZFrMf+JnrgBrY4gqgEoqNjmopuDrC+LYDActxwAuQPiON/Yn E/psu6g2t57/sxBBM9HnztIitjj+PkQIsCxUYb6jNEMeblugrTbjEyoOanR2LMFVrAJX pd2B6JNcb9Ndw929o+HWzw+6LS2fk6XvbHkGhnLFrgbngssmRlpThX5bQ/YKz+vdzdx8 3o+VJ1xwYwwjf53u2lNMvwaImAfi9mphcAUbz/UijOqPVZ/WUgeclDJAtl+4/+Zkb40J gHhw== X-Gm-Message-State: AOAM531EazvSA9v2FzkU0GSJQ1aBBifUJ6vLK4Mkv/G95lBwzzr7FqzK DBBFlEsXl4KTqVBw2UJ2gXs= X-Received: by 2002:a05:622a:14c6:b0:2e2:3f:f938 with SMTP id u6-20020a05622a14c600b002e2003ff938mr8446073qtx.358.1650782865856; Sat, 23 Apr 2022 23:47:45 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id a4-20020ac85b84000000b002f340e3c703sm3966124qta.41.2022.04.23.23.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 23:47:45 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ran.jianping@zte.com.cn To: colyli@suse.de Cc: kent.overstreet@gmail.com, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, ran jianping , Zeal Robot Subject: [PATCH] bcache: remove unneeded flush_workqueue Date: Sun, 24 Apr 2022 06:47:39 +0000 Message-Id: <20220424064739.3226800-1-ran.jianping@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ran jianping All work currently pending will be done first by calling destroy_workqueue, so there is no need to flush it explicitly. Reported-by: Zeal Robot Signed-off-by: ran jianping --- drivers/md/bcache/writeback.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index 9ee0005874cd..9d0b4140ad8f 100644 --- a/drivers/md/bcache/writeback.c +++ b/drivers/md/bcache/writeback.c @@ -793,10 +793,8 @@ static int bch_writeback_thread(void *arg) } } - if (dc->writeback_write_wq) { - flush_workqueue(dc->writeback_write_wq); + if (dc->writeback_write_wq) destroy_workqueue(dc->writeback_write_wq); - } cached_dev_put(dc); wait_for_kthread_stop(); -- 2.25.1