Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Apr 2022 15:17:45 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Palmer Dabbelt <palmerdabbelt@google.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] checksyscalls: ignore -Wunused-macros
Message-ID: <YmXMiTXEvFXZ/swU@dev-arch.thelio-3990X>
References: <20220422151725.1336997-1-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220422151725.1336997-1-mailhol.vincent@wanadoo.fr>
Precedence: bulk

Hi Vincent,

On Sat, Apr 23, 2022 at 12:17:25AM +0900, Vincent Mailhol wrote:
> The macros defined in this file are for testing only and are purposely
> not used. When compiled with W=2, both gcc and clang yield some
> -Wunused-macros warnings. Ignore them.
> 
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

The change itself looks fine but a couple of comments:

1. Nick and I do not pick up patches, we rely on others to do so.
   Additionally, this is not really something within our domain, despite
   what get_maintainer.pl might say. This change should be sent to
   either

   Masahiro Yamada <masahiroy@kernel.org>
   linux-kbuild@vger.kernel.org

   or

   Andrew Morton <akpm@linux-foundation.org>

   so that it can be applied by one of them.

2. I am not sure that silencing warnings from W=2 is that useful, as
   they are unlikely to be real issues. Not to discourage you by any
   means but it might be more useful to focus on cleaning up warnings
   from W=1 and getting those promoted to regular build warnings.

Cheers,
Nathan

> ---
>  scripts/checksyscalls.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index 9dbab13329fa..cde15f22ec98 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -255,6 +255,7 @@ cat << EOF
>  /* 64-bit ports never needed these, and new 32-bit ports can use statx */
>  #define __IGNORE_fstat64
>  #define __IGNORE_fstatat64
> +
>  EOF
>  }
>  
> @@ -268,4 +269,4 @@ syscall_list() {
>  }
>  
>  (ignore_list && syscall_list $(dirname $0)/../arch/x86/entry/syscalls/syscall_32.tbl) | \
> -$* -Wno-error -E -x c - > /dev/null
> +$* -Wno-error -Wno-unused-macros -E -x c - > /dev/null
> -- 
> 2.35.1
>