Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2789775pxb; Mon, 25 Apr 2022 02:28:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSYDf751AmXRLcub15BZYa/XJkXIibnAmzIUtip8uwThlfV7OH52JJqOQSUnPVsG/ICMY6 X-Received: by 2002:a63:2a0d:0:b0:3ab:392c:f45c with SMTP id q13-20020a632a0d000000b003ab392cf45cmr3879743pgq.575.1650878928955; Mon, 25 Apr 2022 02:28:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650878928; cv=none; d=google.com; s=arc-20160816; b=x2pczx22mb/5E/UwXAG1GqzVzOdZaKKbAAAWq/Yl1dsjUb4yWztU309hTfBkd4QTjX yTDCNA5IEDuWB8J/2IB8PJ7VjjFThZvIRVsoTHAVuxAzLqvrNwNBRVO7eO7sxyAavFAI d+MRWQ3902ut+sqwQBZutlz78Uj1fFrUAjixurwxZvDtB+vTo9hwvHmOwKADPVJ7tlvq /byHZontXctQVZFylJrYfuyCQ4LeqkjMM85iXqVQLjFvi/I/vjmA3CYxcTR64/u5+WQz LdvNNkbgawGmhAYYZMDAOppR15fF1fwlZjUkaf30dvMgCL6LnDol+Sz1qdW2mqEg33+a Ge0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=L9NLtbmHfsRDaArBldTalYPtlLAhaGbJy0XtjJ42Pc8=; b=bqYwmYmv/jAoJ0qatLebqsbHrbNSlQ8Vo6Uew73Cbvky5n8dr3Sf1HppgjgAzB82bm pFiAbPAbsIOioKv4iWlNCW/jF7XF+ZwqRdnXsqHuz1vJavZqXhKL2di+YiRqZnqyHGMK IFZqTOUcTfYwbaAr/Fs2+DymRcpbRxs2m+WJWYy3wuv6gGqVZjAV3koZZnZeUO0CrRDF KSWbFKCVPEvf8ulwBjL+/GwJaC/vhiML20GjAQEcr1NB+6lxnQo8neO82jr/xAs48fpT H+X5gVtF3MOq4gzHe1zd/wg1DHwfWkKBJLMYPsdev/+vGsLdHkbNG5g4PJnwfEesFP9K /YOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gotl9zyr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a170902eb0100b00153b974f3aesi4437644plb.427.2022.04.25.02.28.33; Mon, 25 Apr 2022 02:28:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gotl9zyr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239284AbiDXO2X (ORCPT + 99 others); Sun, 24 Apr 2022 10:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233285AbiDXO2U (ORCPT ); Sun, 24 Apr 2022 10:28:20 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69176F13 for ; Sun, 24 Apr 2022 07:25:19 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id g28so3423538ybj.10 for ; Sun, 24 Apr 2022 07:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L9NLtbmHfsRDaArBldTalYPtlLAhaGbJy0XtjJ42Pc8=; b=gotl9zyrPMEpBBB75zHAVtoNcGvrwlv8gZBaUOGgGTTlDKLs9vWnUNX+QVELUI/gFn FXNyCW8IQshWwaBZiewM0wu1pkPOXpMlHr8ZJep6Q7dxv9r0IH/TryiMOt/Gp0oZHX72 HNekPe2jA9hCmFWhnttnDCVGEsVmS3PWQ6Ziz2557b2KnMeZB96WZWBWjN/loEVJCytF 0u0GkYtyo8ftZNiRulrDGM4Fd1c38QKfHBrr7w5Ow0O2WMhNIJHM4r0Zlj+2upZtzSct k4z7OFLdFuFgfuYDZgcbkeOPUi6xiqIuicq/dpDawKpBtECGOhIx6DIFpVwNO118usvh Gg1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L9NLtbmHfsRDaArBldTalYPtlLAhaGbJy0XtjJ42Pc8=; b=mxf9Z0K99ma23aUA4q6Ui3tSfzD6i44kP6/hYHvmf79REnDNlWh6Q26bRWFrkChimj R1za39w5wH/ZSRNnmegnMRKfAEVeEWZBkdTKFHL7iBspw1c58f8hg/dRZGdJKMGwlmM9 ewHnERJlH3QHlRIyjsgg3BDQ+GAiiZSpeJy7cDLZZjfTmsvpOI3Tzer2U/NEpgz9Umtm tdkC2h4aM6sQPAR3L27ZQ6tMGVxD8GawYVm3gYKNAMrcVjVBH0AiTGpqVPhh2CqwID5i DWXFmACRqrweT0X33oUlgtt+PGZEBhJfOT0VdMHJXiw51clHQK8Ijf9SHPFbaqF9Lsgn nwzw== X-Gm-Message-State: AOAM530NLBGfdxErTdaW+fh8D7F68tbsARsL8v2CWXolvuNHwCu+vMTk Wgw3g9nNc3oiWiT3sGxQLiIGTP1ttR6uIjkuHIBEqw== X-Received: by 2002:a5b:dc5:0:b0:624:f16d:7069 with SMTP id t5-20020a5b0dc5000000b00624f16d7069mr12374379ybr.295.1650810318717; Sun, 24 Apr 2022 07:25:18 -0700 (PDT) MIME-Version: 1.0 References: <20220422085240.2776527-1-lv.ruyi@zte.com.cn> <20220424031430.3170759-1-lv.ruyi@zte.com.cn> In-Reply-To: <20220424031430.3170759-1-lv.ruyi@zte.com.cn> From: Linus Walleij Date: Sun, 24 Apr 2022 16:25:07 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: fix error check return value of irq_of_parse_and_map() To: cgel.zte@gmail.com Cc: Damien.Horsley@imgtec.com, abrestic@chromium.org, ezequiel.garcia@imgtec.com, govindraj.raja@imgtec.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lv.ruyi@zte.com.cn, Zeal Robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 5:14 AM wrote: > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: cefc03e5995e ("pinctrl: Add Pistachio SoC pin control driver") > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > --- > v2: don't print irq, and return -EINVAL rather than 0 Patch applied for fixes (changed the subject a bit). Thanks! Linus Walleij