Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp2799635pxb; Mon, 25 Apr 2022 02:46:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm7L1LIeBzMFAX4L4ys9ll6uU48hPvJvYYgQCfKC2hIHWSprsP8NlGQFrwF+JeflXvfcKD X-Received: by 2002:a17:907:6da4:b0:6f3:83c3:9c9f with SMTP id sb36-20020a1709076da400b006f383c39c9fmr7363829ejc.205.1650879985079; Mon, 25 Apr 2022 02:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650879985; cv=none; d=google.com; s=arc-20160816; b=uQALR6wlmfakj72sbHWeQtoTa30yaRR7JbEsx+07aYsJvv8rg2nt7YQmql4m9Dekr1 fnloHEiB/IOOgQBBAW/idzZQscmFgM5vOnGx1HEJPVOrNBv911dxLbdJ9vqUxlQWHp2+ 7jwQWx5CBfvtUgW/ynMfCw/1hix9AT57uviT7wiH0uQNJlLWP0UXG44Cuy9YB78hxWFv JGDO2YTHHWHOy7xCBeJWIHdTTNu2nY5pqmFkH+0pZj4xQ1kI5rJrxWwjLHMNn13rTkwE 6MAuNFG+Nq6zJqX6JKyiZOouWTtERZT3A8uVewNAn+EGheK+75A78WFfXPBDQtmchytg xltA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=MxNcL6z3nM7XvfaSFQAGigSRoVMLG+HHoMTKivNUyMA=; b=RtSy4TRQB/J8K8skJNUp1HXi7fLUo8HP+x0ZQkeDBkeBoHDd2DZVhjI30pjx6brPdX nyOFuCfItjYJHApM3/eUaL0uYktCET6m6m/GwATGW1h0GuAFcYEX+TLhTL8OJYpzf62u jIxREBYKReHppQYh/3BYS+dooK4CtrhlEFsZTWCCsvBWr1ZXaisZ/amV8xvHggSoeuTb iiVG5LiH+ssDY+KfJzKqI4YA0wL0eSh3XlKy5n6ZKvt0USPvoWkV4kXv1/CgBQOI6pR/ c98ckLDXvBKvInDprR6UX6kLZETp4LJvZQZ98+L6KYdoVsfBvPyjrJRf47fmt5gVfZ2L neLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n21-20020a170906701500b006e877f0ba78si12552437ejj.705.2022.04.25.02.45.59; Mon, 25 Apr 2022 02:46:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbiDYJCI (ORCPT + 99 others); Mon, 25 Apr 2022 05:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232056AbiDYJCE (ORCPT ); Mon, 25 Apr 2022 05:02:04 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF0513E20; Mon, 25 Apr 2022 01:59:01 -0700 (PDT) Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KmzQB4MQmz6801v; Mon, 25 Apr 2022 16:56:18 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Mon, 25 Apr 2022 10:58:58 +0200 Received: from [10.47.92.213] (10.47.92.213) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 09:58:57 +0100 Message-ID: Date: Mon, 25 Apr 2022 09:58:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template To: Christoph Hellwig , Krzysztof Kozlowski CC: "Ewan D. Milne" , "James E.J. Bottomley" , "Martin K. Petersen" , "Alim Akhtar" , Avri Altman , "Doug Gilbert" , , , References: <20220408103027.311624-1-krzysztof.kozlowski@linaro.org> <2a88a992-641a-b3ff-fe39-7a61fff87cb6@huawei.com> <4c3be5b6-50ef-9e9a-6cee-9642df943342@linaro.org> <7b3885e3-dbae-ff0b-21dc-c28d635d950b@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.92.213] X-ClientProxiedBy: lhreml702-chm.china.huawei.com (10.201.108.51) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/04/2022 08:03, Christoph Hellwig wrote: >> The standard flow is: >> >> shost = scsi_host_alloc(sht, ) >> >> // modify shost, like >> shost->cmd_per_lun = 5; >> >> scsi_add_host(shost) >> >> Is there some reason for which those two drivers can't follow that? > I think they should. Method tables should not be mutable data. > . Hi Krzysztof, Do you have any interest in going further with your work and trying to change all SCSI driver instances of scsi_host_template to be const? I am not sure if it has been attempted before... Thanks, John