Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Donghai Qiao <dqiao@redhat.com>, akpm@linux-foundation.org,
        sfr@canb.auug.org.au, arnd@arndb.de, peterz@infradead.org,
        heying24@huawei.com, andriy.shevchenko@linux.intel.com,
        axboe@kernel.dk, rdunlap@infradead.org, gor@linux.ibm.com
Cc:     donghai.w.qiao@gmail.com, linux-kernel@vger.kernel.org,
        Donghai Qiao <dqiao@redhat.com>
Subject: Re: [PATCH v2 01/11] smp: consolidate the structure definitions to
 smp.h
In-Reply-To: <20220422200040.93813-2-dqiao@redhat.com>
References: <20220422200040.93813-1-dqiao@redhat.com>
 <20220422200040.93813-2-dqiao@redhat.com>
Date:   Mon, 25 Apr 2022 11:52:00 +0200
Message-ID: <87a6c932yn.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Fri, Apr 22 2022 at 16:00, Donghai Qiao wrote:
> Move the structure definitions from kernel/smp.c to
> include/linux/smp.h

...

> +static char *seq_type[] = {
> +	[CFD_SEQ_QUEUE]		= "queue",
> +	[CFD_SEQ_IPI]		= "ipi",
> +	[CFD_SEQ_NOIPI]		= "noipi",
> +	[CFD_SEQ_PING]		= "ping",
> +	[CFD_SEQ_PINGED]	= "pinged",
> +	[CFD_SEQ_HANDLE]	= "handle",
> +	[CFD_SEQ_DEQUEUE]	= "dequeue (src CPU 0 == empty)",
> +	[CFD_SEQ_IDLE]		= "idle",
> +	[CFD_SEQ_GOTIPI]	= "gotipi",
> +	[CFD_SEQ_HDLEND]	= "hdlend (src CPU 0 == early)",
> +};

How does this qualify as a structure definition?

Thanks,

        tglx