Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 17:14:19 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        dri-devel@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
        David Airlie <airlied@linux.ie>, qwen@analogixsemi.com,
        Neil Armstrong <narmstrong@baylibre.com>,
        linux-kernel@vger.kernel.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        bliang@analogixsemi.com
Subject: Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
Message-ID: <20220425091419.GA967110@anxtwsw-Precision-3640-Tower>
References: <20220422084720.959271-1-xji@analogixsemi.com>
 <20220422084720.959271-4-xji@analogixsemi.com>
 <CAG3jFytWGSUM9mevHewdmEe-hq3JgB74s7_f0fsEQqkXr9VUHg@mail.gmail.com>
 <CAG3jFyvEYbwkdGtiNR-6vFEXTLjcyT_viqp9qeVxFTu0PrJEVA@mail.gmail.com>
 <CAGXv+5E1cCNWD98fMDjC38y2UztZd=PNQ+=G=wrBYfoXkswvHA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXv+5E1cCNWD98fMDjC38y2UztZd=PNQ+=G=wrBYfoXkswvHA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XjfmbmGxeuIzjlWvpZQTiU35q9qI11XOrEFSy24Xh2g1NhiUbbi8DbjM1lux?=
 =?us-ascii?Q?nSkDXss+L7qLjEdwQeeOaZ7Thx/gRUkT9EYRtBsw/CgMSw/dShmyFFFHu+tH?=
 =?us-ascii?Q?8iRBBHCqSPXZjaIWMKzgMRUUApTPaB8lXCU68F1mW7STYbOV2TRGB/DcU6Mr?=
 =?us-ascii?Q?KCCzJEoKs6SMw3FM9LEAk26PSAZ3wxvKerMRdGFh1J5bmmk0tBDY/w4FFgH0?=
 =?us-ascii?Q?6aWIpQD2CINpyhv0kap1fiCaKVzpANklTa08MiSt4VdR9B+ZbMr3bmhQFl0b?=
 =?us-ascii?Q?FmDE4qQcfBpY8nGeDRYTEur0awYBTDrki+N/rNBal8V3cTxaUnqiWKHz03X5?=
 =?us-ascii?Q?kCgyag8+pUZ/V+Dfh2L82LJaQLKXpkmiuD5UrVwcOgfRKWihF2nRzSHfM9YG?=
 =?us-ascii?Q?bu89Y/dPBz2NAgL8EJAGMiL1mE/XsIeiKT/Di03cmXyQRf4hmwoyNJst72ll?=
 =?us-ascii?Q?G5s0QbpAgmNC7rF+UaX2Z7+YxeGIcACis46RTJUhcN/1qlN7x32glEjEn/NX?=
 =?us-ascii?Q?CI1ZeFAMfl5HtTVozDKAxcpPjK+jr5gIZV8QZG2aVlsrPjjyZ4QQ1oPqaK2r?=
 =?us-ascii?Q?6VrSrzmAh1cnaIsODS+w0PvCqnsPJCOjbXnUGk/rQbrxeEsOSJANrTIdFD0H?=
 =?us-ascii?Q?mCUc72QCjGwUD49ez6tFngGniWDPrWBgzO+O9RcIBdJTXga9QiCjvzZlQqgE?=
 =?us-ascii?Q?Ufo5zVI6e0dKeZDrj8LcIE8IJz5QX54J9/3rzmITh4qcUhdxPKo2VRDXrO11?=
 =?us-ascii?Q?EXDjEDHnBAWVjhmHNse+8Inng3lmJN3B90Y77IRxD5r8IdEDhIN2owLIqHYJ?=
 =?us-ascii?Q?CCgXlN47C0NCqVOVV96DhSviPrCQvuPkzwrAwWlGmp0aCSjboczXwn/uuZgn?=
 =?us-ascii?Q?ZrWl+YmSHgUCMDUL66RiE/jSjMBFq9QLH/J02xpUmf047MDZGDtaPNF2uGHb?=
 =?us-ascii?Q?wkapdFJbSkKzeWq0KEo58ST97eMc0F6/JBWH4gVaphegc7/r5tjFzMQrQoxn?=
 =?us-ascii?Q?e/LvlN8clye7bSxqhPfWRhpY8Z/4JAgywT8XOzEG8TF2vBJgfrq1vPEuuv5v?=
 =?us-ascii?Q?IOg0OYoz/o7YiCFdDYlYLFsPF4pqVIuRRORGcDHMrGqEVIwdISO8xjheZ8PH?=
 =?us-ascii?Q?IkO83EZRWah2xUu2TI88L0GuSVNbMnVTSo1SMnVImzs58MNiaJ37AaLSiirz?=
 =?us-ascii?Q?VO3tSlUh7ekMYK1FCrvD9TecvMZNIx7FZGbJvEVJvb2tIjh31DTTO9FA+LCD?=
 =?us-ascii?Q?pPk7a/neTPCMNTG8zk+NaBf1lxXcvyYHjwIf930D6twx9UMe+LBs8equH6Ca?=
 =?us-ascii?Q?GBJL+/mGxv1rKarNRrA0L2dQLdGbVBa9HdvV4fCvKmjr7mvurSAUfAy2hm2k?=
 =?us-ascii?Q?NU7io7D73b57B0xuqlrZdrOtxU4+9OUgTV8pzSmGd9EcEhfoG5WR+S32Smxb?=
 =?us-ascii?Q?F44EgZBO1QQ8iqYsGWDFWg/Alj4aJ0D7N1QGp4T5NneV8cM8V7tbFLiYQIvN?=
 =?us-ascii?Q?dnMsxS1YReKBTTuGXtc0O8oG/QZV0AApclklj7cawcJsR4r3WGLmvGhkHamm?=
 =?us-ascii?Q?QBPyL4Kv9DZ/U5B81S56TlSuf0/bdr9poCf1Y28NyftpAa/mePtCzwE0eJeg?=
 =?us-ascii?Q?61ut4XXWYauI62RglsY+mhHlLQOe8zT1IptiDHR6tfjhCvaRYy21OSVTPUmW?=
 =?us-ascii?Q?pdzXjbTN/sHhCgelfAkenMFPkC2E5e4kQIGkvUY8CVA05DoBikYGis0Hd6Q1?=
 =?us-ascii?Q?rYZPhihwuQ=3D=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ef4eba5-0ddc-422a-376e-08da269bfeee
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 09:14:26.8438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2h5y7Dsb29MTh0JSgqbM65WIpEarE2off2yB1SvWdC6sp2VGqIccmUz4N9yOT3gv6vQ1GvnLk0SrkPYcBNeAIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7746
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > >
> > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > >  drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 376da01243a3..71df977e8f53 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > >
> > > >         anx7625_get_swing_setting(dev, pdata);
> > > >
> > > > -       pdata->is_dpi = 1; /* default dpi mode */
> > > > +       pdata->is_dpi = 0; /* default dsi mode */
> > > >         pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > >         if (!pdata->mipi_host_node) {
> > > >                 DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > >                 return -ENODEV;
> > > >         }
> > > >
> > > > -       bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > +       bus_type = 0;
> > > >         mipi_lanes = MAX_LANES_SUPPORT;
> > > >         ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > >         if (ep0) {
> > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > >                 mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > >         }
> > > >
> > > > -       if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > -               pdata->is_dpi = 0;
> > > > +       if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > +               pdata->is_dpi = 1;
> > > >
> > > >         pdata->mipi_lanes = mipi_lanes;
> > > >         if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > >
> > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> >
> > Acked-by: Robert Foss <robert.foss@linaro.org>
> 
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> 
> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> mainline (next-20220422).
> 
> Xin, in the future, please send the whole series to all recipients of
> all patches listed by get_maintainers.pl, not just the recipients of
> each patch. In the case of this series, they should have been sent
> to all of the mailing lists (media, devicetree, dri-devel) so that
> everyone has the same, full view of the patches.
Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
Thanks,
Xin
> 
> ChenYu