Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 11:22:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Vihas Makwana <makvihas@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH] staging: r8188eu: fix a potential NULL pointer
 dereference
Message-ID: <20220425082244.GK2462@kadam>
References: <20220423184745.21134-1-makvihas@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220423184745.21134-1-makvihas@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PKT6mVdXIaSajd6udgejb595bHxALkXC9K0UbVt32sSWUUnCPa/0Uu1x1z4o?=
 =?us-ascii?Q?MNSZb5gc7z+ZVgLK2xAVovgPYxDVEYuhJ5ZMInWL4M6AKoY9xfbNAfbHURj+?=
 =?us-ascii?Q?Dfpe2NyuHJ2Vurb+A4ccf8QLY/wzvuxdJ6Lc3nm/OYNcIzB45OTGxvJZ7Ygo?=
 =?us-ascii?Q?Fhl7blrqsl/J8aHrg0f4BSV+/UMaJH4SzKLApiHzY9kSmpF5PZWhRb61PUJ0?=
 =?us-ascii?Q?UT7a+OB1b50ZwLIbR/lAmIAtdfrpW8YM3m3FkyKCD9hGWbqTXvKO7hG6QOXb?=
 =?us-ascii?Q?jumIEUoqlSEOgE5S1BKtcCPhhswO5ofW9hNoBeJGFxyethvzv254VvGLCHjH?=
 =?us-ascii?Q?4yFAtv8LV3GB9VIFmdWozeh14rL0ePoTdGhVKDpDZcEeorihAxtwGXZy9CI9?=
 =?us-ascii?Q?UvDHxEKkjqbKkr0jg5+0RJwhtVkkQa6Ku973Dc3CBObamDXjbvuyGGkKKToI?=
 =?us-ascii?Q?rs5LOHf2PNtobZ0zaLRZsPzVkFGfySa5BQpjbNGtXN7FZRCim/MCKoSMR1Q8?=
 =?us-ascii?Q?36fmUtxDJW6E1dVwQGsqsqcF36IljjCDsFmtS1cwoMQDq3eDR7ZusSWe7f2s?=
 =?us-ascii?Q?tPdFNyet5GAvtFh5xtQKCcQbxpOAOhZ8X9TQ5ZcDgn0trQ1wrqSoM0InqZ3Y?=
 =?us-ascii?Q?EAnLQFQCZYX2VU6crUXX47L+200Ww2p4MslBuyZK6g67eO+fhjsqmCfAX9Xa?=
 =?us-ascii?Q?sBv6N1x0GFsbgD5OETq2T0mJ76FoR9msj6aNk5amuhOCL/ubIcIF4jYZlXvl?=
 =?us-ascii?Q?QkcTTGJQVzL1kR9FRYHBjmnhYF4WSRMAlywe8GnbFJArZtadbKT2b+gi9SLq?=
 =?us-ascii?Q?2zzVBJ2mMaqvp8MY4tJYXQVcx+3koYYJAky00LlrLESYFvmLEysmzMmwJJMC?=
 =?us-ascii?Q?eyu5u8xygAobLXRVSVziZHb8BWb8RgeSpTKoJs5l2i7YkQino/TOjiX1lokP?=
 =?us-ascii?Q?w4Ry35IbA/4tluDqbtyaxG9RdeMPlzLniTnAl7lNYFFGKEwM/JPs5qPX/ddQ?=
 =?us-ascii?Q?3Xx1B3mnLuhIWryn3DgYW3HZKk1rf+CQjdGGctyu26MtcQhTzV2MtemPARb9?=
 =?us-ascii?Q?DFVURREU8BR8mxioRGRgPDozSzAnDqWM1La6nmPIAmmXK1aIrrgqFoVX6NYA?=
 =?us-ascii?Q?sd1eQrqKZ2Q9pZUFoSCq/TlRWn29DN7DtI+Cl7vn3HisqK1+nOmFHwgyBFSN?=
 =?us-ascii?Q?VparvNJ5w6vnvZq/KkCdqyoOzkPPtTfkbX9A1JxNPdtuv0u6uGBxo/GIYLl/?=
 =?us-ascii?Q?K9SD8oBNVMWOHN1bQG86YK7B//MjamXsLa/kQVMkERMV0LT6SBFoSe2UyFHH?=
 =?us-ascii?Q?L0MwMxJtQUl9kct1mgKZpJh0+VftFzB1y8FEddU/5ahOMNheI/nuN5Krvadd?=
 =?us-ascii?Q?/6m0fMI+Ryw4NB3WgTCtCNb5G//ggEE8q1meGal48CavB/tc6j6JffExXubN?=
 =?us-ascii?Q?Ov0knnh7W/gYHByQTdHh/T/CKNvaAK2poS1wvZeWqfsQy9FTfDWL7IUISzWO?=
 =?us-ascii?Q?lMcwji0KNuRVJFX8Ua4PGq0BQCGRDu0s1wp4Yj9KWw+b4SpcNcL8+kwnqfbi?=
 =?us-ascii?Q?OlMRj+ziXQHnUkqd6Hc0TA5FNO6MG3r8ghY5xAnaOwpCDGKN9kbAw+Sfb7rv?=
 =?us-ascii?Q?MWQAQ4ITO6KX8IA7z2OTFzYWdx5fiLiaBfFkwIOuRFoVsoNcG/prJQAv1IUD?=
 =?us-ascii?Q?do+mVVMUWDDKbPYJoWxSsHgr9JlLY5Bag+qDyirA46CNb2a0H9gxLKpgMAUC?=
 =?us-ascii?Q?sSO8Tc1MNH3Y+K2XiD/ahSSsLAqSpP0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24f848bd-1476-4514-a17f-08da2694d17e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 08:23:04.2629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qw6Bumt7NRpGUIe/p0ORhrGHSV9y8Snc7J7W0P2dZs608EtggN9lbi7XmLL7xdGRvo/t2f9wuL4ipl71+z3BJ3FCgcUX/13/ymdSzttLWF0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3434
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_02:2022-04-22,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=868 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250037
X-Proofpoint-GUID: fCxgCs2N2YYCbs4khA9DOj3xAaZC3uj1
X-Proofpoint-ORIG-GUID: fCxgCs2N2YYCbs4khA9DOj3xAaZC3uj1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 24, 2022 at 12:17:48AM +0530, Vihas Makwana wrote:
> recvframe_chk_defrag() performs a NULL check on psta, but if that check
> fails then it dereferences it, which it shouldn't do as psta is NULL.
> 
> Set pdefrag_q to NULL if above check fails and let the code after it handle
> that case.
> 
> Fixes: 1cc18a22b96b ("staging: r8188eu: Add files for new driver - part 5")
> Signed-off-by: Vihas Makwana <makvihas@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index c1005ddaa..db54bceff 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -1244,7 +1244,7 @@ struct recv_frame *recvframe_chk_defrag(struct adapter *padapter, struct recv_fr
>  			pdefrag_q = NULL;
>  		}
>  	} else {
> -		pdefrag_q = &psta->sta_recvpriv.defrag_q;
> +		pdefrag_q = NULL;

What?  "psta" is valid pointer on the else path.

(Also this isn't really a dereference, this is just pointer math.  It's
taking the address.  The Oops would happen later if psta were NULL.)

regards,
dan carpenter