Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     Leon Romanovsky <leon@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     Steffen Klassert <steffen.klassert@secunet.com>,
        Shannon Nelson <snelson@pensando.io>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
        Raed Salem <raeds@nvidia.com>,
        Shannon Nelson <shannon.nelson@oracle.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Leon Romanovsky <leonro@nvidia.com>
Subject: RE: [Intel-wired-lan] [PATCH net v1] ixgbe: ensure IPsec VF<->PF
 compatibility
Thread-Topic: [Intel-wired-lan] [PATCH net v1] ixgbe: ensure IPsec VF<->PF
 compatibility
Thread-Index: AQHYRNhHTOl2L8e8AE+8stZffQfmg60Apyhw
Date:   Mon, 25 Apr 2022 11:34:42 +0000
Message-ID: <DM8PR11MB56217CED4DFFAB90FA256C0CABF89@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <737616899df2a482e4ec35aa4056c9ac608d2f50.1648714609.git.leonro@nvidia.com>
In-Reply-To: <737616899df2a482e4ec35aa4056c9ac608d2f50.1648714609.git.leonro@nvidia.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z/6IQum5d6iHnz08ZnQy24KZFL2DKCIllsj7Q1sU4E1yuf5A6gjGGeO8cbbp?=
 =?us-ascii?Q?RK6DSFPHOeWF5RnLvpGhJkHN7Oo2Xy4C6TM68EWNwKAKRpDBlC7Jl+iAwTkP?=
 =?us-ascii?Q?pOQA4g+kbIKfZP1HvEuza9JTeMw9/70vCDo62WdSJYXFNOX8h4i+p2T++oAe?=
 =?us-ascii?Q?YqjIW3wxIGyBDKU9G+T9nn1Jjr4Rx589OlozhMR2iWWU+d9iV98IRNPfT/pz?=
 =?us-ascii?Q?xQN9+6eieUGIpapIEo5pxmpj+QTX1UUCKPv6eIOHXoe3vQqZ7emkoFT3dLiB?=
 =?us-ascii?Q?JtuHbERJ3uOQYa/be4cLENhZgoUtjf7B7JpESjqE+Zz+wAhjYWIUG6sgddlC?=
 =?us-ascii?Q?DwpxiRM3NIW3Na8Efb3kotLLeh6Su9MDs16grHbsP5CZ+12U+qDOXiWLeoc0?=
 =?us-ascii?Q?Dg7JSbrjoV/NX20RU/zc6zL3QcFCV7KwvRukjyLupae19FAo9e8y8FVQxiT6?=
 =?us-ascii?Q?mYqdB/ngTzsbSz/V2E3KIB4NYMyPqckMLClO07lLK5Ih2EmGYYF8pgn4BORF?=
 =?us-ascii?Q?cbd7StWlg9hUxepG73ce9GNjfpOVkGXKxVmqeJmzY0jeB7YbrbNcafv3b/aU?=
 =?us-ascii?Q?PUoW8vA00JN1aU+6zOCFLvcZgIqg1gFFSiBgWuFDEFHRZwtwk9uwbYO9qqIH?=
 =?us-ascii?Q?604hHppzpLtMQOyp1Har4DfSWgAkRY+H4kzk4X1cVtYScXjv9SaLp8v6/LGF?=
 =?us-ascii?Q?o+jjJLajhc5it4385Lt0ABWJ4+iF2ieu0Wpi0mP0PfH+zKb1UgckCHxY/oXi?=
 =?us-ascii?Q?OmnHyaH2TDTfE5VJyUkzfQDB5SqlW7iZTwTBv2O+PDoA4x6LxiyxnkqoQ7kI?=
 =?us-ascii?Q?ZJX43RK/dXkPyTLLyiMbfkQ+mswNmY79MRzNDqIjaFp/WPXzt7nljPAE/kU3?=
 =?us-ascii?Q?jRV5Zg5sSV1exz3y3cRfGwXyCFtaBX6Rzxrxnt09HJfOSdtJJwsBdargpIBo?=
 =?us-ascii?Q?Qe4wB9NIF2PCa/FkQs5zLpQ15jC+eW7+tkOD1wx9uSH1oFoKsxMQ2Vk2XLPS?=
 =?us-ascii?Q?CdG2ksSvQ87nIaPyxdX3RzsbdKaZAgiAqY4CXZ6tjo7+p5VHZPzai+SQeGux?=
 =?us-ascii?Q?9Px1Icg1xZg74BFivrWx677QzlKPP9h5oyvTLc+bYDAO2cByLcxsDdGAWSM/?=
 =?us-ascii?Q?HSgEjGM3WjUWZbHBSrVCily+RdIJbcgc2pdzS4hXhJGLlewtVsebCb0OG+S3?=
 =?us-ascii?Q?cS8k90J/F3pZ8SROJ16jutLesXMbAEc8V/2tJ8ERNqJqvuFEFDtS+FQu6CLO?=
 =?us-ascii?Q?590bUth/VnOOsThhHA/64tqpnH118MGC2TYo1ZHynFplRboeV3Rf1ifcwVFB?=
 =?us-ascii?Q?52sbV1NjV76Q95J8EYU/FEOj4UCdRdjMK5CMHHVUQUtC7n2+3AMWOks2M8Zf?=
 =?us-ascii?Q?iRrR74lK4iipiS6Q7niRGxjCWi578DTbvS+rkY8wSfHqTEzYn7MLzlIA0MQa?=
 =?us-ascii?Q?zlQKI4xTldSOTSzbRJBVcXPDX3Qb46DiqkSGYFtfOS8rj65SXtsk96sN7yKg?=
 =?us-ascii?Q?EMtXRgOswPmvkf5UHXTPZnpqPOILsRT2icMlspnoOjbB0JAVi/4rFcUG52+K?=
 =?us-ascii?Q?e13jtQ8xuFuINDMnRTab8D0B0aeXbLXI1O7pNo/ihDESdmFQZoQA2aS0RCOw?=
 =?us-ascii?Q?TcEYxun7b2B203KGSnWoERzARH6kWiPl7XSGmStuAN/S6nyS0cHSykrLklhu?=
 =?us-ascii?Q?0CODoLTSLVk4kAUEkULPrCMPatXnuuBbYlhDaz42zVPrv+F8gCSBH/YJXSWx?=
 =?us-ascii?Q?JCaE7jIBmKrdWPjI6S0Fq06r6ilzDGY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9eac317-5678-4168-f4e1-08da26af974f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 11:34:42.5609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5N/5Nly6dTHkQ4c0p/FV0Zh0BujkJsZwdBeNvHK3t2c6JPcivYpNjToZ0iaOCuDma/9m8zec1yQOp8xT+3eo1I+Sh/zQh4MEo92IPCLensI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2354
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Leon Romanovsky
> Sent: Thursday, March 31, 2022 10:20 AM
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>; Shannon Nelson
> <snelson@pensando.io>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Jeff Kirsher
> <jeffrey.t.kirsher@intel.com>; Raed Salem <raeds@nvidia.com>; Shannon
> Nelson <shannon.nelson@oracle.com>; Paolo Abeni <pabeni@redhat.com>;
> Leon Romanovsky <leonro@nvidia.com>
> Subject: [Intel-wired-lan] [PATCH net v1] ixgbe: ensure IPsec VF<->PF
> compatibility
>=20
> From: Leon Romanovsky <leonro@nvidia.com>
>=20
> The VF driver can forward any IPsec flags and such makes the function is =
not
> extendable and prone to backward/forward incompatibility.
>=20
> If new software runs on VF, it won't know that PF configured something
> completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag.
>=20
> Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
> Reviewed-by: Raed Salem <raeds@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>a
> ---
> Chaagelog:
> v1:
>  * Replaced bits arithmetic with more simple expression
> v0:
> https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.16
> 48637865.git.leonro@nvidia.com
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> index e596e1a9fc75..69d11ff7677d 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> @@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter
> *adapter, u32 *msgbuf, u32 vf)

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>