Received: by 2002:a05:6512:3a82:0:0:0:0 with SMTP id q2csp566589lfu; Mon, 25 Apr 2022 04:48:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/VbKwRa3Esbk4xi1fSKMjmEQzKXMheWnqijopg2PVQU4p4Y6gKxjBn4ucxGivKVwpYNp/ X-Received: by 2002:a17:906:714:b0:6e8:7f57:2d4e with SMTP id y20-20020a170906071400b006e87f572d4emr15768749ejb.575.1650887326594; Mon, 25 Apr 2022 04:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650887326; cv=none; d=google.com; s=arc-20160816; b=ONmfP9T5gnYJ1JdX8EbvM6mjvSzrpvIFtPLGfnajpOm54nQQ8uJdsWrJNXyhep9hI/ 3uoxYL0axvvKRr4JT9ImorMuqsPyUmzkGL4844GUpMmoJeuMkQkFCk8mET4TK0rdtGL5 Jx0tpADKnSngg/57D8Cul44CJOy2Ywj4F3FwJGPwatn3ycCCKzbtVIZp2LNPDLGT3i/0 wWcAGO5Dxx8UyJRRwD5eHYYkldJ9OZ0oxSXTjdbYFeSU0EG9FkGgpLBsn3oMxluGTbxj 3uENn7Jur7yEpG6fdN0/zC45hRvwSybMNUTPcU7lDktORfYprvUV2v7yr6zMpG3RgeQx T3Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1tJ9zzvRCUoR3prmuGVEOag1gZtQsOGDr82jdXYMAjw=; b=mu4uUWUxyYELeeEK5T9Xa9ipNo5psa+lb7ebV156XvMssJMUVvnjEVlzZT6PIUNppA UHg6iUH0tZfGZ16bI1bd+subjCsQw70ak375s/spaKJKlERMwD6VsSyMWMttM4LtdeAG X6gSUAPgPkyJXIDW4WlqNamD0rtDlATPYrHY8sqZb8jZMaqvnXx6okPjyJtnle6IVHhH wQGtMRAhFSTGwRNV0RUzPTpl+I3xabqLyFV/6CA/3t0Whad6y5ewpddQmsvJTSTzSlz3 0caMzYyjVvR7fvEYgB0EuQfrAWoOfsMNE99ANRjERjSPiAHPj6CcSkZV4D1x2s4kaC0D UpXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w20-20020a1709062f9400b006f39645649asi2277935eji.639.2022.04.25.04.48.19; Mon, 25 Apr 2022 04:48:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238661AbiDYKKg (ORCPT + 99 others); Mon, 25 Apr 2022 06:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237747AbiDYKKA (ORCPT ); Mon, 25 Apr 2022 06:10:00 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C96CA3630F for ; Mon, 25 Apr 2022 03:06:42 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4831B1FB; Mon, 25 Apr 2022 03:06:42 -0700 (PDT) Received: from bogus (unknown [10.57.11.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63E843F73B; Mon, 25 Apr 2022 03:06:40 -0700 (PDT) Date: Mon, 25 Apr 2022 11:06:35 +0100 From: Sudeep Holla To: Qing Wang Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org, vincent.guittot@linaro.org, peterz@infradead.org, dietmar.eggemann@arm.com Subject: Re: [PATCH V2] arm64: add SCHED_CLUSTER's dependency on ACPI Message-ID: <20220425100635.ig4dxvlflglfagpx@bogus> References: <1650855303-91388-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650855303-91388-1-git-send-email-wangqing@vivo.com> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 07:55:01PM -0700, Qing Wang wrote: > From: Wang Qing > > cluster sched_domain configured by cpu_topology[].cluster_sibling, > which is set by cluster_id, cluster_id can only get from ACPI. > > If the system does not enable ACPI, cluster_id is always -1, even enable > SCHED_CLUSTER is invalid, this is misleading. > > So we add SCHED_CLUSTER's dependency on ACPI here. > Any reason why this can't be extended to support DT based systems via cpu-map in the device tree. IMO we almost have everything w.r.t topology in DT and no reason to deviate this feature between ACPI and DT. -- Regards, Sudeep