Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp18267pxb; Mon, 25 Apr 2022 05:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBnxJffJAVm3gf4j5vPC4Y2V/gq7mudVova0lyg4oEJwd+QUL1gKXechCPR8vRu+FcO7EU X-Received: by 2002:a17:90b:1e4e:b0:1d2:8dba:67fb with SMTP id pi14-20020a17090b1e4e00b001d28dba67fbmr20451749pjb.55.1650888020178; Mon, 25 Apr 2022 05:00:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650888020; cv=none; d=google.com; s=arc-20160816; b=HJKOS279xZjGImVPnBYSYzaf6yvADPDhAstYqJS/vQcmvZb5SNKBJQvLEwNHGuw+QY mL+nlV4qFKnrBD39V53ql+r9+kjPSF6xAm4kV7hw3WVl/Zhz3YhtEhEpnIskpQsaVQES NBRlTfZjzrndftTII+iSKxfy+JqGveS+is1LtZLueGQFPf1Qs0FOU7ea4s4AGxsQ/kxX 6jVgVFleIVXbiMOb18RMkuELExTIu0uTZX126vSpDJ/MgmgzwAb6PvHVLY4k2K1dXqWe 4XJxguSu3r24p4uMfRDgfYeD9NZztSXNYKHn8yh7SAH0TIavkzt/kNphwpK1jFix2sPv MhnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=56NN6zZVxvbLkQrbJHX/KNsBedxcH06PSSk2wZ+6weA=; b=BIWaGQcsdILm7twmgtNwdxBeNEIAZJG6RrxiPZcbvmUXL4Q6jYXpWEZrKO9IWGSRwh vxy94TwMZO1LXPIzBCKpTLWyE1cmYgxVDae5HavjIQYpBHaKuybsR8B1coFopcVSAF/v hUMsoZg6LF24AZejksXMzL6ArQmmfE8iGU3XpwMSdzJr/bvbw1bHmRoucLjESke28buj VyhCQTz+prbIHoECFg/oMUDJTm6QojD8Mr2oNjkxzr97ylP3aCf5W+1FoY6f8aVaiItl H4tUkbAil+84y54m1kxzak/O6SYSDGNm6CZzbiXSqDvPHwZHtQE0i8JSOekUqA0HSAFz xsYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a056a0022cc00b0050d471105afsi1160992pfj.326.2022.04.25.04.59.45; Mon, 25 Apr 2022 05:00:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238648AbiDYJja (ORCPT + 99 others); Mon, 25 Apr 2022 05:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241665AbiDYJiv (ORCPT ); Mon, 25 Apr 2022 05:38:51 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70E21237CF; Mon, 25 Apr 2022 02:33:33 -0700 (PDT) Received: from kwepemi500013.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kn0B84mDJzGpLl; Mon, 25 Apr 2022 17:30:56 +0800 (CST) Received: from huawei.com (10.175.112.208) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 17:33:31 +0800 From: Zheng Yongjun To: , CC: , , , Subject: [PATCH] thermal: broadcom: Fix potential NULL dereference in sr_thermal_probe Date: Mon, 25 Apr 2022 09:29:29 +0000 Message-ID: <20220425092929.90412-1-zhengyongjun3@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500013.china.huawei.com (7.221.188.120) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Fixes: 250e211057c72 ("thermal: broadcom: Add Stingray thermal driver") Signed-off-by: Zheng Yongjun --- drivers/thermal/broadcom/sr-thermal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c index 475ce2900771..85ab9edd580c 100644 --- a/drivers/thermal/broadcom/sr-thermal.c +++ b/drivers/thermal/broadcom/sr-thermal.c @@ -60,6 +60,9 @@ static int sr_thermal_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -ENOENT; + sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB); -- 2.17.1