Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp38224pxb;
        Mon, 25 Apr 2022 05:23:05 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzA4vNnKL6sFjnVlFD9WhOL0zCSI5Kvi3sU+3R5dNVEYmYAalN57EJ2NPE3+esbaObsSo81
X-Received: by 2002:a65:46cf:0:b0:399:13b3:dd8b with SMTP id n15-20020a6546cf000000b0039913b3dd8bmr15085918pgr.585.1650889385444;
        Mon, 25 Apr 2022 05:23:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1650889385; cv=none;
        d=google.com; s=arc-20160816;
        b=UTHTvVjh84OltlBjEMPOslrFikSa3mjmY8Msonf3qnXgnkn0Rk+EVgtVmo/8teCxJA
         ay6HnnaihTahkL+pB8hQGTJXJkvMhcnxgVuodf3C5VSRPA8NrhagNDYPtf/8Y+l0r/1d
         +h8eFaOHtMy3wDCzClcTCNHEtMR168b4vmuaXFyGoVTOmVCfR9M6B9IZH/4BmfvQ81sV
         9DhmBfiIPZ8TZ1pkDl0RoFSMn4oJb5lX1gWveD9+18gH9cp39Kllyy4alCKqkBMchKit
         w3i/gO5yo3flE/npWSEmz73Djq/6GrCALru3D5p1Tu+pJaWQV17y6SpDeBwF7GiLCimd
         8yNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :user-agent:references:in-reply-to:date:cc:to:from:subject
         :message-id:dkim-signature;
        bh=B9WB+hwhosJvYbo65GHTbgrVCXpNO9OFYMi8Pd4ssjM=;
        b=zcznKrvIIrycnDm4bayVKlHqR3yndjjRW0COlqJC1tW63RHQ5/kOXkSybkN4IUbKam
         AkwAq1wNW0CRwlAyoY546o2kar5YcYeMFlT5/h1B8Q2LT5hMDCRmNvaOfXnNhneozLti
         1LV18JQXsmAh9dPtnTQIa8CPu6vYonmxON7bkRAZNPbSIr66izt3TrEZb5IRKOJk6wCR
         ZTDEmzakZKQ46XXHquUSiSuOT3OJzydkSqgMTKVlhQLET0IWfaIppp+lnEqhK0s0QXM7
         HphVi46VP0sSsyYkhyPDw7/8DgZGey8uv2NhmIHEl8gTr14fKXbWp+cq8Mtp8sW0lO/D
         fpxA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@igalia.com header.s=20170329 header.b=oGM378hp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id 127-20020a630885000000b003aa45e1fe1esi17093050pgi.238.2022.04.25.05.22.45;
        Mon, 25 Apr 2022 05:23:05 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@igalia.com header.s=20170329 header.b=oGM378hp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229573AbiDYHNb (ORCPT <rfc822;andreacani85to@gmail.com>
        + 99 others); Mon, 25 Apr 2022 03:13:31 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60982 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234757AbiDYHN3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 Apr 2022 03:13:29 -0400
Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5F77220C5;
        Mon, 25 Apr 2022 00:10:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;
        s=20170329; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:
        In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=B9WB+hwhosJvYbo65GHTbgrVCXpNO9OFYMi8Pd4ssjM=; b=oGM378hpwyyWgNK+VOIA1H0x7u
        WtffthAd0NQPAVqMFccjAax977qkbil5cGtMEF50TXta1rBKXer3eWMh0HcGudRb8WPBY8Rj4POso
        rPt4H6mv+Q84MHv3IW6y74Rn8eH2LVIfIoarXYimaKR8KvKfFiNOJmI4TZ5/aPwU2CXksdr8uCmQC
        j3X19KKGSDUMPVNHXowbu2a6WJx+OlNWWlz8wQDfyszGRhXvz85GIFVF5Giz5ZldYccQ2pV0AXk5H
        XExvNE3b2YOh3F1vzIP/3FLUAmj8NSavUmbnERzRhFPGVVDEn9eNVjCJAZpQNLCJmNanv02ZYb9BH
        nu+Gdy1w==;
Received: from ip171.dynamic.igalia.com ([192.168.10.171])
        by fanzine2.igalia.com with esmtpsa 
        (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim)
        id 1nisrR-000CQI-LG; Mon, 25 Apr 2022 09:10:17 +0200
Message-ID: <890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com>
Subject: Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon
From:   "Juan A." =?ISO-8859-1?Q?Su=E1rez?= <jasuarez@igalia.com>
To:     Colin Ian King <colin.i.king@gmail.com>,
        Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Melissa Wen <mwen@igalia.com>,
        dri-devel@lists.freedesktop.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 25 Apr 2022 09:10:17 +0200
In-Reply-To: <20220424183512.1365683-1-colin.i.king@gmail.com>
References: <20220424183512.1365683-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote:
> In the unlikely event that pointer perfmon is null the WARN_ON return
> path
> occurs after the pointer has already been deferenced. Fix this by
> only
> dereferencing perfmon after it has been null checked.
> 

Good catch!

Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>


	J.A.