Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 14:56:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Alasdair Kergon <agk@redhat.com>,
        Mikulas Patocka <mpatocka@redhat.com>
Cc:     Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com,
        Milan Broz <gmazyland@gmail.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] dm integrity: fix error code in dm_integrity_ctr()
Message-ID: <YmaMgPr8bM/0PFUi@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IlBpg61Q0vvMk9rz8LJmgFaC1iKwRlzI1w5CCHO9hOakSF2MMduOzNYCXPz6?=
 =?us-ascii?Q?rSIrXlSBxuPK4zz5jbfrOQgZNY6dUoLda/b/M4c4CTzCPL3pjdDY3nRUnGUA?=
 =?us-ascii?Q?J9Nl9UGqQEPdW0t46Ow8AgLKMm8Q4Fz66z+z2WnmqMeKP4wAGJ1RKPihUKkD?=
 =?us-ascii?Q?3h4XiLuS796Nz4sbvew3ayTgf6nP8ciMN0PT7mBw4pWjw3p9wc627OZMYg4G?=
 =?us-ascii?Q?bsthwQaYk4krsGk1rdZ2M1QUTWWPMO/HTxk7nWSYoYlfBoB/8jMFTBOb47Oi?=
 =?us-ascii?Q?vElnWKBUmNE6/5NSlaXYieGay/yIzMAYsI/kmrh4QQKMjrT08oShQrXd2drn?=
 =?us-ascii?Q?8mcRO8pmbiLXiC875McVZilhIczTa6KRnvBa7A8Vph1gKxgOfGHm3jilcHHy?=
 =?us-ascii?Q?00qrX/LXMrENUCoIcGoPbhQ+ekciF+Ycq2Gx4Pv+8ziAYesY+MoJGNWTWnYV?=
 =?us-ascii?Q?AYDLmlaP1OuAq/c0aIgrfyQiWAemRHJmY5tz8k0Os/ykAjEdGuqOPX7bW/XV?=
 =?us-ascii?Q?ra59eMiB+vh9vQ3q0iKsg4uiGLZtLsxGH+OmXL/2ecFH0PlTHOyPOfG+i1eB?=
 =?us-ascii?Q?6ngUrFn5BRDTACxhpVXC6NnFtLUbKZshUpqA7k8arDvJNwBzFpyP0QYOv4oH?=
 =?us-ascii?Q?w79YoFlVuOqxXGddaj0bkvnI2E9UPfuKSDxwz6n+AR53JfYF/kjcggCwOSkC?=
 =?us-ascii?Q?/UPBiIekPFvn98BSZ8dGc+boj0X2ASp5D5cPAU8YqLm5qoKO1z7T+xnL4+2H?=
 =?us-ascii?Q?ls8YrK0XngnfI9Htx7whPE751cQqL1339LeNQKDVPzwwi2QNgd6ooLIb7DaR?=
 =?us-ascii?Q?/ClaOT9yWkiYH+kEelP0CcUCaI8xmptuRIS3LlVJCiozPtgA5qCwWM3aDH6M?=
 =?us-ascii?Q?vQJoMnjw9G5rzyd87xQJ2APsRGenoN2kovNAvmNS/fpc14E48TAVrS29gN5H?=
 =?us-ascii?Q?KQuNyVv0JfViMa9nR0PZU5UyC4S6mjFifWX6LE6QQo3PUTCxl0Hb1rAWuYb4?=
 =?us-ascii?Q?/5UNCgxpvxn67iHbQVv8UCujZpqFA3QBgUQ57VOZGbfkaoZRetNPb8spsQO9?=
 =?us-ascii?Q?TbWxSnaXmdk/6BngvDCy3Hbsp9NNxFn/4j50yZJQnhf13IP9wRNCPyJGwVCx?=
 =?us-ascii?Q?+65hhCEybGUNNyVIjedgrHKmAJ3vtZ58G1/5iNKLwSwn6qG8xwFNVRfpCp7l?=
 =?us-ascii?Q?8Q000P13HK/9issf77ydH4ol7tnY4q+dXUuVqcx3mMgKSZnVaXWsdV2jRXQF?=
 =?us-ascii?Q?6u+D6ros3ER83ylKw2scOrgHcGZ57q49RV7dBf5lXhAj5f7XPkMWOlD3vi/G?=
 =?us-ascii?Q?1FWhrlwL6pu2H5mO5oDaCpHSCptZ+oRbSVscmXm9JF2wCCLgHQbyjjXVdfI1?=
 =?us-ascii?Q?1/rz/3fKjJT0r7m1nma/3/UrdgX3v7WyU8uBN7tRaAkGEH7b4jKThSskUDdI?=
 =?us-ascii?Q?deopPcqxWWvIAyR83BPmVW0GzQHDawsnl/9OwIvEOj2JyrkTxc7AefpPjU7t?=
 =?us-ascii?Q?obwp06W5SjWUKjh0w2w8AuP37eL6X5xA6TZG7JQ8JYTdct7Ak/Tc3Gbu6c/8?=
 =?us-ascii?Q?FCzb/dwNJjYm8Kf+TrbhbuDSaZS/04WI3K/PWEzriwVxjS9JIsvf9BQbgkxi?=
 =?us-ascii?Q?Bp6ugl15d5X9rb4t3DsQj1MzL3G724rf77RCKudMODKLvQtxUt3oMK70mzMV?=
 =?us-ascii?Q?hvLxgk9vV/+ohkKuiZXcQ2eLI+WRYMORGYK+aYKbZrnZhGhKwfKo3Ii41sd0?=
 =?us-ascii?Q?q06fDbRF/NFRi31fml2x3GoW4aZFQso=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf822e7-7b71-42d7-61af-08da26b2b3ee
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:56:59.2062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YQvGKRwXdiOCkqtxjOfeKrV0P/H4CrHv6ZCIoF09gcBmWRrFhinSy00qYzn7WmFhJvJ3Uw+nEsPmERmnlYg+dcyE8ONk0JMlVgSAYelk7VE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5126
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_06:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250053
X-Proofpoint-GUID: j62BFL0wDx7z03HWVNXn3rKjlSXUIoqp
X-Proofpoint-ORIG-GUID: j62BFL0wDx7z03HWVNXn3rKjlSXUIoqp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The "r" variable shadows an earlier "r" that has function scope.  It
means that we accidentally return success instead of an error code.
Smatch has a warning for this:

	drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
	warn: missing error code 'r'

Fixes: 7eada909bfd7 ("dm: add integrity target")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/md/dm-integrity.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index 36ae30b73a6e..3d5a0ce123c9 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -4494,8 +4494,6 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned argc, char **argv)
 	}
 
 	if (should_write_sb) {
-		int r;
-
 		init_journal(ic, 0, ic->journal_sections, 0);
 		r = dm_integrity_failed(ic);
 		if (unlikely(r)) {
-- 
2.35.1