Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 14:57:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: dvbdev: remove redundant initialization of
 variable ret
Message-ID: <20220425115743.GN2462@kadam>
References: <20220424154720.1356873-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220424154720.1356873-1-colin.i.king@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SFbHoiPJlru2NYH/43bBGCUVE9gHK4YRUo7m9GzY5lzF3KqdPszk4w7bsj+Z?=
 =?us-ascii?Q?sSlkftQXLxPzDNs8lBHfXcJefy/B6pb0tlMxIFF4jRc1R4SpgIapTMjXq7zC?=
 =?us-ascii?Q?FDb/LJuOFQo9ucpDG1O7yhCs+HnjNkEFPjbbzgGBvPuo74wBiLg7rHIzwN5F?=
 =?us-ascii?Q?+HLyvAL9i5PsdRRzNZDwoGYY8IOzOt8IPZS0xCH+lzZfllzZLgevlVUD5Uor?=
 =?us-ascii?Q?94FEEK1sDiR8rOsdmiFz2Wi5EEkCOq5izO5FVB6a/sYetj2sQr5A1T+Vfe1J?=
 =?us-ascii?Q?LAUhrLSzIzvnxafuPQ0N00ZnPRcncSMJ/HycxYMolX20uZrTQJ/+GBgnew4H?=
 =?us-ascii?Q?cWjrZMY7+ktamSiseVDz0zC+C5H/iVjZHEOQ7i7gNpA+neoH/wlpPim/GJ3/?=
 =?us-ascii?Q?frXVx4Sr7t+UgDH1acsflHqwLmiZ5STEo6kj9BAgwSq+tOG6M2k2sKk2Sz2T?=
 =?us-ascii?Q?HEV2tliCs86NCdulLNt/n/rd5SY5c+fHHpfLt8EIVS0K9U+ruCJSizti5ltj?=
 =?us-ascii?Q?r691c2jmR8dMpKtYCnPFYx4uA70QR2UbnzZpEwsyAffM7bLdteYyKiSEAxIZ?=
 =?us-ascii?Q?EjVplDsYxLBKzzzP7Jjg9f2dzTaNurambREtJHvjhS3PesjirBpqSz0SFti6?=
 =?us-ascii?Q?Pf2BDXLQ/CzpI+xg4mybGVqGSDNsHCIsd0jVcijhfK8qbNxp9MrlRnSA1YjF?=
 =?us-ascii?Q?riiSQHATT6NIch7UwN9TAjH+c82bm4PADP0OrauxV6M+Oj8rqDcLwAYCQvp1?=
 =?us-ascii?Q?iP5793Was2pNRgbmN953zj5hDxu55pySbzZv4X84CiiTcbWxvZC372HdvMJX?=
 =?us-ascii?Q?/Zo0tan7UVcUzmkfHKqsz3wDcXBIB8ByQCZnl5FFiFZfbes1lr0RAvg8DoEU?=
 =?us-ascii?Q?qKfQ9hfHpjFtAm/nhqKcaDizznsKMEjGYHYoInHUsvByNdQi7qHhD8JWrauY?=
 =?us-ascii?Q?SFrt1K+zJx9+RuYWFWhLCdVtXgi6LzWAlGPenkaEydsVL57Tzyc7NjvA3ZHm?=
 =?us-ascii?Q?3P16zxPCg75du+z0ANx129pzs9uh9olvuDiXCC8qrXc38qEHO2/FXu0sveKN?=
 =?us-ascii?Q?8L7HLqThXNkzo+LqHtDMRKU4NCCJmVIfXYaiaqoY8pnkfNTPHvyRjtT34fQ+?=
 =?us-ascii?Q?jL5wFJtTaBoScLx9BmXOH1BjHOZr/cV6vCSdoYdiDfC622gKsOqbSEQGCJRt?=
 =?us-ascii?Q?v34IK++7YQYqoCCLkcFim3r4Cglbps/V0kUW5exAVeCC6RV+s9t6resRAiBR?=
 =?us-ascii?Q?Xud/VsDSfthcom5t0TXs3xNyF+1QRAWDNl4O3YyEIKqxr5nzzOyrthzgGVcf?=
 =?us-ascii?Q?8B86PrsU7lh9vt//pRxflwtVH/hUA7ID8LqdSYJ/Qjcp185fIGDMzBKIdDR/?=
 =?us-ascii?Q?FcaCXkjnbZJOG6gnvHMSCxypgesbJBGglc1nmzqLmFV1mITetK+OnQLvaJea?=
 =?us-ascii?Q?hsF177Zw39LJ3UZgO5FJ8XYJd7IQEnbeinEzLu1kGNH7Dtw6Z0FUJrV1smGl?=
 =?us-ascii?Q?yc/6xDZ3AQmTBwONNymBjHQnFZGW2qFoPS20/pKCbHfTgzBLP3cpxeNYC6Ky?=
 =?us-ascii?Q?9CUdYxwbMF97FnC+6sVWWbr9yZjeunSZAIWghkC6anZs1VK4EzzCMuE/k6xv?=
 =?us-ascii?Q?dRq0Vdtoc1glamNk0j1cipYLfMYrHGiAF0MhAAD+7u2v1kFxvvJXR0lrPsgg?=
 =?us-ascii?Q?V7gskepMKTx0rBuBOGE6ai5OYO+kqM0qp7cFS2zVXOlIzeQKUlJgfnEdYWmU?=
 =?us-ascii?Q?D2dp3Cy5e/4D0M1ngxgCu9hWesK9hOI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dcd32a78-9660-4585-ffdc-08da26b2d445
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:57:53.8893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gmVQcyAjhhrLwHVsu3HnKc9872N5vOt8vTQDoeJQVibecUEHfIZe4+EbHwMs1a7U6HTt9MVinWdq4Olhlar5XVGKMu0/xCJZeUXO4OpmPvE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5126
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_06:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250053
X-Proofpoint-ORIG-GUID: gN1pfaj79-8TyrWkajUdNBqdEBXk27fR
X-Proofpoint-GUID: gN1pfaj79-8TyrWkajUdNBqdEBXk27fR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 24, 2022 at 04:47:20PM +0100, Colin Ian King wrote:
> Variable ret is being ininitialized with a value that is never read.
> The ininitializtion is redundant and can be removed. Move the variable
> to the scope it is required.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/media/dvb-core/dvbdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
> index 675d877a67b2..d5a142ef9876 100644
> --- a/drivers/media/dvb-core/dvbdev.c
> +++ b/drivers/media/dvb-core/dvbdev.c
> @@ -243,7 +243,7 @@ static void dvb_media_device_free(struct dvb_device *dvbdev)
>  static int dvb_create_tsout_entity(struct dvb_device *dvbdev,
>  				    const char *name, int npads)
>  {
> -	int i, ret = 0;
> +	int i;

It's better when "ret" has function scope.  Otherwise in the future
when someone adds a "ret" you're going to end up with two "ret"
variables.

regards,
dan carpenter