Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <791eca4c-8ffe-7ddf-cc48-7c3a29b858d2@openvz.org>
Date:   Mon, 25 Apr 2022 11:40:21 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of
 mem_cgroup_from_obj()
Content-Language: en-US
To:     Michal Hocko <mhocko@suse.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Shakeel Butt <shakeelb@google.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        linux-kernel@vger.kernel.org
References: <c60767c9-03fe-2c9b-9844-752ef0df5b03@openvz.org>
 <YmZPqAOLO7XkBsW8@dhcp22.suse.cz>
From:   Vasily Averin <vvs@openvz.org>
In-Reply-To: <YmZPqAOLO7XkBsW8@dhcp22.suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/25/22 10:37, Michal Hocko wrote:
> On Sat 23-04-22 05:23:03, Vasily Averin wrote:
>> Replace leading spaces by tab:
>>  WARNING: please, no spaces at the start of a line
>>  #X: FILE: include/linux/memcontrol.h:1480:
>>  +       return NULL;$
>>
>> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
> 
> Please drop the Fixes tag. The tag is supposed to point to a functional
> breakage and this is purely a style fix.
> 
>> Signed-off-by: Vasily Averin <vvs@openvz.org>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Andrew Morton suggested do not create separate patch for this change,
So I'm going to combine it with my next patch, which adds a few lines below.
Even if it will not be approved -- it isn't a big problem, someone will fix it later.