Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c1e137b-9866-4f6b-1413-0adaa8fdd57b@kernel.org>
Date:   Mon, 25 Apr 2022 07:57:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] tty/hvc_opal: simplify if-if to if-else
Content-Language: en-US
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
References: <20220424092511.100309-1-wanjiabing@vivo.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220424092511.100309-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24. 04. 22, 11:25, Wan Jiabing wrote:
> Use if and else instead of if(A) and if (!A).
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>   drivers/tty/hvc/hvc_opal.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 84776bc641e6..2dafa0964c2a 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -344,14 +344,15 @@ void __init hvc_opal_init_early(void)
>   		opal = of_find_node_by_path("/ibm,opal/consoles");
>   		if (opal)
>   			pr_devel("hvc_opal: Found consoles in new location\n");
> -		if (!opal) {
> +		else {

This looks good, except missing braces as noted by Joe.

>   			opal = of_find_node_by_path("/ibm,opal");
>   			if (opal)
>   				pr_devel("hvc_opal: "
>   					 "Found consoles in old location\n");
> +			else
> +				return;

I am not sure this return is more obvious than the previous one. Rather 
the opposite, IMO.

>   		}
> -		if (!opal)
> -			return;
> +
>   		for_each_child_of_node(opal, np) {
>   			if (of_node_name_eq(np, "serial")) {
>   				stdout_node = np;

thanks,
-- 
js
suse labs