Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 24 Apr 2022 18:46:06 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Andrea Merello <andrea.merello@gmail.com>,
        mchehab+huawei@kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org, andy.shevchenko@gmail.com,
        matt.ranostay@konsulko.com, ardeleanalex@gmail.com,
        jacopo@jmondi.org, Andrea Merello <andrea.merello@iit.it>
Subject: Re: [v4 10/14] iio: document "serial_number" sysfs attribute
Message-ID: <20220424184606.571b3764@jic23-huawei>
In-Reply-To: <4a940702-8a34-c163-2e5a-8dfd835e56d0@metafoo.de>
References: <20220415130005.85879-1-andrea.merello@gmail.com>
        <20220415130005.85879-11-andrea.merello@gmail.com>
        <4a940702-8a34-c163-2e5a-8dfd835e56d0@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 19 Apr 2022 09:41:54 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:

> On 4/15/22 15:00, Andrea Merello wrote:
> > From: Andrea Merello <andrea.merello@iit.it>
> >
> > This patch adds ABI documentation for the new "serial_number" sysfs
> > attribute. The first user is the bno055 IIO driver.
> >
> > Signed-off-by: Andrea Merello <andrea.merello@iit.it>
> > ---
> >   Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index 2a6954ea1c71..3be613f64843 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -2048,3 +2048,10 @@ Contact:	linux-iio@vger.kernel.org
> >   Description:
> >   		Raw (unscaled) euler angles readings. Units after
> >   		application of scale are deg.
> > +
> > +What:		/sys/bus/iio/devices/iio:deviceX/serial_number  
> 
> Can we make this `serialnumber`? IIO uses underscores to separate 
> different parts of the name and to a machine (e.g. libiio) serial_number 
> looks like a channel called serial with an attribute called number.

Works for me.

J
> 
> 
> > +KernelVersion:	5.19
> > +Contact:	linux-iio@vger.kernel.org
> > +Description:
> > +		An example format is 16-bytes, 2-digits-per-byte, HEX-string
> > +		representing the sensor unique ID number.  
> 
>