Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <366fe755-6f07-499a-0b19-f046fd03c89a@collabora.com>
Date:   Mon, 25 Apr 2022 10:53:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328
 compatible
Content-Language: en-GB
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Johan Jonker <jbx6244@gmail.com>,
        Alex Bee <knaerzche@gmail.com>,
        Elaine Zhang <zhangqing@rock-chips.com>
Cc:     linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20220422133803.989256-1-chris.obbard@collabora.com>
 <20220422133803.989256-2-chris.obbard@collabora.com>
 <ff87d5cb-b0d4-95a2-90b0-7827a2a34d05@linaro.org>
 <34819690-5cb7-bbce-a2f5-3f6e66661049@linaro.org>
From:   Christopher Obbard <chris.obbard@collabora.com>
In-Reply-To: <34819690-5cb7-bbce-a2f5-3f6e66661049@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 23/04/2022 18:31, Krzysztof Kozlowski wrote:
> On 23/04/2022 13:10, Krzysztof Kozlowski wrote:
>> On 22/04/2022 15:38, Christopher Obbard wrote:
>>> Document the RK3328 compatible for rockchip-vdec.
>>>
>>> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
>>> ---
>>>   Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> I acked this but Johan pointed out that your intention was different and
> missing patch context is quite important here. Please explain what
> exactly you wanted in the patch? Now it looks actually wrong, so my ack
> is not correct.

Wow - I think i was in weekend mode and forgot to run dtbs_check ;-).
It will be solved in v2. I have now added the check to my "pre 
send-patch" review checklist.

Just out of interest, I didn't get a mail from Johan and I can't seem to 
find it the archive either. Is that message in public as I'd like to 
address any other concerns at the same time ?

Cheers!
Chris