Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 14:26:50 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stephen Kitt <steve@sk2.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, Wolfram Sang <wsa@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] ASoC: tpa6130: use i2c_match_id and simple i2c
 probe
Message-ID: <YmahmnPi4B2n29BE@sirena.org.uk>
References: <20220415160613.148882-1-steve@sk2.org>
 <20220415160613.148882-8-steve@sk2.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="T8rJwMde3z+laYB7"
Content-Disposition: inline
In-Reply-To: <20220415160613.148882-8-steve@sk2.org>
Precedence: bulk


--T8rJwMde3z+laYB7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 15, 2022 at 06:06:13PM +0200, Stephen Kitt wrote:
> As part of the ongoing i2c transition to the simple probe
> ("probe_new"), this patch uses i2c_match_id to retrieve the
> driver_data for the probed device. The id parameter is thus no longer
> necessary and the simple probe can be used instead.

This breaks the build for omap2plus defconfig on arm:

/build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: error: initializati=
on of =E2=80=98int (*)(struct i2c_client *, const struct i2c_device_id *)=
=E2=80=99 from incompatible pointer type =E2=80=98int (*)(struct i2c_client=
 *)=E2=80=99 [-Werror=3Dincompatible-pointer-types]
  322 |  .probe =3D tpa6130a2_probe,
      |           ^~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: note: (near initial=
ization for =E2=80=98tpa6130a2_i2c_driver.probe=E2=80=99)
cc1: some warnings being treated as errors

You forgot to move probe() to probe_new() in the driver struct.

--T8rJwMde3z+laYB7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJmoZkACgkQJNaLcl1U
h9BefAf/VDPZ0QQrR6OeJku+HULqwEWbUZpAa/ixPLJa2dPE1oZZDRB2TYdUD1Tt
NccZ3n8Btpt80ic08sQeSAyNMwy35WKJRCKtLQmiXWMQ83XNO+vc0DBAVYxYYZfH
ijjKNYUpNac0Zf1m0hSRdIqsAFoQJ1oMWxIARx5p0SU+RpZqvOesbqrxwsu4ll/Y
EmCwRTJDfFd83r6iz5MpTGk3i4mbQxznMVwCT8zvtAdovGToy8OWD8veBk1Kbmje
cs4eelWdRW2w4/uzV2ljKbyvvwX8defeanZOCxt94moqUjVr5PA/VBj4Yofmxo/1
yJ7li4d0QB/Jcs/bJzUZtcb/19Hdvw==
=g1Ku
-----END PGP SIGNATURE-----

--T8rJwMde3z+laYB7--