Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp279061pxb; Mon, 25 Apr 2022 09:51:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhzEl/Tq6xDhn4IGhkIoVj+cNALYwltbR7KDJSgNd89dHmgrME2BVL2qzyroi/U8xP7vGQ X-Received: by 2002:a17:907:168a:b0:6e8:d125:1d24 with SMTP id hc10-20020a170907168a00b006e8d1251d24mr16873977ejc.508.1650905502920; Mon, 25 Apr 2022 09:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650905502; cv=none; d=google.com; s=arc-20160816; b=Pkh0HyOTZbGQOvYGL8ZcroUKpyLFbmVnzA4HVscFXiFHHRNLNVwISynkzyFs48cJVN r5GvnJhYkXkrrV2wEytT8qXggkGvIAkTOwd5aWkogfjEMkRqHtdtcPykHswejWXj9i9L irjp3atIgq4L7s6LKDxjAHeEGZdGFPYNam0P8N+GvCpLrJFtQkPjeMP+OUEV3s2oST8t xUCxJsi82keTiMpX4ZB/adzLDaRr9BpHL98rUX2Wheoj8bkb7oPnVA7Uq0TaoXPW3qLe PhHF506IcfL07qPSaGqiG1/uSuM29mWbuDPfAbjXZttB+L/kS7cq7EtwP4VKgSsRIPNk b+mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FzeLoq6Z9/8RdG24cy3IuWz/e+Pv2gwxZNw0m+8OPi8=; b=xI2bjeFUQcETj9pCQZZABTcsrKP6pbhYAxSlaTt4LagpkHj3hXwnsFMF895K4vheiW we1F0eBqiTdw5LdhFUQev1rcPffDcjGjBqS8UCTNi/Y5GbKD3fU+ljbmF3Tqq4am3SCb 2TGSgrj2B8mmho8dScgKWJoM9aXyCIvlnmmK5TyHLCH3QJWZu7GQDXwWfM1SyHBn2sOQ oBI70AhToR3kKWQFnIvg7uJdXhHHFdNkKbwUQjJ5nzv3mA8ZLcNeJUQ1xNajl45ZgwYm 2Myfdd17q1BRajLXQnA8nlkgugiM9V2wVLJcx4Dx2ddBzhMSAWgg8TnbXh/r5MzE6Ozu NJpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="CoW/TX5H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020a05640227d000b00423f048cf50si15674776ede.446.2022.04.25.09.51.18; Mon, 25 Apr 2022 09:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="CoW/TX5H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238901AbiDYJnS (ORCPT + 99 others); Mon, 25 Apr 2022 05:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241504AbiDYJmf (ORCPT ); Mon, 25 Apr 2022 05:42:35 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CFD1A801 for ; Mon, 25 Apr 2022 02:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FzeLoq6Z9/8RdG24cy3IuWz/e+Pv2gwxZNw0m+8OPi8=; b=CoW/TX5HGNzrEL01WnKgtsQTR8 Jpjm9/rZxVf9oBbENDYrXEhs6zGovvyFpMUxbUd1FLpAVV7RIqyjAeyF2ocA9j8BjI8pYXPaxQbm3 hwNjzDDTLHE4Vq3X+J14Oc6M+YQ/xXVMrb3y5Kbs3qsWTu8VaHbPNqS6giDlh0VVeoyeGRLO+iIIF h2Dqef6frpV2cMfYCPzguPPDeE/JGhSnrSeU2R4X6+HUItMAgzlVeiLn1Oeik2IiYoHevcknZiSNZ 7DL37K0BrAtAvckpx7iMe4Kc74wPHudr5olMt40Byd1XexaZz1S1/xOAwkHvztXtVQtgBqEsOrJPU haqM7A3w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nivA3-008VlN-Ai; Mon, 25 Apr 2022 09:37:39 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 8BF2D980BF1; Mon, 25 Apr 2022 11:37:37 +0200 (CEST) Date: Mon, 25 Apr 2022 11:37:37 +0200 From: Peter Zijlstra To: Donghai Qiao Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de, heying24@huawei.com, andriy.shevchenko@linux.intel.com, axboe@kernel.dk, rdunlap@infradead.org, tglx@linutronix.de, gor@linux.ibm.com, donghai.w.qiao@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/11] smp: use smp_call_private() fron irq_work.c and core.c Message-ID: <20220425093737.GH2731@worktop.programming.kicks-ass.net> References: <20220422200040.93813-1-dqiao@redhat.com> <20220422200040.93813-7-dqiao@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422200040.93813-7-dqiao@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2022 at 04:00:35PM -0400, Donghai Qiao wrote: > irq_work.c and core.c should use the cross interface rather than > using a unpublished internal function __smp_call_single_queue. They should do no such thing, using an unpublished/private interface was on purpose. Nobody else should be able to do these things.