Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 08:48:27 -0400 (EDT)
From:   Mikulas Patocka <mpatocka@redhat.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
cc:     Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com,
        Milan Broz <gmazyland@gmail.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dm integrity: fix error code in dm_integrity_ctr()
In-Reply-To: <YmaMgPr8bM/0PFUi@kili>
Message-ID: <alpine.LRH.2.02.2204250846510.1699@file01.intranet.prod.int.rdu2.redhat.com>
References: <YmaMgPr8bM/0PFUi@kili>
User-Agent: Alpine 2.02 (LRH 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Precedence: bulk

Thanks for finding it.


On Mon, 25 Apr 2022, Dan Carpenter wrote:

> The "r" variable shadows an earlier "r" that has function scope.  It
> means that we accidentally return success instead of an error code.
> Smatch has a warning for this:
> 
> 	drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
> 	warn: missing error code 'r'
> 
> Fixes: 7eada909bfd7 ("dm: add integrity target")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

add:

Cc: stable@vger.kernel.org
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>

> ---
>  drivers/md/dm-integrity.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
> index 36ae30b73a6e..3d5a0ce123c9 100644
> --- a/drivers/md/dm-integrity.c
> +++ b/drivers/md/dm-integrity.c
> @@ -4494,8 +4494,6 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned argc, char **argv)
>  	}
>  
>  	if (should_write_sb) {
> -		int r;
> -
>  		init_journal(ic, 0, ic->journal_sections, 0);
>  		r = dm_integrity_failed(ic);
>  		if (unlikely(r)) {
> -- 
> 2.35.1
>