Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220423102421.16869-1-fmdefrancesco@gmail.com>
 <20220423102421.16869-4-fmdefrancesco@gmail.com> <fad918d3-6923-5bec-7830-5cddf7a725d6@wanadoo.fr>
 <2583087.X9hSmTKtgW@leap>
In-Reply-To: <2583087.X9hSmTKtgW@leap>
From:   Todd Kjos <tkjos@google.com>
Date:   Mon, 25 Apr 2022 08:52:09 -0700
Message-ID: <CAHRSSEwvPB27SJNtzq-5ZoMW=VDbVpv-2BmACT+hzQYUXJWO4A@mail.gmail.com>
Subject: Re: [PATCH 3/3] binder: Use kmap_local_page() in binder_alloc_get_page()
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Todd Kjos <tkjos@android.com>, linux-kernel@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <brauner@kernel.org>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Ira Weiny <ira.weiny@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Apr 24, 2022 at 2:40 AM Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
>
> On sabato 23 aprile 2022 18:02:48 CEST Christophe JAILLET wrote:
> > Hi,
> >
> > Le 23/04/2022 =C3=A0 12:24, Fabio M. De Francesco a =C3=A9crit :
> > > The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()
> > > where it is feasible. Each call of kmap_atomic() in the kernel create=
s
> > > a non-preemptible section and disable pagefaults. This could be a
> source
> > > of unwanted latency, so it should be only used if it is absolutely
> > > required, otherwise kmap_local_page() should be preferred.
> > >
> > > With kmap_local_page(), the mapping is per thread, CPU local and not
> > > globally visible. Furthermore, the mapping can be acquired from any
> context
> > > (including interrupts).
> > >
> > > Therefore, use kmap_local_page() / kunmap_local() in place of
> > > kmap_atomic() / kunmap_atomic().
> > >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >   drivers/android/binder_alloc.c | 6 +++---
> > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/android/binder_alloc.c b/drivers/android/
> binder_alloc.c
> > > index 0875c463c002..058595cc7ff0 100644
> > > --- a/drivers/android/binder_alloc.c
> > > +++ b/drivers/android/binder_alloc.c
> > > @@ -1250,17 +1250,17 @@ static int binder_alloc_do_buffer_copy(struct
> binder_alloc *alloc,
> > >             page =3D binder_alloc_get_page(alloc, buffer,
> > >                                          buffer_offset,
> &pgoff);
> > >             size =3D min_t(size_t, bytes, PAGE_SIZE - pgoff);
> > > -           base_ptr =3D kmap_atomic(page);
> > > +           base_ptr =3D kmap_local_page(page);
> > >             tmpptr =3D base_ptr + pgoff;
> > >             if (to_buffer)
> > >                     memcpy(tmpptr, ptr, size);
> > >             else
> > >                     memcpy(ptr, tmpptr, size);
> >
> > in the same spirit as patch 1/3, memcpy_to_page() and memcpy_from_page(=
)
> > looks good candidate to avoid code duplication.
>
> Hello Christophe, Todd,
>
> I had thought to use memcpy_to_page() and memcpy_from_page() (exactly as =
I
> did in other conversions I have been working on during the latest couple =
of
> weeks).
>
> However, I decided to avoid to use them for I should also have deleted th=
e
> comment which is before "kunmap_local(base_ptr);".
>
> I don't know how much Maintainers think it is necessary to make readers
> notice that "kunmap_local() takes care of flushing the cache []" (exactly
> as kunmap_atomic() does). Actually I'd delete that comment that looks
> redundant and unnecessary to me, but I cannot know if Todd wants it to
> remain there.
>
> @Todd: Can you please say what you think about this topic? Should I leave
> the patch as-is or I should use memcpy_{to,from}_page() and delete that
> comment?

I'm fine with using memcpy_{to,from}_page() and removing the comment.

>
> I won't send any v2 unless I have your confirmation.
>
> Thanks,
>
> Fabio
>
> >
> > Not checked in details, but looks mostly the same.
> >
> > Just my 2c.
> >
> > CJ
> >
> > >             /*
> > > -            * kunmap_atomic() takes care of flushing the cache
> > > +            * kunmap_local() takes care of flushing the cache
> > >              * if this device has VIVT cache arch
> > >              */
> > > -           kunmap_atomic(base_ptr);
> > > +           kunmap_local(base_ptr);
> > >             bytes -=3D size;
> > >             pgoff =3D 0;
> > >             ptr =3D ptr + size;
> >
> >
>
>
>
>