Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp334503pxb; Mon, 25 Apr 2022 10:52:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0KO3DqMNb14CrS04fg2N6z+tNF0c8NQfc/K7vd2BAnWXyn5eeR5ujuVXlebQixZEp3WKl X-Received: by 2002:a17:907:7d8e:b0:6e8:c95a:525e with SMTP id oz14-20020a1709077d8e00b006e8c95a525emr16756026ejc.312.1650909160403; Mon, 25 Apr 2022 10:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650909160; cv=none; d=google.com; s=arc-20160816; b=VSWvM/rzXwSTmdJypd1voYyvcJLY0sKz4B36S8HAnpsp1u5fU+e9yz+7WOpxiAVC/E kKufq/rzQ9SKTYpCzmAIAdc/F/N32CJcrwKiv9FeGunj4EO/t+qyQ8RhTVYG62/XcprQ 8LLGqiLA/M2o8I31gTGm/Lm/OqHB9yxU3i8qw6QlYAotmkzTN5yEo2P7M7aQVTG+YV0B Yva1e0r6qxBTrqgsL7WgzpgDc7E2YiswOSR8lR9FL5lMCsE4WG92H9G9uBwQxkuEiBKT TI8IQp9CItctSqkq45LSssipMR92c2ClgLl4oWrLsZtXzhksfAyEvwTXPSnFTTnY44bi ib1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cQDFKRoKhhktwi5lxO+7XU88CodqUGjLfy0fXQQbBls=; b=u+bcH5538ofZWBluhLtsPoZrwU6L9RYusVzuUw76C++DUxSVvmAWkp5LeP3Tvgq35k wIBjeLdrzNPKUT+5slRT7YiwsBUbzZvhEEgRfpCqyMWHwnKtgPeeEu/7Xo8SnoRyNEAp AC7OSWN1tcE+P0QXH15BdBEur6q4W8UUo8ZFeCyYwyCOK4vyjAhhbLR7h5ndBKQDebu4 Oy54D4iltt3tAUK8Y0c5ohzzx1Wnjno9hF2LL0JJlrLbEJEHBEdahWtEsclVlWDaOu00 mp/xocnQ3yaO5/eJ6s6hxbagTBU0cspeQRyPMKJaqAZZKpZ8NSAcmspnrgl1XlCjToeP ngAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=P1WwPXVB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z22-20020a1709060f1600b006e869e2793asi12164200eji.676.2022.04.25.10.52.15; Mon, 25 Apr 2022 10:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=P1WwPXVB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236920AbiDYInk (ORCPT + 99 others); Mon, 25 Apr 2022 04:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238424AbiDYInI (ORCPT ); Mon, 25 Apr 2022 04:43:08 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F567520A for ; Mon, 25 Apr 2022 01:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cQDFKRoKhhktwi5lxO+7XU88CodqUGjLfy0fXQQbBls=; b=P1WwPXVBU/QFKHB9epGK/BAyJA mWNpBNQq/+z4WHeU+lvMqB2b68ckLMIIeN0sbOWCW41rjvmla0jv94+e0x/BWDMjzS11W+/QD+jqh moWslPyp6wMvFo4byFheoxzBt+myYSgbzsgdnLmpkjohTSS/Zgh2ySbNJ1xs9TbCzU9UW1lPTT92D sI34Y+tCGWMs2J4O/Vmpl7jdXIfElft7Bvfp5rO6xgR1wPCYXAW0COtouJR5zAuibRdl0YAGbrXBK 4W2LSXN/fMNwzDrUwAJYcKK3h7HaqSItmre97lxw1id6moi66sxheru3x54MbebP2J5cSWm90EK8+ irZ19lyA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1niuFi-008V9m-Rh; Mon, 25 Apr 2022 08:39:27 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 66CF3980BF1; Mon, 25 Apr 2022 10:39:26 +0200 (CEST) Date: Mon, 25 Apr 2022 10:39:26 +0200 From: Peter Zijlstra To: Donghai Qiao Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de, heying24@huawei.com, andriy.shevchenko@linux.intel.com, axboe@kernel.dk, rdunlap@infradead.org, tglx@linutronix.de, gor@linux.ibm.com, donghai.w.qiao@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/11] smp: consolidate the structure definitions to smp.h Message-ID: <20220425083926.GC2731@worktop.programming.kicks-ass.net> References: <20220422200040.93813-1-dqiao@redhat.com> <20220422200040.93813-2-dqiao@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422200040.93813-2-dqiao@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2022 at 04:00:30PM -0400, Donghai Qiao wrote: > Move the structure definitions from kernel/smp.c to > include/linux/smp.h > > Move the structure definitions from include/linux/smp_types.h > to include/linux/smp.h and delete smp_types.h This Changelog is missing a *why*. Why are you exposing things that were not exposed before..