Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968042AbXEHMP4 (ORCPT ); Tue, 8 May 2007 08:15:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S968013AbXEHMPy (ORCPT ); Tue, 8 May 2007 08:15:54 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35918 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968019AbXEHMPx (ORCPT ); Tue, 8 May 2007 08:15:53 -0400 Date: Tue, 8 May 2007 13:15:27 +0100 From: Christoph Hellwig To: Thomas Klein Cc: Jeff Garzik , Christoph Raisch , Jan-Bernd Themann , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , netdev , Thomas Klein , Stefan Roscher Subject: Re: [PATCH] ehea: Receive SKB Aggregation Message-ID: <20070508121527.GA16763@infradead.org> Mail-Followup-To: Christoph Hellwig , Thomas Klein , Jeff Garzik , Christoph Raisch , Jan-Bernd Themann , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , netdev , Thomas Klein , Stefan Roscher References: <200705081405.33742.osstklei@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705081405.33742.osstklei@de.ibm.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 22 On Tue, May 08, 2007 at 02:05:33PM +0200, Thomas Klein wrote: > This patch enables the receive side processing to aggregate TCP packets within > the HEA device driver. It analyses the packets already received after a > interrupt arrived and forwards these as a chains of SKBs for the same TCP > connection with modified header field. We have seen a lower CPU load and > improved throughput for small numbers of parallel TCP connections. > > We added a disabled module parameter to prevent disruption of normal driver > operation. > We currently consider this as "experimental" until further review and tests > have been passed. > > Are there any concerns about including this in the mainline driver? So we grow yet another LRO copy in drivers? I think someone needs to bite the bullet and make it generic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/