Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CGME20220422120240epcms2p24bdcb416becf76b417f7c39006aa40f2@epcms2p1>
 <1891546521.01650629881201.JavaMail.epsvc@epcpadp4> <DM6PR04MB6575EB87D425CE431CC4A8F8FCF79@DM6PR04MB6575.namprd04.prod.outlook.com>
 <CAM36TBtsU0k1e+8-_Ew4ve3SJ0yExUFwPAYnmQy_-AXUHGoeZw@mail.gmail.com> <0f061fc0-d7ee-aa48-278b-4ca7dc3ce53f@acm.org>
In-Reply-To: <0f061fc0-d7ee-aa48-278b-4ca7dc3ce53f@acm.org>
From:   Jinyoung Choi <ychoijy@gmail.com>
Date:   Mon, 25 Apr 2022 19:59:45 +0900
Message-ID: <CAM36TBuch4Zrb8AWdh+q5oTCMB+T3KgFhR4q49T8G_pwk2NFgg@mail.gmail.com>
Subject: Re: [PATCH] scsi: ufs: wb: Add Manual Flush sysfs and cleanup toggle functions
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        "j-young.choi@samsung.com" <j-young.choi@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>
> On 4/23/22 07:24, jin young choi wrote:
>
> >>> +static DEVICE_ATTR_RW(wb_flush_on);
> >> Maybe wb_flush_enable ?
> >>
> > 'wb_on' sysfs already existed. So I named it in the same format (_on)
> > I'll change both. (_on -> _enable)
>
> sysfs attributes constitute an ABI. Breaking the user space ABI is not
> allowed. Hence, renaming existing sysfs attributes is not an option.
>
> Thanks,
>
> Bart.
I got it. Applied to v2 patch.
I sent a mail from Google Web,
but the mailing list was messed up with a tab problem.
(Changed to git send-email)
I'll be careful.

Thanks,
Jinyoung.