Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 19:23:50 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     Yihao Han <hanyihao@vivo.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        William Breathitt Gray <vilhelm.gray@gmail.com>,
        Sven Van Asbroeck <TheSven73@gmail.com>,
        Corentin Labbe <clabbe@baylibre.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        kernel@vivo.com
Subject: Re: [PATCH] macintosh: macio_asic: fix resource_size.cocci warnings
Message-ID: <20220425172350.fggwi7a76v5d6cbh@pengutronix.de>
References: <20220414140304.82751-1-hanyihao@vivo.com>
 <87zgkd8vnb.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y36m4bm5lfadd555"
Content-Disposition: inline
In-Reply-To: <87zgkd8vnb.fsf@mpe.ellerman.id.au>
Precedence: bulk


--y36m4bm5lfadd555
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Michael,

On Fri, Apr 22, 2022 at 04:44:24PM +1000, Michael Ellerman wrote:
> Yihao Han <hanyihao@vivo.com> writes:
> > -		if (index =3D=3D 0 && (res->end - res->start) > 0xfff)
> > +		if (index =3D=3D 0 && (resource_size(res)) > 0xfff)
> >  			res->end =3D res->start + 0xfff;
> > -		if (index =3D=3D 1 && (res->end - res->start) > 0xff)
> > +		if (index =3D=3D 1 && (resource_size(res)) > 0xff)
>=20
> Are you sure the conversion is correct? It's not exactly equivalent:
>=20
> static inline resource_size_t resource_size(const struct resource *res)
> {
> 	return res->end - res->start + 1;
> }

Indeed. I pointed out this issue in the v2 that already hit my inbox.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--y36m4bm5lfadd555
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmJm2SMACgkQwfwUeK3K
7AmYawf/QfGR/l+1FYITPyljtHxUcmS2QItRhRWCUUYh3GfjAbISpfA4QpCoQ+FV
WrQ8w0FW6XEbi5mXqI71rsL6jLQjRB9dheQYapd7JXuL1Q8Vtzr0UaOBmksGWKLH
RCAOvlqfTBMMcR17vsYoo1DQlrE0721MAilie6JcbCBzmV376tRsox+p2Bcuc0Xo
19T9Od9nMz79J6wBsOXccAwqc9UUlaxAfth2nxJyQbTtn1OBLtEztz8nf3+Y9VGo
CIj/3UBriHrGFUH/LVtFuAZwncErTxwUk6wcesgNUJNNSUJylLTfRarjZ+cHXlZr
Zu/WQOBr2X9h7xo73uriTK9lfqIw4Q==
=zCfi
-----END PGP SIGNATURE-----

--y36m4bm5lfadd555--