Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a1d0420-d99a-e4a8-c6de-729b56e9c1f0@intel.com>
Date:   Mon, 25 Apr 2022 14:19:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.8.0
Subject: Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result
 of MBM&CMT tests is failed on Intel CPU
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220323080928.1586408-1-tan.shaopeng@jp.fujitsu.com>
 <1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWJnQmtMaFRGZkNPaWFIbXdhbGxsWDFCS0EvdlFJTVhIR0E5Zm45N2RmU09m?=
 =?utf-8?B?RnFGcVllbG5FdG5PcDZwcDJIbWFkOStYcEdtSzBGWWFUZ2VCQ2pJR3d5ZWI1?=
 =?utf-8?B?VzVGblFmb21NdXBkRFU1S0RKYVhWMCtDOVZ2eTZzVWhYS0JBeFhBY2RjaXRi?=
 =?utf-8?B?ZGYyczlHQmpBUzFGMWQyZ2o2YUc2U3J0MVozZHpGQjYwVnVVbGJNMlJpMnZm?=
 =?utf-8?B?R3czb3I2QnFoN1QzTUVLYS9qWTVQV2d0dTFCSDFEVW8xVTI0MG1vYzk2TFFu?=
 =?utf-8?B?RTJUUzlPOThBSmI2TlVjT0RuMGFINVRhVHFDVmx0SXh6ZnFYMmVWbXlqVXJP?=
 =?utf-8?B?azk5cER6QVdTOWxJY3ZNc3dZK1lJQ3RDTGo5Vlg4MVYyTjNleDZFcUp3Qjc1?=
 =?utf-8?B?dU51QzdSSXFyY1lMeWxFR1hmaHpWZ3A1MjdiZW5VMW1JNWp6NE9zdERreVpZ?=
 =?utf-8?B?T1MzWm5OQnBoZTlyOGpmb3pHNi9mQnlKSS9mSDY5SUQzTGZodEpaeDNObVFG?=
 =?utf-8?B?SndwTStKVmV4S0orbHRVRkdkSXkyOXNtQW9sM1hyVDFnSXlhSVZRcjFLbmlF?=
 =?utf-8?B?UERlcVZIQWtETHFzSG4zazRyNFRrV0pDMHJQYlZGeXg2SDVBQnVTd3RrUEho?=
 =?utf-8?B?VVp5VDVmWTBLdkFibXRtQVVuVFFyOVJYOHhhZlNNWkhvNjRVTExFRDhSMkpV?=
 =?utf-8?B?UkF1NTRrUFRtSmVVN0JmNXlqYkV1N0dvdEFLcHM2YytXM25DdnVDc09pT2dI?=
 =?utf-8?B?T3l5NWE4cXFjNGRIeSs1RDFxSnpWVjZETWQycUJDY1kyVVIwWVpMaVg4dm9G?=
 =?utf-8?B?akQza3hJOStwemZtVDBwRHgrVVVHZ1EvQW9ZQy9yelhWRmhZbncrZ00rTzRi?=
 =?utf-8?B?Z0tLR3RhSTdMVUFqTC81b3F4SXNhbjNzVis0VUo4V1o0TzJEelFicDd4ek11?=
 =?utf-8?B?akU5anJybVd2aXdNWkpqQVpNOWJZYUN3ZXZQcTF3dFVaS1JmaHI0VG0ydWJh?=
 =?utf-8?B?VW1SSm5GblFpd2pQaitOTjgwN0NUR2RTNkxTTURmT1h2MkhKYkJodU5oelVn?=
 =?utf-8?B?QTU3UXlNcUQ2ZjlPTGJOOVB2dmhtckdHTTVObEkzZitlaUd5emZZN2ZFakkv?=
 =?utf-8?B?aHdwVTRTdDg0L091UDdZZ2wzb1VFM0NzVnkxa3dLWGI5eE9YdEx3dUJzb29F?=
 =?utf-8?B?aDZFT1dHbkZNdVlFa2l3K2h5VjBTY0YyWmhpQ0VCLzBxV3NFTWF2ZUo1OXJE?=
 =?utf-8?B?by9mZE1YVVNMRnhoWnJ2N3JqNzdXVGpEWkM2eENkcUd4UTMvM3lXRmM2UVdw?=
 =?utf-8?B?SmpNTGw0OVF4WFBXMGlRUlJWSENBcVVHblFlMWFjNTVKZTVvR2lQT2NhZlcy?=
 =?utf-8?B?NEZMclBjYkxhSTRCTGVhSTBlTnZtN0pnTVZFMGt6bzcrbFNTMExMeWtqN0h5?=
 =?utf-8?B?OGlYczRmd3FjeExkT2J1N09HaFNwWWpjSC91dC81dXA0YzN1V0t1VVJOQnZV?=
 =?utf-8?B?VjVjSEREMEF2ckFTeEhxa2JKS3BHMjgrMkJIeFMyYUMxY3BTaytMdnFiaHZl?=
 =?utf-8?B?NkJPTEhtOWJveURJSUF0V1dCMUZmRS8vQVFDdmg2ZWxwY3daU2ZNOENkd05r?=
 =?utf-8?B?UmIwTXpvK3hPWlhldjMvdlBnM2RZZXE4YjQ1NG4vcjRjcDR1NkZUUUJIaWVx?=
 =?utf-8?B?TGlhL01nNU5DMmxBY0hkeG5oK0czczZxMXR6UUVHMFJDNlZyYk9qWUc2cVVD?=
 =?utf-8?B?STJXM0RrWjk0VzFOek56QTNjc1drdGtNSnZiQ0hQWTVEYVNyVUQ0ajh6NW03?=
 =?utf-8?B?VHJlWGx3RG9iZEY1ei9pZGJJK3Nwd2JteHlxRkRsNUxiYXhtWlk2b0dxZGxo?=
 =?utf-8?B?ZVBzaUZlSnFacndsTkZoZUVnanRtTzlCdW9xeE9GeklVVE5NbzVSd3BoRlJQ?=
 =?utf-8?B?djhvNUUzVkhxUEZ3aEJoY1FwWDRpTkxrclFsbm1UdUs3T3B5dWdlbWJMWFo1?=
 =?utf-8?B?NWh6TVNmM0hUK1hXUUlPQ20zTWh1b2JXYzI3UEM0bzJPNm01Q1NsVmNSbDIx?=
 =?utf-8?B?Qktlam5yQWhic0ZpWjNKRFNzbno1cnByM1czWDF3bmpHYjJ6V3paTzdkanlV?=
 =?utf-8?B?bTg5V0M2ck1ERy9VZXpwa3VPZVQwNVdNWURNRkNiTEdKanFuSW10NVlpWlcv?=
 =?utf-8?B?STlYMXd2QUpSL3owRE1TM0JQakI1blFTcFhlQXh4ajhvQmVTcVl1ejFML0dN?=
 =?utf-8?B?d0ovWGtJVUJyTm5CSnJoSldhUTdoM0tCckJEdkxUVDVLZVErdThzU2h6eDJ6?=
 =?utf-8?B?dEpNQkh5Tjc5RGlKNU0zbm9CZkMzdCs3UWdQZThWQXZQOEcxMDUrMmhRanNt?=
 =?utf-8?Q?OkSX02uQmZBZ16TM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3549fc42-1d7e-431d-8e7e-08da27015246
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 21:19:45.7183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BfQ9B9/aPlF5BoCRsnF83VA8HkfxV4k3PlmRlSi+aSdM4rY+EgtEld4qsW+/5XgV/rcVgL5do97OIZU0q52SLmevasRHEQ8yBg5sXs0SUYY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5640
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shuah,

On 3/29/2022 8:37 AM, Shuah Khan wrote:
> On 3/23/22 2:09 AM, Shaopeng Tan wrote:
>> Hello,
>>
>> The aim of this series is to print a message to let users know a possible
>> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
>> In order to detect Intel vendor, I extended AMD vendor detect function.
>>
>> Difference from v4:
>> - Fixed the typos.
>> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
>> - Reorder the declarations based on line length from longest to shortest.
>> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
>>
>> This patch series is based on v5.17.
>>
>> Shaopeng Tan (2):
>>    selftests/resctrl: Extend CPU vendor detection
>>    selftests/resctrl: Print a message if the result of MBM&CMT tests is
>>      failed on Intel CPU
>>
>>   tools/testing/selftests/resctrl/cat_test.c    |  2 +-
>>   tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
>>   .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
>>   tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
>>   4 files changed, 37 insertions(+), 17 deletions(-)
>>
> 
> I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
> path with clear messages for failures.

Is this perhaps still in your queue for consideration? I peeked at the
branches within the kselftest repo but could not find it merged yet.
If things are tightened for fixes it would be welcome as v5.19 material
also.

Thank you very much

Reinette

[1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git