Subject: Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports
From: Richard Purdie <rpurdie@rpsys.net>
To: kogiidena@eggplant.ddo.jp
Cc: linux-kernel@vger.kernel.org, lethal@linux-sh.org
In-Reply-To: <1743.192.168.1.10.1178627225.squirrel@eggplant.ddo.jp>
References: <1743.192.168.1.10.1178627225.squirrel@eggplant.ddo.jp>
Content-Type: text/plain
Date: Tue, 08 May 2007 13:46:47 +0100
Message-Id: <1178628407.6061.24.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1159
Lines: 31

On Tue, 2007-05-08 at 21:27 +0900, kogiidena wrote:
> I wrote LED Blink Trigger. Pleas apply if there is no problem.
> 
> This allows LEDs to be controlled by a programmable timer.
> "blink" blinks LED at a constant cycle.
> "bitshift" turns LED or Buzzer on and off by the value of pattern.
> 
> Kernel version: linux-2.6.21-rc4
> Signed-off-by: kogiidena <kogiidena@eggplant.ddo.jp>

As far as I can tell, the existing timer trigger can do everything the
blink trigger can (and more besides). The driver looks like it would be
a lot easier to read if it just contained the bitshift trigger. To be
accepted, the bitshift trigger needs more documentation, particularly
the Kconfig entry. Its not clear for example that the bits are just
shifted once and don't repeat. Most people would probably want it to
repeat and with a repeat mode, it might be able to replace the heartbeat
trigger too?

Regards,

Richard


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/