Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Prakash Sangappa <prakash.sangappa@oracle.com>
To:     LKML <linux-kernel@vger.kernel.org>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ipc: Update semtimedop() to use hrtimer
Thread-Topic: [PATCH] ipc: Update semtimedop() to use hrtimer
Thread-Index: AQHYU5ANovQbEo/TBUSYkrXc/cSry60BEQMA
Date:   Mon, 25 Apr 2022 19:38:44 +0000
Message-ID: <8603345D-9AAD-43FF-B1DF-941BDA799DF5@oracle.com>
References: <1650333099-27214-1-git-send-email-prakash.sangappa@oracle.com>
In-Reply-To: <1650333099-27214-1-git-send-email-prakash.sangappa@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D7+arGn8dH/ftqPRlJVIy8swvKMdesN7sX0mEDPUV0gIG1tOOszPcoR3ui+l?=
 =?us-ascii?Q?T/AIGJZvxnFnJ6eSkWUXF7eATrW2m5qWwhLapl74/IfLKkQQyyJXVjaegF2B?=
 =?us-ascii?Q?mAaNwUJ2pwi7NX6empC/l0JalzCGRghrwLY08mCgT+0lIKHyWnuazIT98KKH?=
 =?us-ascii?Q?h8SV9l22AxUgrLIW33UZp3aCTByGvsn50GI6fAJM1SOVLf4ImeqccESMB/in?=
 =?us-ascii?Q?sg5/g2BjOSAOaL/u0uZsGhQ5IF1CbBrxLE5lwdnH3Ensgp0BNwOdyGeWbtY/?=
 =?us-ascii?Q?FXYekx3avoGdS3mFZgptSZ1a9cynjYJ7he64hMIerzgrt36jdkMJNBqt1w9i?=
 =?us-ascii?Q?wtUG0y9M/+lXQ73XPNKEPXlbW8RHlifdbea5s2CQNdsdtbvEyMjxB/SDbEiK?=
 =?us-ascii?Q?BCrx16l/X9sAqEl7tLAsufRbcPBdB+3PBgGHd+lbpNLnvTJnE9Wxo3pfq8i8?=
 =?us-ascii?Q?nRQJcS5kxoDtEXihZmtNaL1NOjczVop2y3jKopUix1fwrCFcRn05klLlVH2t?=
 =?us-ascii?Q?+PR/pa6yf96T8PkatkUzAgCwymUC68PMbCu78QFN74f5CF3XyPcw/9FxXwS0?=
 =?us-ascii?Q?dVRjos+ycIoR38/bx+bDj00ZkrDgPlpVBesA1Zw95IYgWdtog9hkDQstlBvr?=
 =?us-ascii?Q?PYWQ068Gj6NYLvMm7khZzWfswSqjZwG7k9F/N7AnQJBZD0NTQzckWziLs7EY?=
 =?us-ascii?Q?hMTXh/zwo/8NGOK4zyzCzzJfgOajJoqy3ov9ko0dQOLFCYdEbzz9H7lXgB3Y?=
 =?us-ascii?Q?h9EMsQU9DtO4gMmnm+NXsRj2LZzii1iBNKPQZPQrUhbuBPhKZlw0S4fyHSBw?=
 =?us-ascii?Q?tGBAN97AhcuNFEOprePj7QzKksKSEBBAbNFTIQS/p1vdfpKgTuHdYFrDfnil?=
 =?us-ascii?Q?cLNUZIScChlSek2HKUMEyOOtQLNcrbmAsCPQiVao0FQst9/1h12YzQG6BXUs?=
 =?us-ascii?Q?KpM6F7DfNitLMgwUw1kg4joDxqb2eRDakpJzSgQiHQkl2RLO/t12gb/UC+Fk?=
 =?us-ascii?Q?6K/ttC02e6HJ/1U7r9lN1Uyfm2f9/BTgPewEhfjue/dl3uOKwoqb7TyYvg7f?=
 =?us-ascii?Q?twfneF/+vqDJbNJfsPvv2ivn4IgWqs6H14FL2qhub62W7i3r/1xwsUBvBH61?=
 =?us-ascii?Q?UG1PM/tPYjsirX4S8K1eYVmsn93EX+Awgfu6OnIWKz6/uahgFqo6wT1BNRhs?=
 =?us-ascii?Q?DfxSjb1g9zAI4NKMZsk9o26kKbt0/nWinulJtwE2MiHlVhxn5oXda7mQN6+I?=
 =?us-ascii?Q?wAxF5bGNvySZXpEI4+G5bG3qpdhyuzGos3YZHhMOBTE7BABs7UAQ3pGJFQyC?=
 =?us-ascii?Q?ypGnysd45kEdq41qaolHPzqJ4o5hM3sf+9DKsoYmrb0p5iVnby+nRxxIjyjW?=
 =?us-ascii?Q?8vfA+aWj73PkI9re+EpEW7KCl53wllJYmCA9l21wAa845+OinKk0tsRfJw8f?=
 =?us-ascii?Q?x5c12uBNDltPyPz3sokW++Mk9XG89CcpHGFGdge7R6irvpr++UkT91FKRjQN?=
 =?us-ascii?Q?mOTvwzXseKggPsG87PCn0YIgeJfYPlqX/61J6G2d2J1QCl0dnUYQq085CKB3?=
 =?us-ascii?Q?7HzgnoxKbjV7Tc4wugsW3wFOvYmaYQRcfQpV8r/7Pjpkw1A/CE953ClHoy3Q?=
 =?us-ascii?Q?hRWEvXpONR2xyln9gtmE+mGU35cjYoy+3YRdo0h3GkNmhRI7whymYUQyY0qn?=
 =?us-ascii?Q?QixwcWxYdoJfyNNDRSWpuwZnQRG4Suuh2BeVtn+4psYnB5GpioZOv5E06rzp?=
 =?us-ascii?Q?EAcXMBKK0Vl9ZeiG/7OsQOhmuzzNL7NQgGaKBRYvjKfDSgzjYkB/5blLSNUz?=
x-ms-exchange-antispam-messagedata-1: YTvtJ4rsAYRkcg==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CC465C0ED11BCD4AB8120972E78F2EA1@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2629.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78294ef6-48c3-4ea6-01db-08da26f335bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 19:38:44.6143
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 87opIjgdwhdvtiNXACzri9gOOLLTWKoOnP7Z5jFsv9oxiVNiMRfLxhXkMwbzE5ouVWsH4Ys4ZFoZBHYPQ99nQHGGca/NrrSPOo1oAQqguX4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB2001
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_08:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250087
X-Proofpoint-ORIG-GUID: 3xeX-rexunNsV9ezazEdP-NwRfxBeUcu
X-Proofpoint-GUID: 3xeX-rexunNsV9ezazEdP-NwRfxBeUcu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 18, 2022, at 6:51 PM, Prakash Sangappa <prakash.sangappa@oracle.co=
m> wrote:
>=20
> semtimedop() should be converted to use hrtimer like it has been
> done for most of the system calls with timeouts. This system call
> already takes a struct timespec as an argument and can therefore
> provide finer granularity timed wait.
>=20
> Signed-off-by: Prakash Sangappa <prakash.sangappa@oracle.com>

Can I get a review of this patch?
Note this patch has been added to Andrew's mm tree.


> ---
> ipc/sem.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>=20
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 0dbdb98..6cd1a1b8 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -1995,7 +1995,10 @@ long __do_semtimedop(int semid, struct sembuf *sop=
s,
> 	int max, locknum;
> 	bool undos =3D false, alter =3D false, dupsop =3D false;
> 	struct sem_queue queue;
> -	unsigned long dup =3D 0, jiffies_left =3D 0;
> +	unsigned long dup =3D 0;
> +	ktime_t expires;
> +	int timed_out =3D 0;
> +	struct timespec64 end_time;
>=20
> 	if (nsops < 1 || semid < 0)
> 		return -EINVAL;
> @@ -2008,7 +2011,9 @@ long __do_semtimedop(int semid, struct sembuf *sops=
,
> 			error =3D -EINVAL;
> 			goto out;
> 		}
> -		jiffies_left =3D timespec64_to_jiffies(timeout);
> +		ktime_get_ts64(&end_time);
> +		end_time =3D timespec64_add_safe(end_time, *timeout);
> +		expires =3D timespec64_to_ktime(end_time);
> 	}
>=20
>=20
> @@ -2167,7 +2172,9 @@ long __do_semtimedop(int semid, struct sembuf *sops=
,
> 		rcu_read_unlock();
>=20
> 		if (timeout)
> -			jiffies_left =3D schedule_timeout(jiffies_left);
> +			timed_out =3D !schedule_hrtimeout_range(&expires,
> +						current->timer_slack_ns,
> +						HRTIMER_MODE_ABS);
> 		else
> 			schedule();
>=20
> @@ -2210,7 +2217,7 @@ long __do_semtimedop(int semid, struct sembuf *sops=
,
> 		/*
> 		 * If an interrupt occurred we have to clean up the queue.
> 		 */
> -		if (timeout && jiffies_left =3D=3D 0)
> +		if (timeout && timed_out)
> 			error =3D -EAGAIN;
> 	} while (error =3D=3D -EINTR && !signal_pending(current)); /* spurious *=
/
>=20
> --=20
> 2.7.4
>=20