Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220412135534.2796158-1-aford173@gmail.com>
In-Reply-To: <20220412135534.2796158-1-aford173@gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Mon, 25 Apr 2022 07:08:17 -0500
Message-ID: <CAHCN7x+C9dkdMKsx4uQqRBQrJDpF9v3RDhpuOmwNRMx0hj63TQ@mail.gmail.com>
Subject: Re: [PATCH 0/4] media: i2c: imx219: Enable variable xclk and 4-lane
To:     linux-media <linux-media@vger.kernel.org>
Cc:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Tim Harvey <tharvey@gateworks.com>,
        cstevens@beaconembedded.com,
        Adam Ford-BE <aford@beaconembedded.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 12, 2022 at 8:55 AM Adam Ford <aford173@gmail.com> wrote:
>
> The driver currently only supports a 2-lane camera, a fixed external
> clock (XCLK) at 24MHz, a fixed Pixel Rate of 182.4MHz, and a fixed
> link rate of 456MHz.  There are a bunch of hard-codec values in a
> table of operating modes which expect the above to be true.
>
> According to the datasheet, the driver is capable of operating in
> either 4-lane with a pixel rate of 280.8MHz and Linux frequency
> of 702MHz or 2-lane configured as stated above.  The XCLK can be
> anywhere from 6MHz - 27MHz instead of being fixed at 24MHz.
>
> Split up the hard-coded values into smaller helper functions that
> dynamically set the registers of the camera based on the XCLK and
> desired number of lanes.
>
> This series was tested on a Beacon RZ/G2M streaming video at 640x480
> to an LCD with fbdevsink
>
> media-ctl --links "'rcar_csi2 feaa0000.csi2':1->'VIN0 output':0[1]" -d /dev/media1
> media-ctl --set-v4l2 "'imx219 2-0010':0[fmt:SRGGB8_1X8/640x480 field:none]" -d /dev/media1
> yavta -w '0x009f0905 2048' /dev/v4l-subdev12
> gst-launch-1.0 v4l2src device=/dev/video7 ! video/x-bayer,width=640,height=480,format=rggb ! queue ! bayer2rgb ! fbdevsink
>
> Due to hardware limitations, the XCLK is still 24MHz, so anyone
> willing to test this series with a different XCLK would be appreciated.
>
> Due to the video format, streaming video at larger resolution was
> not feasible, however individual frames captured at 1920x1080 were
> successful.
>

Any comments from anyone on this series?

> Adam Ford (4):
>   media: i2c: imx219: Split common registers from mode tables
>   media: i2c: imx219: Support four-lane operation
>   media: i2c: imx219: Enable variable XCLK
>   media: i2c: imx219: Create DPHY helper function
>
>  drivers/media/i2c/imx219.c | 340 +++++++++++++++++++++++--------------
>  1 file changed, 213 insertions(+), 127 deletions(-)
>
> --
> 2.34.1
>