Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220325132126.61949-1-zhangjiachen.jaycee@bytedance.com> <CAJfpeguESQm1KsQLyoMRTevLttV8N8NTGsb2tRbNS1AQ_pNAww@mail.gmail.com>
In-Reply-To: <CAJfpeguESQm1KsQLyoMRTevLttV8N8NTGsb2tRbNS1AQ_pNAww@mail.gmail.com>
From:   Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Date:   Mon, 25 Apr 2022 21:32:57 +0800
Message-ID: <CAFQAk7ibzCn8OD84-nfg6_AePsKFTu9m7pXuQwcQP5OBp7ZCag@mail.gmail.com>
Subject: Re: Re: [RFC PATCH] fuse: support cache revalidation in
 writeback_cache mode
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xie Yongji <xieyongji@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Apr 25, 2022 at 8:41 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Fri, 25 Mar 2022 at 14:23, Jiachen Zhang
> <zhangjiachen.jaycee@bytedance.com> wrote:
> >
> > Hi all,
> >
> > This RFC patch implements attr cache and data cache revalidation for
> > fuse writeback_cache mode in kernel. Looking forward to any suggestions
> > or comments on this feature.
>
> Quick question before going into the details:  could the cache
> revalidation be done in the userspace filesystem instead, which would
> set/clear FOPEN_KEEP_CACHE based on the result of the revalidation?
>
> Thanks,
> Miklos

Hi, Miklos,

Thanks for replying. Yes, I believe we can also perform the
revalidation in userspace, and we can invalidate the data cache with
FOPEN_KEEP_CACHE cleared. But for now, there is no way we can
invalidate attr cache (c/mtime and size)  in writeback mode.

If it is more concise to implement most of the logic in userspace, do
you think we should add a flag for attr cache just like what
FOPEN_KEEP_CACHE does for data cache?

Thanks,
Jiachen