Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp598688pxb; Mon, 25 Apr 2022 17:46:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQq3Z+6bzjbgMHnN7q5IPTYCvq3OB/FUYVvI8uBJwReE1M4jycl5EjICbWF4DuOPffUcUr X-Received: by 2002:a05:6402:51d4:b0:423:ffef:1dfa with SMTP id r20-20020a05640251d400b00423ffef1dfamr22111103edd.336.1650934002338; Mon, 25 Apr 2022 17:46:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650934002; cv=none; d=google.com; s=arc-20160816; b=HHCqCq9CreP7qWZ2kupUEogUxgvWaggiBbuv5S5xuc0RALkmyIL3KoRYHRKJ90KwHm u9JrUn8lfTmwPA9nvXtBx8F++LQuWVUn0HfLJRk7mSyei1LUwrI4YBqrysRLC5zYoBin 99/grUDxWBvhNuixCm0x2m+keUP2xB5iPGCs+85cnC+BzTLHkDHhF+uSb22niJK/GFxE ttc+4DP4OcZFWWYDZyMJlq58GYOqerQZtCll+1b73tnvFMf/M6xuyxxHgGOc06BWbl98 cnFVe8C3R6tP83gKdideXIQwDuz9JmjgPTtchXdB34tYTW3fNFsaIvMLhGZ8zmGuCCO8 VYtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=hrOoewtJhmgZVFNviaA6Slr7SEW6ryGKzcMbCayfMvQ=; b=bJPv0vxjsgawzNDg5E7x9vYeFzEVOAPD7+BwUWvGKAE6Dzekxj6YKFpU4TIcWN+4Rt MxcGSdhFrC1tfHO8qw2reTCCwwotyVz8l0wOXg5+sCl7oSd8qfScoZhK74oe3DiTbEVk rMFcC3ae/4hcMTilqcfWdM0kkmtJgESzX25qlPjBwwCEMFVeP8/NjL6FDNoIX//SSHx+ xefF8v7Pyf9qChaLYNSLXaNtjGP85d7mN0w8lK5GrGjjhF2cy2l2OnRMcePDz5vCzE60 Oev6BZMxodiXm9e2OcIhOqfIcpuFJFSZsQ8/STScS5M5jso7jIPZp8i1MfukIR+gZsfv vwKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=SH5mEo74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a170906609300b006e803d493dcsi13618755ejj.989.2022.04.25.17.46.17; Mon, 25 Apr 2022 17:46:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=SH5mEo74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243212AbiDYQEl (ORCPT + 99 others); Mon, 25 Apr 2022 12:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243174AbiDYQEY (ORCPT ); Mon, 25 Apr 2022 12:04:24 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 540DF10FF0; Mon, 25 Apr 2022 09:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650902480; x=1682438480; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=hrOoewtJhmgZVFNviaA6Slr7SEW6ryGKzcMbCayfMvQ=; b=SH5mEo74mVFqeJ31MMb08/e59lVFWtXtXJHnCFW9OUhtzm9zv5Fkc7VY lolUmP54HLQ/FuJeQBIxKVPHOomteycbF6YzAAv4xKsWJxYp66oLK0UnK LgtZqG1OCqHnkE/4kob6pXAxPDrjUYEtgEolaEPn3jtUe9va2eLHBhT3G o=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 25 Apr 2022 09:01:20 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 25 Apr 2022 09:01:19 -0700 X-QCInternal: smtphost Received: from c-sbhanu-linux.qualcomm.com ([10.242.50.201]) by ironmsg02-blr.qualcomm.com with ESMTP; 25 Apr 2022 21:30:48 +0530 Received: by c-sbhanu-linux.qualcomm.com (Postfix, from userid 2344807) id 673B4B8E; Mon, 25 Apr 2022 21:30:47 +0530 (IST) From: Shaik Sajida Bhanu To: adrian.hunter@intel.com, ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com, yoshihiro.shimoda.uh@renesas.com, linus.walleij@linaro.org, digetx@gmail.com, briannorris@chromium.org, quic_riteshh@quicinc.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_asutoshd@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com, Shaik Sajida Bhanu , Liangliang Lu , "Bao D . Nguyen" Subject: [PATCH V5 1/5] mmc: core: Capture eMMC and SD card errors Date: Mon, 25 Apr 2022 21:30:39 +0530 Message-Id: <1650902443-26357-2-git-send-email-quic_c_sbhanu@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1650902443-26357-1-git-send-email-quic_c_sbhanu@quicinc.com> References: <1650902443-26357-1-git-send-email-quic_c_sbhanu@quicinc.com> X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add changes to capture eMMC and SD card errors. This is useful for debug and testing. Signed-off-by: Liangliang Lu Signed-off-by: Sayali Lokhande Signed-off-by: Bao D. Nguyen Signed-off-by: Ram Prakash Gupta Signed-off-by: Shaik Sajida Bhanu --- drivers/mmc/core/core.c | 6 ++++++ include/linux/mmc/host.h | 26 ++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 8cc2b74..6d086e9 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2247,6 +2247,12 @@ void mmc_rescan(struct work_struct *work) if (freqs[i] <= host->f_min) break; } + + /* + * Ignore the command timeout errors observed during + * the card init as those are excepted. + */ + host->err_stats[MMC_ERR_CMD_TIMEOUT] = 0; mmc_release_host(host); out: diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index c193c50..eb8bc5b 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -93,6 +93,25 @@ struct mmc_clk_phase_map { struct mmc_host; +enum mmc_err_stat { + MMC_ERR_CMD_TIMEOUT, + MMC_ERR_CMD_CRC, + MMC_ERR_DAT_TIMEOUT, + MMC_ERR_DAT_CRC, + MMC_ERR_AUTO_CMD, + MMC_ERR_ADMA, + MMC_ERR_TUNING, + MMC_ERR_CMDQ_RED, + MMC_ERR_CMDQ_GCE, + MMC_ERR_CMDQ_ICCE, + MMC_ERR_REQ_TIMEOUT, + MMC_ERR_CMDQ_REQ_TIMEOUT, + MMC_ERR_ICE_CFG, + MMC_ERR_CTRL_TIMEOUT, + MMC_ERR_UNEXPECTED_IRQ, + MMC_ERR_MAX, +}; + struct mmc_host_ops { /* * It is optional for the host to implement pre_req and post_req in @@ -501,6 +520,7 @@ struct mmc_host { /* Host Software Queue support */ bool hsq_enabled; + u32 err_stats[MMC_ERR_MAX]; unsigned long private[] ____cacheline_aligned; }; @@ -635,6 +655,12 @@ static inline enum dma_data_direction mmc_get_dma_dir(struct mmc_data *data) return data->flags & MMC_DATA_WRITE ? DMA_TO_DEVICE : DMA_FROM_DEVICE; } +static inline void mmc_debugfs_err_stats_inc(struct mmc_host *host, + enum mmc_err_stat stat) +{ + host->err_stats[stat] += 1; +} + int mmc_send_tuning(struct mmc_host *host, u32 opcode, int *cmd_error); int mmc_send_abort_tuning(struct mmc_host *host, u32 opcode); int mmc_get_ext_csd(struct mmc_card *card, u8 **new_ext_csd); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation