Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp601023pxb; Mon, 25 Apr 2022 17:51:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqzGJ6CvNhAQQeRCdSn8ZfOyK0FKoNewDnzNydR0+NwYFmYFS+s63qkaH6KwCxmkuVw1dM X-Received: by 2002:a17:906:a05a:b0:6ef:a44d:2f46 with SMTP id bg26-20020a170906a05a00b006efa44d2f46mr19374801ejb.192.1650934288979; Mon, 25 Apr 2022 17:51:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650934288; cv=none; d=google.com; s=arc-20160816; b=BKxqX+6IneR2xde5t4YmffB78jW4dVc0ja9LgvZww+InhXPPeSNtZAEY+cK9XJXh9J MkwvGgstrywxdK4u6iVR358K/xv3VQuyRIPd8YjAFPL54/nzl5DEtV32laGgcI2zZppF YqmrjmbdNML1es/+BG1VUotlVIVBkZtFSnJcIOi9/V8XtXliMBzeVViXE42TnzzIeziY UiYzxFjSEKnbl2CT2l25dnXFOLiO2MvDt2rwp6/kAOMaUuzfFUTAHUROTyb3AEitk4/v S8dMPtDC+rWoYlpqaNjTP9LbYo5DtGnlqZIdFnYCJ/Y+AW94h5eZ2CWXuboc3/p/4q6R TQEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Sr6NHdWKU3G7E0q97WawXDyYijNKn/3Z9o8oYg5lN24=; b=e4YUVBjw3ug7PABAeuZJUe0QJ49DqLNkRQkzA+kRWtx9lFaynkbe2KQvgKUWKSh4Es pQnhpiASy8obpAxtc6RadEFdLWch+8khw7ewvUTxG1eQw313h1EvhQMaqoNgBMWcq4/z p9SLkdy6KUlCL6D3oO4ij7ZEzrZs58WZbIAcmb4Y4dho5mcbRewnQe770T9PuFQn+S7L R2WB6YuzHBEd8PrgfRho69aaPr4UxQdph+WKY7rJ73p3lQ4K/F/+DcQ2mvq4MnE0V4N3 ZCy2bPvDFkL4imGA2GzXynn9anQnikA2lJCHOydkaH4Us8XdELAD6CcVBvO2g/fIytJf Galw== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=fL8CwR2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf3-20020a1709077f0300b006f391c8ce03si5759875ejc.984.2022.04.25.17.51.05; Mon, 25 Apr 2022 17:51:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=fL8CwR2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234440AbiDYNpJ (ORCPT + 99 others); Mon, 25 Apr 2022 09:45:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232864AbiDYNpH (ORCPT ); Mon, 25 Apr 2022 09:45:07 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A2F149698 for ; Mon, 25 Apr 2022 06:42:02 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id y21so11557154edo.2 for ; Mon, 25 Apr 2022 06:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sr6NHdWKU3G7E0q97WawXDyYijNKn/3Z9o8oYg5lN24=; b=fL8CwR2tPXkWXaAQUuSJKgbPIwbYhIxgddaWq/Kmn1MpbmxF8jXZwaZSVPOmueO1Hg +EjW6bFvMcc3wQd+SeKDvuaCSRLj8RjOLxXUT0jiN5Jw+ce4tN1swlKdjpRLiycy/X+B cOPgpIj104tgqAi1o39gLM1emMbRExpAK9Txg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sr6NHdWKU3G7E0q97WawXDyYijNKn/3Z9o8oYg5lN24=; b=Pw6XkiAAGlaF7Igz/p7plKwM2xv3c6xGNSS1DFaNRyIhcruIJ6O/ZJhCGO9hOvjsyl PvyWo95M0Qf9Zrks/v+a8EugKITndLGejt6SOOGOHnDgYkv0tyeQcxod18uKuo/cGjED F3kLMz0O9+hmTPTHCrAGiESgDVr0+UGzs8Gq1r5Aerw/N9qoiHBb5wmtfd/qXgr954Xk llyGlZsNyVUKaMbsPLU7gSCH14cXSNmhCyluCCRRPrSV7dgYAWTsJo9Rv+Qv1PzD/tym k7KvS+htLlPMOn5Wr31B/Tq1g/5/GNr6nfvIPLgERTM4dCNUYHQGgLcR176HOnDBPhPj YvFw== X-Gm-Message-State: AOAM531LuvYvyBRyV8QIZ94lVp7UjGBrp4wuNwspSTkSH5xELSabIwtQ WS2F0CHc2IBed46HtnXsJgWyZ9OsWg33Gqw61txYRg== X-Received: by 2002:a05:6402:50cb:b0:423:d7a8:719e with SMTP id h11-20020a05640250cb00b00423d7a8719emr18800324edb.37.1650894120851; Mon, 25 Apr 2022 06:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20220325132126.61949-1-zhangjiachen.jaycee@bytedance.com> In-Reply-To: From: Miklos Szeredi Date: Mon, 25 Apr 2022 15:41:49 +0200 Message-ID: Subject: Re: Re: [RFC PATCH] fuse: support cache revalidation in writeback_cache mode To: Jiachen Zhang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Xie Yongji Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Apr 2022 at 15:33, Jiachen Zhang wrote: > > On Mon, Apr 25, 2022 at 8:41 PM Miklos Szeredi wrote: > > > > On Fri, 25 Mar 2022 at 14:23, Jiachen Zhang > > wrote: > > > > > > Hi all, > > > > > > This RFC patch implements attr cache and data cache revalidation for > > > fuse writeback_cache mode in kernel. Looking forward to any suggestions > > > or comments on this feature. > > > > Quick question before going into the details: could the cache > > revalidation be done in the userspace filesystem instead, which would > > set/clear FOPEN_KEEP_CACHE based on the result of the revalidation? > > > > Thanks, > > Miklos > > Hi, Miklos, > > Thanks for replying. Yes, I believe we can also perform the > revalidation in userspace, and we can invalidate the data cache with > FOPEN_KEEP_CACHE cleared. But for now, there is no way we can > invalidate attr cache (c/mtime and size) in writeback mode. Can you please describe the use case for invalidating the attr cache? Thanks, Miklos