Date: Tue, 8 May 2007 15:53:27 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Rene Herman <rene.herman@gmail.com>, Andrew Morton <akpm@osdl.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: New Mitsumi legacy CD-ROM driver
Message-ID: <20070508135327.GQ4163@kernel.dk>
References: <464045F0.3040906@gmail.com> <84144f020705080653i16d324c8pbd2925d844f400fc@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84144f020705080653i16d324c8pbd2925d844f400fc@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 757
Lines: 26

On Tue, May 08 2007, Pekka Enberg wrote:
> Hi Rene,
> 
> On 5/8/07, Rene Herman <rene.herman@gmail.com> wrote:
> >+static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd)
> >+{
> >+       int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1;
> >+       int retries;
> >+       int err = 0;
> >+
> >+       kfree(mcd->toc);
> >+
> >+       mcd->toc = kzalloc(tracks * sizeof *mcd->toc, GFP_KERNEL);
> 
> Perhaps we should use krealloc() + memset() here?

and sizeof(*cmd->toc) as well.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/