Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968047AbXEHN41 (ORCPT ); Tue, 8 May 2007 09:56:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S968012AbXEHN4X (ORCPT ); Tue, 8 May 2007 09:56:23 -0400 Received: from khc.piap.pl ([195.187.100.11]:51784 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967498AbXEHN4W (ORCPT ); Tue, 8 May 2007 09:56:22 -0400 To: Michael-Luke Jones Cc: Jeff Garzik , netdev@vger.kernel.org, lkml , Russell King , ARM Linux Mailing List Subject: Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE References: <5BB7E1AB-5CE1-43C8-8CE3-E0DE0236BD09@cam.ac.uk> <86D26EBE-5899-468F-9C79-23E83E0DE04B@cam.ac.uk> <8CA5FD65-BEE1-4769-B1DF-81CA82210F61@cam.ac.uk> From: Krzysztof Halasa Date: Tue, 08 May 2007 15:56:20 +0200 In-Reply-To: <8CA5FD65-BEE1-4769-B1DF-81CA82210F61@cam.ac.uk> (Michael-Luke Jones's message of "Tue, 8 May 2007 08:02:15 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 27 Michael-Luke Jones writes: > Already in mach-ixp4xx, so can just be called npe.c I want ixp4xx_ prefix in module name, otherwise I'd call it npe.c, sure. > Debugging code? Can this go? Why? Especially with code having to work with third party binary-only firmware? Suicide. They are eliminated at build time = performance hit (OTOH this file isn't on any fast path). > It may be a matter of taste, but could some of the many definitions > at the top of ixp4xx_npe.c go in the header file here? It's actually not only a matter of taste, they are private to the .c file and I don't want to make them available to the public (but sure, I don't like them in .c either, I think nobody likes such definitions anywhere but they have to exist somewhere). -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/