Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968055AbXEHN5o (ORCPT ); Tue, 8 May 2007 09:57:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934598AbXEHN5j (ORCPT ); Tue, 8 May 2007 09:57:39 -0400 Received: from khc.piap.pl ([195.187.100.11]:45839 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934536AbXEHN5i (ORCPT ); Tue, 8 May 2007 09:57:38 -0400 To: Michael-Luke Jones Cc: Jeff Garzik , netdev@vger.kernel.org, lkml , Russell King , ARM Linux Mailing List Subject: Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR References: <5BB7E1AB-5CE1-43C8-8CE3-E0DE0236BD09@cam.ac.uk> <86D26EBE-5899-468F-9C79-23E83E0DE04B@cam.ac.uk> From: Krzysztof Halasa Date: Tue, 08 May 2007 15:57:37 +0200 In-Reply-To: (Michael-Luke Jones's message of "Tue, 8 May 2007 08:05:02 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 24 Michael-Luke Jones writes: > Already in mach-ixp4xx, so can just be called qmgr.c Same here. >> +#define QUEUE_IRQ_SRC_NEARLY_FULL 2 >> +#define QUEUE_IRQ_SRC_FULL 3 >> +#define QUEUE_IRQ_SRC_NOT_EMPTY 4 >> +#define QUEUE_IRQ_SRC_NOT_NEARLY_EMPTY 5 >> +#define QUEUE_IRQ_SRC_NOT_NEARLY_FULL 6 >> +#define QUEUE_IRQ_SRC_NOT_FULL 7 > > Here, unlike ixp4xx_npe.c defines are in qmgr.h - that seems a bit > more natural. Because they are public interface :-) -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/