Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 17:48:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Dave Kleikamp <shaggy@kernel.org>,
        jfs-discussion@lists.sourceforge.net,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jfs: remove unused pointer tblk
Message-ID: <20220425144804.GP2462@kadam>
References: <20220424161330.1360068-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220424161330.1360068-1-colin.i.king@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4O7jbtkmJlhrqhnD7dItLQP2UmhFVFvVHxdro8G2uPJBwn58Jvu5vDmW/nyT?=
 =?us-ascii?Q?bAybDwheDM0erdkYpaLTXaswxgPCVLov2JkuXu2c3p1PJuSnosnxKeYE7R3J?=
 =?us-ascii?Q?YsdvtVutcDwl5Gxh95T91NU+xZ65Jjis9mG+148FGJwDm9F7lKVWOJokLItY?=
 =?us-ascii?Q?oxQfPt7rB9feKY04UlNkQkG3E2UTSjqTMfy4/R7ALA/FvSP8t9Dzt3aIhW9X?=
 =?us-ascii?Q?LVabVXLKybpb96Q59HP6+ogVY2Z6Swdsj0qomAOE7hfOZGFYOwMDwpHXZe5/?=
 =?us-ascii?Q?f4iQ5gFAIp9ZuPx8JqDEUc6/H487Mg5ap379qjApLO+cr4jRzEyWy57ssX42?=
 =?us-ascii?Q?17luzm7VMNungM0rh9L5Po8kEj6++B7k1G3NBdZgbZEdqfhfLrhWSG1PihEB?=
 =?us-ascii?Q?Li8Jk8+rra4Tw0WFAeek6cDvFv/D1WC+FU4PffqdsbR7fgBrYQFfPSRank9v?=
 =?us-ascii?Q?QmgSVIT6XkRnhWNKfxjVwRKUsLk2w9K0LMALPFJPy5HQcSll+kgO91cU3dzk?=
 =?us-ascii?Q?k4KK4oXAooY2qSuIGLRXJogWtBR0h3q4Fs8brf8TO0x2uVZZKe36Kt9EMbc/?=
 =?us-ascii?Q?pAVX3vk+4RYPuFDdaqmyx1fXOR7uhHI7g5AKL7j0Qwcl1h7Q3KrMNUWFqwwZ?=
 =?us-ascii?Q?ylCpwdQj3APVev88M3eSphQ//sfShCUdBLscZE52qLUx97vpoHHCCOMjAnra?=
 =?us-ascii?Q?5PSQyYtdH0Zebn1lW45Hz+Ku2Ittuyzm2QHcAGz/6tfnYoEwgAvxv9Lbl54a?=
 =?us-ascii?Q?Aa3USloCOAz29Q/osK16fWmO+ACtHR4IK67kqKA+uW2I1zb0eWF649MxFa1k?=
 =?us-ascii?Q?moBvfotnGuwLMaAJRvy1/U5kbsM3kzh0JvV5z54FdK3z0ltBkXgJf8nOvCu6?=
 =?us-ascii?Q?LmhaRe3LZgC0x+mS8hYPf/r90uD8DHXcDueHceJonorDA6mklTYwBnfoNRAF?=
 =?us-ascii?Q?JIWBSt38vIesi2dFdLLcgBwRAYm8GgLlVZJOrp0XEgig/T6Pup3S/uY7m4ea?=
 =?us-ascii?Q?veVVITTbSC9dpOAALBMPbCCn1jQBGKtalA88tjPHlrPEGXYxCciMoW78RBni?=
 =?us-ascii?Q?0cF/tOXhpoD59oPGko+XOvLWAwIKzVKL/oGr1vXLwixOZrlC32vLJim7Kdrb?=
 =?us-ascii?Q?GW4qJxfH7mSLhRRU0zEzy3eUbuzE27pGTbT4wn15qOee8dSvRieqLMPnpDZr?=
 =?us-ascii?Q?37KIVwFwdJ4khbGwWusMUpA92LzCBhzk9w09o3ONwu/2ch1FadDDALlpBAv+?=
 =?us-ascii?Q?S1Kj+nTq8kVxyoJNquas9qbzmoG/3WhU7RbkNw9iDM7cAv83Q7xqQH0tUFLk?=
 =?us-ascii?Q?WYlhQ33xq/SQS+lZwWwvo7Zoy6B+n6122U1pP452ERLLUAqtgaCLdTIIaSsL?=
 =?us-ascii?Q?bCw8uIDwVjLEixODJDyTMI64aT5bq4pq7a2bSTcLWxO47kS+/Ko1F24g0ZQ4?=
 =?us-ascii?Q?LqlhFCJYQ4cXhE5Ns8prIvucN8Q+kXZscO/fptlZkES+oUzGvrOR8RAQn9dH?=
 =?us-ascii?Q?6a6En2YKwTKacQrj0bbHmOR9WKzU6E33vTtznsYuWIDYenv20ntcIskahoxn?=
 =?us-ascii?Q?yF4b5r9Eouhgt+j0Ew1GbLb/unpcwAFy1UwrtaHHgmoiBMHJOrWEum/YFsBC?=
 =?us-ascii?Q?0EuKWmxn3us7nSVuyrzn0ie+KKpExkyf4TSCOS4qde2zdnKV1qnb3iQfb/xi?=
 =?us-ascii?Q?v39MWPesuQY9Ch617Vtr49mTBPh5NSPz7G3nWaDt/alWSOABuHALoQiEhrV8?=
 =?us-ascii?Q?xshYijQUuqjMBIoEgHBwHbO3gNNHZR0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65bbaf97-262b-4824-4f2c-08da26caaac2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 14:48:32.3018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LKTHkGnbfykO98q+e47rBdsbQOCSzSu+XPWsOX5HlZL/SK8JwDtLc2+1Khr0wr2hfmvo5bNHAGvSDtU70tEuNR38u10zj3aISqn0UKpAwAk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3464
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_06:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=961
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204250064
X-Proofpoint-ORIG-GUID: 0atZGpmeQTD0s8T7LkaezRRyd7MUUjbi
X-Proofpoint-GUID: 0atZGpmeQTD0s8T7LkaezRRyd7MUUjbi
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
> The pointer tlbk is not used, it is redundant and can be removed.
> Cleans up cppcheck warning:
> 
> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/jfs/jfs_xtree.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
> index 3148e9b35f3b..d29979d0a6aa 100644
> --- a/fs/jfs/jfs_xtree.c
> +++ b/fs/jfs/jfs_xtree.c
> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad,	/* old XAD */
>  	   int xtype)
>  {				/* extent type: XTPAGE or DATAEXT */
>  	int rc = 0;
> -	struct tblock *tblk;

This would have caused a build error if it weren't ifdeffed out.

#ifdef _STILL_TO_PORT

JFS is an IBM filesystem from OS/2.  Apparently, this stuff never got
ported?  Probably we could just delete the dead code.

regards,
dan carpenter